From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 185263841887 for ; Wed, 29 Jun 2022 19:22:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 185263841887 Received: by mail-pg1-x533.google.com with SMTP id h192so16253431pgc.4 for ; Wed, 29 Jun 2022 12:22:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Cz+xN+1qrjFI1VKzhymaLOazu7CJmVLIEO5d2uO0eo=; b=Rpls8WxbpCnA3j21G5fjrC+uLOSKZuhCC2EXBeSb2oUNjoZPdNjpz8RmIStwivz0Y0 rw9scOl8mHfDGfUUXXdFmA6JOZhomeT1uNWq6twAMpEEsmfAt+ZiJ5SpaV+pOlHVZtn6 uugS2ujjnmXBLfc5I33ENFC6YMbjIEZcBNIxEniMtg4htXDDlsiu9Tss2h2fELsb17fG SrNzsZa4+oye5dUV28auMiL45t1+X1aHsPK99xVcF/5AyYbDQ0RHAm2QL9XXke8xTzrr XDP9ruj2MxXSt0SMmzM1Li6IQn1oLiibeSUTKX4EIcVRacbL9Zt7nO0waGGDGpym5iji t2og== X-Gm-Message-State: AJIora9m5exJ1aLat+1Vkzrtz0ypUpnqsoLsg/SzORud8tXY5C/LRoYp oZZe4B8BRMZJitEsYpxFYLZeXzMhUsYu0/Dlsbynq1PK X-Google-Smtp-Source: AGRyM1slPKNDzY1OjNbJw3BLzd7avIq3LKNKdUBvDv6WISJ2kzU5chi980vYJSGrgW9qQYRahmWd4b2RrIIpsYZk2sY= X-Received: by 2002:a63:b54c:0:b0:40c:7b84:4f7f with SMTP id u12-20020a63b54c000000b0040c7b844f7fmr4070135pgo.586.1656530521152; Wed, 29 Jun 2022 12:22:01 -0700 (PDT) MIME-Version: 1.0 References: <20220628152735.17863-1-goldstein.w.n@gmail.com> In-Reply-To: <20220628152735.17863-1-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Wed, 29 Jun 2022 12:21:25 -0700 Message-ID: Subject: Re: [PATCH v1 1/3] x86: Add definition for __wmemset_chk AVX2 RTM in ifunc impl list To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3025.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 19:22:03 -0000 On Tue, Jun 28, 2022 at 8:27 AM Noah Goldstein wrote: > > This was simply missing and meant we weren't testing it properly. > --- > sysdeps/x86_64/multiarch/ifunc-impl-list.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c b/sysdeps/x86_64/multiarch/ifunc-impl-list.c > index 251b0022d9..3ae4d49bee 100644 > --- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c > +++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c > @@ -1028,6 +1028,10 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, > IFUNC_IMPL_ADD (array, i, __wmemset_chk, > CPU_FEATURE_USABLE (AVX2), > __wmemset_chk_avx2_unaligned) > + IFUNC_IMPL_ADD (array, i, wmemset_chk, > + (CPU_FEATURE_USABLE (AVX2) > + && CPU_FEATURE_USABLE (RTM)), > + __wmemset_chk_avx2_unaligned_rtm) > IFUNC_IMPL_ADD (array, i, __wmemset_chk, > (CPU_FEATURE_USABLE (AVX512VL) > && CPU_FEATURE_USABLE (AVX512BW) > -- > 2.34.1 > LGTM. Thanks. -- H.J.