From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com
 [IPv6:2607:f8b0:4864:20::242])
 by sourceware.org (Postfix) with ESMTPS id 2640B3971832
 for <libc-alpha@sourceware.org>; Wed,  9 Dec 2020 18:29:49 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2640B3971832
Received: by mail-oi1-x242.google.com with SMTP id o25so2752707oie.5
 for <libc-alpha@sourceware.org>; Wed, 09 Dec 2020 10:29:49 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=cuwC8/Z2PX/uJBeh7EW8iLtCgd17JgC/bqG+Z3a0QMU=;
 b=cwCMSRtpO5GmuqyrHjEbamrEjU1HMvLLqRh2gMBEENZmU/moewuzNZVh82mLXkSgsT
 gJbW/XUnsTTaQjRTMof6gJMk+60pJGmxrGnWSPmaUnt9WD3BMMeP+B+nE+svShmOHti4
 jwkffAQCNlf6lE2sYnd/ASSSspM19pUdDoMx6TTeY7CXuEIFI06SwzTDiATcDgB4Xb0W
 mS1EQ4WKUwf1VlhO31ipT63AKij0g+nikEH2Y7Mc8JR8PX90wmShAwn+JQVCXlJrY1Lg
 y0XBwF4Y0TYTPmPQ5V1ncGIV0LcYhy3lbxt97RLW/wf+be3LJ1SzkSahN9JVKxnKrIe8
 Nllw==
X-Gm-Message-State: AOAM530WB4x09P45aTTBBXBCRwlAmOvNopMtZhMA0qaEAe90sSc/k7oc
 0gdrXRlzaaFbIvJKuJLQztGh4/tlii45S0vvRcPJh4mF
X-Google-Smtp-Source: ABdhPJw53PD7q2ymCdMj3CqQpachzlpaOKw+vS2nAFz3Hy0ac0Q1hzKz7PJ/i9Z7o7rqePc5RQgikTJlkD/qNqG8bjw=
X-Received: by 2002:aca:4d8b:: with SMTP id a133mr2816750oib.79.1607538588498; 
 Wed, 09 Dec 2020 10:29:48 -0800 (PST)
MIME-Version: 1.0
References: <87360e6dp2.fsf@oldenburg2.str.redhat.com>
In-Reply-To: <87360e6dp2.fsf@oldenburg2.str.redhat.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 9 Dec 2020 10:29:12 -0800
Message-ID: <CAMe9rOq+CjJyFc8EFi-JVL-Ukm2-FmzhDWSr_8odG7H1H3jEmw@mail.gmail.com>
Subject: Re: [PATCH] elf: Fix incorrect comparison in sort_priorities_by_name
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3036.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Dec 2020 18:29:50 -0000

On Wed, Dec 9, 2020 at 10:24 AM Florian Weimer via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Reported-By: Stefan Liebler <stli@linux.ibm.com>
>
> ---
>  elf/dl-hwcaps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/elf/dl-hwcaps.c b/elf/dl-hwcaps.c
> index 5a71f80154..000e3c0eb9 100644
> --- a/elf/dl-hwcaps.c
> +++ b/elf/dl-hwcaps.c
> @@ -153,7 +153,7 @@ sort_priorities_by_name (void)
>         else
>           to_compare = previous->name_length;
>         int cmp = memcmp (current->name, previous->name, to_compare);
> -       if (cmp >= 0
> +       if (cmp > 0
>             || (cmp == 0 && current->name_length >= previous->name_length))
>           break;
>
>

LGTM.

-- 
H.J.