From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id AB84C38515EB for ; Thu, 20 May 2021 14:41:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AB84C38515EB Received: by mail-oi1-x230.google.com with SMTP id v22so16618810oic.2 for ; Thu, 20 May 2021 07:41:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Llt1VMjG/HQKhkOEaNqPkgfb9t4AmTm3v7KZFhAB6UE=; b=TnVsFnqsNaGW4PBPUcCjPeC973YMbeFWhREFpq/+BHRtJ3+JhM+QDRLMThu/Jy1yzi DWesoPqQjUDobAAquMshuIwetF1dHbnG63eZSl6fQx2O6kBBIa4rVL5bOFuTraDADHW1 GaSB2zis5Lst3/WUWhYujSF9ZqqCyt3x4HQ1Yp3ku1psaIXJExeevzJh/tJRPYdSLMxp 4JQ5k4FxiR++PvALt3uJcfEr9yMQ7aHBb7J1AtpZArDL9Kk4WFubWHJe4mPgAMoAROn1 nvoqbKHOjrjbRAQJyeQ1Iqn1TkTK9I1Cao8KFlSoPu29ORzPTJJBmj3fDgSfZrmK1vdt TL3Q== X-Gm-Message-State: AOAM531tP6rG/8gHbXKflQh9dSiEu7S1nY2AK24C1YYM2bEM6F/+eKCv rgDMblyJ1FLLLUZx734hle0eVBqs8pXw/m+Rq+lr7dSgwwfFxw== X-Google-Smtp-Source: ABdhPJzuBj69hin2yZmJTWPexOdaLFCOJVFdH1bbTfxAR+9jjnQhK554ChPObwAlEpC9G2GhPCCFhIFX4+4KoGx9WGo= X-Received: by 2002:a05:6808:10d:: with SMTP id b13mr3495842oie.116.1621521668098; Thu, 20 May 2021 07:41:08 -0700 (PDT) MIME-Version: 1.0 References: <8754fc98101550a1354a5dff2447b870a7c04291.1621511874.git.fweimer@redhat.com> In-Reply-To: <8754fc98101550a1354a5dff2447b870a7c04291.1621511874.git.fweimer@redhat.com> From: "H.J. Lu" Date: Thu, 20 May 2021 07:40:32 -0700 Message-ID: Subject: Re: [PATCH 1/3] elf: Initialize GLRO (dl_minsigstacksize) after static dlopen To: Florian Weimer Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3034.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2021 14:41:11 -0000 On Thu, May 20, 2021 at 6:08 AM Florian Weimer via Libc-alpha wrote: > > This is another field of _rtld_global_ro that benefits from > initialization in __rtld_static_init. > --- > elf/rtld_static_init.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/elf/rtld_static_init.c b/elf/rtld_static_init.c > index bded6bd2d4..9c9e069b4d 100644 > --- a/elf/rtld_static_init.c > +++ b/elf/rtld_static_init.c > @@ -49,6 +49,8 @@ __rtld_static_init (struct link_map *map) > dl->_dl_hwcap = _dl_hwcap; > extern __typeof (dl->_dl_hwcap2) _dl_hwcap2 attribute_hidden; > dl->_dl_hwcap2 = _dl_hwcap2; > + extern __typeof (dl->_dl_hwcap2) _dl_minsigstacksize attribute_hidden; > + dl->_dl_minsigstacksize = _dl_minsigstacksize; > extern __typeof (dl->_dl_pagesize) _dl_pagesize attribute_hidden; > dl->_dl_pagesize = _dl_pagesize; > extern __typeof (dl->_dl_tls_static_align) _dl_tls_static_align > -- > 2.31.1 > > LGTM. Reviewed-by: H.J. Lu Thanks. -- H.J.