From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by sourceware.org (Postfix) with ESMTPS id 11D983858D39 for ; Sat, 3 Sep 2022 02:01:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 11D983858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf2b.google.com with SMTP id j6so2717038qvu.10 for ; Fri, 02 Sep 2022 19:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=z1TJbpeJQ3rKoenD9z4nmiLS7gvPK9kZJNASC9H8wIc=; b=RpyEoAyN8EQSIzI4v313hlHNavdwQirzHB14dlwBFuEZQpo/eifT0Hk1lMTOal32NQ COEUDvtzHrN8OQPIK6MjaMBuWUG6yrdqDWhn+bq8AZEo0NZlfUhY+w3VEhNsXkLdip/M p0puqDKHfKwrd+60mR8o5bSw092dDMbWa5DdBeO3+i3C4TneKypEqzm/VxwQ0jxbvrX1 iEZG4kn4JvpSQeIYkqJ186ANDmcYRe8wRK0E+qsr/a59NAS1usq1ozeDjVtvB0SHbgdM d/dIpzo53QDm/eshjklPXOlhNQviownbV8eJJA+hhKYNeXXeafnGxki8j/y9rpMBbD3r GEEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=z1TJbpeJQ3rKoenD9z4nmiLS7gvPK9kZJNASC9H8wIc=; b=x1gB+V5ntlaD12nV3Uhn/y5EEq1ZauPlYL0O3SAwr8rA4DLZPVucx5rv+c4vmxsMlk mEhonDS+GxySkc4eDI/1a4iUcaAf2vEhpPttic2SUrV2VYz6bf0YYRYBJ7U6tlhknLrq 9x1bIqpEv65pXKsDRDTY3c5oeOBhVw9lHMH8f4Ht13AvqAXizoLBPWBfiZWQhoPo94Q8 53QxqSHD7wsADvl9XzWB/dNkw1SUQYAzQd2SB3zqyPtoprsOqwj8D6qYe+q5KeHXmTwN q8oFCMIiXDuW6WfuKveXfEiYLYnaLxC3rhvVABF02PFgVkjDgZtK6efUrLrjDIoBsQPh HF+g== X-Gm-Message-State: ACgBeo0bSjniaERtujCWCNx5MlxJXnJXyfhTwkgTRwASNyo5djpvRcER zjQkgTbfx7RKdzgpcFyJheznqmy6TeAsPtlo+4Y= X-Google-Smtp-Source: AA6agR4uqRRCQwcQn0tLdfjjaG7uovSF3zyuzDiZGNkLf2P55XFdTngg3gExVVurJhRAhdOY8vu2vMYZlvhGDbYbb0E= X-Received: by 2002:a05:6214:411a:b0:499:7a6:ba8f with SMTP id kc26-20020a056214411a00b0049907a6ba8fmr22944610qvb.28.1662170477340; Fri, 02 Sep 2022 19:01:17 -0700 (PDT) MIME-Version: 1.0 References: <20220901130253.1684344-1-adhemerval.zanella@linaro.org> In-Reply-To: <20220901130253.1684344-1-adhemerval.zanella@linaro.org> From: "H.J. Lu" Date: Fri, 2 Sep 2022 19:00:41 -0700 Message-ID: Subject: Re: [PATCH] math: x86: Use prefix for FP_INIT_ROUNDMODE To: Adhemerval Zanella Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3024.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Sep 1, 2022 at 6:03 AM Adhemerval Zanella via Libc-alpha wrote: > > Not all compilers support the inline asm prefix '%v' to emit the avx > instruction if AVX is enable. Use a prefix instead. > > Checked on x86_64-linux-gnu and i686-linux-gnu. > --- > sysdeps/x86/fpu/sfp-machine.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/sysdeps/x86/fpu/sfp-machine.h b/sysdeps/x86/fpu/sfp-machine.h > index 5892f4f5fe..006eebe257 100644 > --- a/sysdeps/x86/fpu/sfp-machine.h > +++ b/sysdeps/x86/fpu/sfp-machine.h > @@ -39,9 +39,15 @@ typedef unsigned int UTItype __attribute__ ((mode (TI))); > > # define FP_RND_MASK 0x6000 > > +# ifdef __AVX__ > +# define AVX_INSN_PREFIX "v" > +# else > +# define AVX_INSN_PREFIX "" > +# endif > + > # define FP_INIT_ROUNDMODE \ > do { \ > - __asm__ __volatile__ ("%vstmxcsr\t%0" : "=m" (_fcw)); \ > + __asm__ __volatile__ (AVX_INSN_PREFIX "stmxcsr\t%0" : "=m" (_fcw)); \ > } while (0) > #else > # define _FP_W_TYPE_SIZE 32 > -- > 2.34.1 > LGTM. Thanks. -- H.J.