From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by sourceware.org (Postfix) with ESMTPS id 043BA3858424 for ; Mon, 7 Feb 2022 12:55:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 043BA3858424 Received: by mail-pj1-x1030.google.com with SMTP id m7so12691897pjk.0 for ; Mon, 07 Feb 2022 04:55:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=syBFRfY9WqLh4cAVOXEWb5XNnVogXXlY9Uqbntalf2I=; b=poWNSPnG1SUazZFzzDgfOGJVjwk7aFC2Oc6G0L/185gwPoVDOxx51kp26Hlq6pFldm Dg3xWcbxfwsFhoKQKDhzyMwJnrl9mFJSMsQm42T3v9J4CNy4c3OA2vA4uJ+Cu2rCSaae l6sgo8u5bG1FdgKNPPClkxYwaNHkSGAKsa2Wj/2vBzoQQn5LMX4qwtt93mAR5AV8yFLb Djg+/ntYlgxxe/xi4RcUisqaYzeNJ7N9PSQEaXkdssu97hcHAg/nINFAYjoi5bsNRNvI 0VElpfTJianEcpYGeKnP9BYV8dk1A1pAc0Vpd347bEuJiEScefHaosU4ti3mDt69M/v5 2A9g== X-Gm-Message-State: AOAM530gYRpz67bi3yjfto+6nAlV+tj5fvyrfJSAxnnJWXSPuoPj6OYn bHPukd/gRISqUPYTe+VnA97tZ+k0wO3R6TG5EpqHLb4Zntg= X-Google-Smtp-Source: ABdhPJzPtA5us3mFqK2DvowTkDrVeCUxHVPqSH+gOn/JAvmMV2CnoXTPlQhWS+hSfyKhmxCAxFSbt9X+04fqkuYLKz8= X-Received: by 2002:a17:90b:351:: with SMTP id fh17mr6633523pjb.28.1644238509989; Mon, 07 Feb 2022 04:55:09 -0800 (PST) MIME-Version: 1.0 References: <20220207063854.3324172-1-goldstein.w.n@gmail.com> In-Reply-To: <20220207063854.3324172-1-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Mon, 7 Feb 2022 04:54:33 -0800 Message-ID: Subject: Re: [PATCH v1] x86: Remove SSE3 instruction for broadcast in memset.S (SSE2 Only) To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3026.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2022 12:55:12 -0000 On Sun, Feb 6, 2022 at 10:39 PM Noah Goldstein wrote: > > commit b62ace2740a106222e124cc86956448fa07abf4d > Author: Noah Goldstein > Date: Sun Feb 6 00:54:18 2022 -0600 > > x86: Improve vec generation in memset-vec-unaligned-erms.S > > Revert usage of 'pshufb' in broadcast logic as it is an SSE3 > instruction and memset.S is restricted to only SSE2 instructions. > --- > sysdeps/x86_64/memset.S | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/sysdeps/x86_64/memset.S b/sysdeps/x86_64/memset.S > index ccf036be53..148553cf3d 100644 > --- a/sysdeps/x86_64/memset.S > +++ b/sysdeps/x86_64/memset.S > @@ -28,22 +28,23 @@ > #define VMOVU movups > #define VMOVA movaps > > -# define MEMSET_SET_VEC0_AND_SET_RETURN(d, r) \ > +#define MEMSET_SET_VEC0_AND_SET_RETURN(d, r) \ > movd d, %xmm0; \ > - pxor %xmm1, %xmm1; \ > - pshufb %xmm1, %xmm0; \ > - movq r, %rax > + movq r, %rax; \ > + punpcklbw %xmm0, %xmm0; \ > + punpcklwd %xmm0, %xmm0; \ > + pshufd $0, %xmm0, %xmm0 > > -# define WMEMSET_SET_VEC0_AND_SET_RETURN(d, r) \ > +#define WMEMSET_SET_VEC0_AND_SET_RETURN(d, r) \ > movd d, %xmm0; \ > pshufd $0, %xmm0, %xmm0; \ > movq r, %rax > > -# define MEMSET_VDUP_TO_VEC0_HIGH() > -# define MEMSET_VDUP_TO_VEC0_LOW() > +#define MEMSET_VDUP_TO_VEC0_HIGH() > +#define MEMSET_VDUP_TO_VEC0_LOW() What are these changes for? > -# define WMEMSET_VDUP_TO_VEC0_HIGH() > -# define WMEMSET_VDUP_TO_VEC0_LOW() > +#define WMEMSET_VDUP_TO_VEC0_HIGH() > +#define WMEMSET_VDUP_TO_VEC0_LOW() What are these changes for? > #define SECTION(p) p > > -- > 2.25.1 > -- H.J.