From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id C51843876053 for ; Tue, 28 Jun 2022 03:32:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C51843876053 Received: by mail-pj1-x1036.google.com with SMTP id w24so11265911pjg.5 for ; Mon, 27 Jun 2022 20:32:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I0qHc8d9xmnDkMScL/CDuy0V1AdJ/esj0BIiocKUZOE=; b=Cq8vTT/CSxHWN+YQ5tAb6N6Dp5VRX4FC9pdAoYXwQdaeqlfEtpxjRwDaS1cJfHKwx3 HwfrD2Bmi2+XiukIs9rfZqYod4Vj5UgiiMqgHzXtY3o1mfKiQkN42Ne0wC1N9PGNjVRV neGHz6MKsv42ry3crwfeRP7nsBWYlY4AoCS3sgwHlIe+ph5fg9Eefr9/e/xVWeENJQ0i FlUex2lcMlY5A3V3bSXw2ECYX0krnShz3XI3Oy7J797V4iqTIpjtqImZNThKOoz03GHY KE0xKEjVlUr3DolCkQl6JOZL8d1DSlLVm9QyWGuScD6kq9wruLqXvbeF5o831Ti5VrET 9ylg== X-Gm-Message-State: AJIora81V7qjobgSabEA5n9YtLdVGoLkIXYSGMtVmtxCFE0eFyqEOkyM F3rErwLx2LcWDbat8lEZuM0d1zy41FiLZQ0b7xvrKUMS X-Google-Smtp-Source: AGRyM1vlPtOap96eibHb00b3vLAd280aJgLxCTdg7dmJsspli0cWhqIzEtFforB+1+vZUN75x0b6IIBiLCQ30PVFhPE= X-Received: by 2002:a17:902:eb86:b0:16a:f36d:741a with SMTP id q6-20020a170902eb8600b0016af36d741amr1508596plg.149.1656387170786; Mon, 27 Jun 2022 20:32:50 -0700 (PDT) MIME-Version: 1.0 References: <20220628010446.3464287-1-goldstein.w.n@gmail.com> <20220628032602.218678-1-goldstein.w.n@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Mon, 27 Jun 2022 20:32:14 -0700 Message-ID: Subject: Re: [PATCH v3] x86: Add more feature definitions to isa-level.h To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3025.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 03:32:53 -0000 On Mon, Jun 27, 2022 at 8:30 PM H.J. Lu wrote: > > On Mon, Jun 27, 2022 at 8:26 PM Noah Goldstein wrote: > > > > This commit doesn't change anything in itself. It is just to add > > definitions that will be needed by future patches. > > --- > > sysdeps/x86/isa-level.h | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/sysdeps/x86/isa-level.h b/sysdeps/x86/isa-level.h > > index f293aea906..443631662f 100644 > > --- a/sysdeps/x86/isa-level.h > > +++ b/sysdeps/x86/isa-level.h > > @@ -71,11 +71,13 @@ > > #define AVX512F_X86_ISA_LEVEL 4 > > #define AVX512VL_X86_ISA_LEVEL 4 > > #define AVX512BW_X86_ISA_LEVEL 4 > > +#define AVX512DQ_X86_ISA_LEVEL 4 > > > > /* ISA level >= 3 guaranteed includes. */ > > #define AVX_X86_ISA_LEVEL 3 > > #define AVX2_X86_ISA_LEVEL 3 > > #define BMI2_X86_ISA_LEVEL 3 > > +#define MOVBE_X86_ISA_LEVEL 3 > > > > /* NB: This feature is enabled when ISA level >= 3, which was disabled > > for the following CPUs: > > @@ -89,6 +91,13 @@ > > when ISA level < 3. */ > > #define Prefer_No_VZEROUPPER_X86_ISA_LEVEL 3 > > > > +/* ISA level >= 2 guaranteed includes. */ > > +#define SSE4_2_X86_ISA_LEVEL 2 > > +#define SSSE3_X86_ISA_LEVEL 2 > > Please move them immediately after MOVBE_X86_ISA_LEVEL. BTW, comments should be ended with 2 spaces after '.'. > > +/* This feature is enabled when ISA level >= 2. */ > > +#define Fast_Unaligned_Load_X86_ISA_LEVEL 2 > > + > > /* Both X86_ISA_CPU_FEATURE_USABLE_P and X86_ISA_CPU_FEATURES_ARCH_P > > macros are wrappers for the respective CPU_FEATURE{S}_{USABLE|ARCH}_P > > runtime checks. They differ in two ways. > > -- > > 2.34.1 > > > > > -- > H.J. -- H.J.