From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 1205E3858434 for ; Thu, 7 Jul 2022 23:43:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1205E3858434 Received: by mail-pf1-x431.google.com with SMTP id d10so8334987pfd.9 for ; Thu, 07 Jul 2022 16:43:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nRJ8JnJ8s77LNj1Q6Z5IS0pwjyB7T06m3t0GcN69/Z8=; b=qpKb7E2CGu+NEibXRXKUdiiagL7kfl8yYLBfFz92yp9agsGOtAzG1PIIJpg0L7tPZc x1WJecV0sBhumry39fGDzLZ0nb3niLCPs2gusnMnGUzvJbEwEHQ2XzkdegZeIL2U4uKr oGN/57xfQH3B0AqT+Erx2UM9oeVLmslvV4LLZoeBU9RBYS1quUZeYKtQCICGwfN1GH7g W1b84H959Y6AwDJP3FV0tkN9DTqUTy80Vw0b96b0PBrKFMKzOjpbY7eF8JZXppabdsgm EkKEVXh9jwYk9dnGU8Re+2p3dIvW7B7XlDb7yPMQOUp6raJPbvrG27oAT80SKXRd3Wzx YDRg== X-Gm-Message-State: AJIora8LckvGSfMKdS21n3D9+w6g2gruvrVgo/zC/SE9Z3S7YSysAhkH Yb7ZeQ/6EF+8aR1c0D45mCnz1mkDxkZxE3S2s7juKFwr X-Google-Smtp-Source: AGRyM1smwmeMWYI/2hYACX7SxmeMa0gErA3bjUjdU6hTvcCOw7XOK89bP+x9BO7fe+NICHlSxhGcjkDzPK+vn7qBtJ8= X-Received: by 2002:a63:fb12:0:b0:412:b113:f537 with SMTP id o18-20020a63fb12000000b00412b113f537mr596065pgh.256.1657237411597; Thu, 07 Jul 2022 16:43:31 -0700 (PDT) MIME-Version: 1.0 References: <20220707233956.2483267-1-hjl.tools@gmail.com> In-Reply-To: <20220707233956.2483267-1-hjl.tools@gmail.com> From: "H.J. Lu" Date: Thu, 7 Jul 2022 16:42:55 -0700 Message-ID: Subject: Re: [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S To: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3024.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2022 23:43:35 -0000 On Thu, Jul 7, 2022 at 4:39 PM H.J. Lu wrote: > > Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and > strcmp-sse42.S since they are marked as hidden in the IFUNC selectors. > --- > sysdeps/x86_64/multiarch/strcmp-avx2.S | 1 - > sysdeps/x86_64/multiarch/strcmp-evex.S | 1 - > sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S > index 8da09bd86d..516cde1145 100644 > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S > @@ -184,7 +184,6 @@ > .align 16 > .type STRCMP, @function > .globl STRCMP > - .hidden STRCMP Hi Noah, Why aren't ENTRY/END used on STRCMP? > # ifndef GLABEL > # define GLABEL(...) __VA_ARGS__ > diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S > index 2a5b3ce037..e97d51bb26 100644 > --- a/sysdeps/x86_64/multiarch/strcmp-evex.S > +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S > @@ -214,7 +214,6 @@ > .align 16 > .type STRCMP, @function > .globl STRCMP > - .hidden STRCMP > > # ifdef USE_AS_STRCASECMP_L > ENTRY (STRCASECMP) > diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S > index a9178ad25c..60313c647a 100644 > --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S > +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S > @@ -77,7 +77,6 @@ > .align 16 > .type STRCMP_SSE42, @function > .globl STRCMP_SSE42 > - .hidden STRCMP_SSE42 > #ifdef USE_AS_STRCASECMP_L > ENTRY (GLABEL(__strcasecmp)) > movq __libc_tsd_LOCALE@gottpoff(%rip),%rax > -- > 2.36.1 > -- H.J.