From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by sourceware.org (Postfix) with ESMTPS id ACEF73858D20 for ; Fri, 4 Feb 2022 19:13:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ACEF73858D20 Received: by mail-pj1-x1030.google.com with SMTP id z14-20020a17090ab10e00b001b6175d4040so14009266pjq.0 for ; Fri, 04 Feb 2022 11:13:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SgeelzvGC32T2K0Su/U4rfih0+tS5BoHUi+iEmymdEI=; b=hhpPZ5mXqsYqFJ2LJkmtxFuSy7GTsofDHNSKvKR4FWd9XvPqAEg+pIWaxL2URWYFHD 7lWufdWCng5o3ROmVf34m32huFerjFAe2e3wzZEIa4T396jhCVVH4RLuM6iCEptvSfIF k3S+xMf6/DFnlSKQlpR0stGSlq96tEwB4mhI1l9QUmmy/WjqHY56Oa+cs7rWAJ6y4CDK irtzXzkb1/LpPen+E2UMfsw4PAZYvXzBZPs3w9bOiSlFBZ6RiAHgYFe4UIhDvy/fnz4a dj3mTblexjBxjzXF84CZFwM44UAg78+3zFVwcrKpGQYkTH1/N7nmHpAlvxw16nyqF5rE WABA== X-Gm-Message-State: AOAM530WF5PfaJoV6q1PPclrBHI4ekFc5hJOJa4bcfGlEaKS/mlyJoP1 OIp/qwi3uhCjWqlaC5qPOYBWbnU0Ljaj2gxfeqA= X-Google-Smtp-Source: ABdhPJzi+/mJYqauNyTkHn2y94jteZxuPnq2WqKOsyFGEcVTXNkwWo7QjzabAEYfGoibJzJFO4S5skriZoS1tSG8y+8= X-Received: by 2002:a17:902:e851:: with SMTP id t17mr4476560plg.102.1644002029815; Fri, 04 Feb 2022 11:13:49 -0800 (PST) MIME-Version: 1.0 References: <20220203214215.3275256-1-goldstein.w.n@gmail.com> <20220203214215.3275256-3-goldstein.w.n@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Fri, 4 Feb 2022 11:13:14 -0800 Message-ID: Subject: Re: [PATCH v4 3/5] x86: Optimize strcmp-avx2.S To: Joseph Myers Cc: Noah Goldstein , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3020.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 19:13:52 -0000 On Fri, Feb 4, 2022 at 10:57 AM Joseph Myers wrote: > > I've seeing a build failure for x32 that looks likely to be caused by this > patch. > > ../sysdeps/x86_64/multiarch/strcmp-avx2.S: Assembler messages: > ../sysdeps/x86_64/multiarch/strcmp-avx2.S:109: Error: unsupported instruction `mov' > /scratch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-x32/glibc/sysd-rules:847: recipe for target '/scratch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-x32/glibc/string/strncmp-avx2.o' failed > make[3]: *** [/scratch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-x32/glibc/string/strncmp-avx2.o] Error 1 > Fixed by: commit 0e0199a9e02ebe42e2b36958964d63f03573c382 Author: H.J. Lu Date: Fri Feb 4 11:11:08 2022 -0800 x86-64: Fix strcmp-evex.S Change "movl %edx, %rdx" to "movl %edx, %edx" in: commit 8418eb3ff4b781d31c4ed5dc6c0bd7356bc45db9 Author: Noah Goldstein Date: Mon Jan 10 15:35:39 2022 -0600 x86: Optimize strcmp-evex.S commit c15efd011cea3d8f0494269eb539583215a1feed Author: H.J. Lu Date: Fri Feb 4 11:09:10 2022 -0800 x86-64: Fix strcmp-avx2.S Change "movl %edx, %rdx" to "movl %edx, %edx" in: commit b77b06e0e296f1a2276c27a67e1d44f2cfa38d45 Author: Noah Goldstein Date: Mon Jan 10 15:35:38 2022 -0600 x86: Optimize strcmp-avx2.S -- H.J.