From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by sourceware.org (Postfix) with ESMTPS id 580EE3858D37 for ; Mon, 10 Oct 2022 16:52:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 580EE3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-x829.google.com with SMTP id c23so2807809qtw.8 for ; Mon, 10 Oct 2022 09:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pXQWLJ3S22lN70JBZcRHSNhqgF2LnxmdDMwuIosTb7A=; b=YlRefqo40ykzPcCOktmS3+o+vKVP6KkbaFFML13uhtQxiDXTlDmNM+G6g1+0Hg4cx7 HXCJvQjUPxRua8tRxS9eScykxEsORLYQdMys6vmM3ryGy/lIN5Mq/M7MwdlnSSaUR+gw 2nuOuylcs4Vu9zNy5V6aBuVNxx3ZM2MwCtuy72ZXckB4qrpP47odPZbbTUNLU+ZLT7CW WMJXHQNkoaqQcjfeXaDvgso29i6jDW5QNag2e5B7lDM23rRPxEPfUXUu5CdugaiTRRBL tlYwxQ6PbzR1E6bcNsbJmnZIYv4UslS0XbF3inmI4izJSYotHqCc5yq7ytcEBmaiv+K+ v2qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pXQWLJ3S22lN70JBZcRHSNhqgF2LnxmdDMwuIosTb7A=; b=Vla061DtNtE8B4PwmxsdEF6Et11YzM/1kNxwL7Z+sPgfECh8XvfDR+g6Ob+BYGkpPj Iwe/8WEHJZv/Bq6M0KOIwtQtI5F4aPDu/eUGBQJQ0QqF0xk9OfpaeXoxxI0rhDjnlKr9 JjQEPheTrgycIdKNOaLcRhJBTX5QBGzZaGupUXyzSdmbZYqBo5czeyZ8p67rzz7nCpeT BjAbNBB4Ka8xzstzDiVVDo9hd8JGAARnaVfA0BrjpIdVhxJQiR86QJbwt/FItYhZFZ1P K5c0auPTxO4Z9KNdwMLmptin6vQDcSeqZP1VDphSr4BPnFMsuMOLbEEfI3RthfkEjWrB HQCA== X-Gm-Message-State: ACrzQf3M5IjDUwn6CqzrtQkNcFEa+E617OSayOjOlE412SPzjA6h+9nx UEbkcQvG2rrWSSQTrZBdBagU9BB7lXuOTDJ53cs= X-Google-Smtp-Source: AMsMyM6ExeNgTNj4cb17QZiY/Ep+MzhPRznxFTri8QvEeeoW7bRszmok/DBBN4xtbDQ+2i9hap84p0uH3egnqNCSWH8= X-Received: by 2002:a05:622a:134b:b0:39a:4442:cbb6 with SMTP id w11-20020a05622a134b00b0039a4442cbb6mr4772940qtk.500.1665420763975; Mon, 10 Oct 2022 09:52:43 -0700 (PDT) MIME-Version: 1.0 References: <20221010164842.453596-1-skpgkp2@gmail.com> In-Reply-To: <20221010164842.453596-1-skpgkp2@gmail.com> From: "H.J. Lu" Date: Mon, 10 Oct 2022 09:52:08 -0700 Message-ID: Subject: Re: [PATCH] String: Improve test coverage for memchr To: Sunil K Pandey Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3024.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Oct 10, 2022 at 9:49 AM Sunil K Pandey via Libc-alpha wrote: > > This test improves memchr coverage near page boundary. > --- > string/test-memchr.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/string/test-memchr.c b/string/test-memchr.c > index 279a67ebe6..1cbcd57fd4 100644 > --- a/string/test-memchr.c > +++ b/string/test-memchr.c > @@ -247,8 +247,11 @@ test_main (void) > /* BZ#21182 - wrong overflow calculation for i686 implementation > with address near end of the page. */ > for (i = 2; i < 16; ++i) > - /* page_size is in fact getpagesize() * 2. */ > - do_test (page_size / 2 - i, i, i, 1, 0x9B); > + { > + /* page_size is in fact getpagesize() * 2. */ > + do_test (page_size / 2 - i, i, i, 1, 0x9B); > + do_test (page_size / 2 - i, i - 1, i - 1, 1, 0x9B); > + } > > do_random_tests (); > do_overflow_tests (); > -- > 2.36.1 > LGTM. Thanks. -- H.J.