From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by sourceware.org (Postfix) with ESMTPS id 460523858D28 for ; Mon, 8 Apr 2024 16:58:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 460523858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 460523858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1134 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712595519; cv=none; b=HA2DMc1S0euy5aat5F6ywZCmoBPy9DgBKRC1nUV4/XY6VFRjPYA/SdmbvXvEqP5J+uww223w/ZLwCRQUraxXXm6dxkZbwUQAacQyimyRu/R8CcW6Vb+iiSaaw7L7pr5BjKQhFE8HnQ3ukyoJRJbHIrGcktEM3vB72H7ztg/DpUk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712595519; c=relaxed/simple; bh=Nd397HH5Nk8zcoUSX5rUMb8ehICUh2kgesxx/LgM15A=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Hbi+dFPx6gT9etctUZWRn/6sLLzbghaEXD/4Pg9HDo1/tXa0dh1RaGFcWUaDz41IrOH/leMOvS4Z6Xhe2kfJfRDRhpFCicmEwuzIKTxQ11FQVCbGG+v2VAOFCgIwJjB6s0prjM86D76rtH74F55USrspH4l3VIdOG/4A8WxgYYs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-61805d5b1deso12538237b3.0 for ; Mon, 08 Apr 2024 09:58:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712595517; x=1713200317; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aK1J+4XdAVFXN12q6WWPyRN7pFtvAJ9hgG74Xp8tL0A=; b=eLlW4bLM567DOE+2Qqn9Te/6UF9+8E8LHj1ENq7KxkCJad64rbAJSUMrJ3B0TLFM+f q2PKNofe3HTD3RxcoGJtDo5MS3lwq2U9HCsDwPe8bSBBrBJU2d04v84unV0tPyUY8NnZ mCrTBQW6c64TTpb+I9Om0onZenpcRDr7FuHojVcTGX1vVBErACIgvgiawnOfAQTTl/tz MWm6dRsJOGfl10FYpElDx5jHOEbjNNZT2MDr61meWhq+u+YPdGt78/4X+2du3TVu6LZH dA4JA7stEUyLk1ZTcj9JmqP2IU7JzSXTl0Z+IkXiN+YSFKF+mZi6dCbndSAyDQksuTXv xmbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712595517; x=1713200317; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aK1J+4XdAVFXN12q6WWPyRN7pFtvAJ9hgG74Xp8tL0A=; b=gnwQPtWVD+2xrqFLLmKjAGF66+uastQV7c8TuFZsZ29BqH+9AghLiYAncnI2I64pCO 0pjo7eoPSXZUXf5UkGxwS2T+MI6PUIMEHgWjCb4VIBtcdDN2ixYrOguh2P+g69pZImyy +hJX/dv3cd5pyp+t1dysc2222Y33jNJZuN9cOQPqfTTANPiJiSYTM35TfEY3SaH+HGks fvod06PgbJHv393UC3Pacosst/szJgbIwBnZjx/LPZqQ0iQSGtaBhxUDiFrCTTSXeYOX VCrkjX/kf1c+o8YfZDY1v1t2Q2VRLKep96kBTzyULX6Z4pDp5FqRZ2ily7uYj9g/jUsY SjNQ== X-Gm-Message-State: AOJu0YwyGIx7nRzx78+b5oMD22UL9qmfLB7l84kA19sbTsph7eia/yuC p4pgK25JOHr1bgYEMWLhhFl8Ei2f8gCmqNkSADwbYni6VeG/+EIwFcQH5jiVIVlU0Ub/GS2G8rT b96rVcisxSEH6LyOb3G8OLR1nulnWPrFm X-Google-Smtp-Source: AGHT+IF5P2erj1MwDcwJYTFuBL27x+PeYsgljDKqim+sgJrfZ4CWGRL2yax5niRjPQLwRDWqJPcc394EZdnrP2DjZ9w= X-Received: by 2002:a05:6902:20c9:b0:dcf:3ef2:6182 with SMTP id dj9-20020a05690220c900b00dcf3ef26182mr9001044ybb.0.1712595517672; Mon, 08 Apr 2024 09:58:37 -0700 (PDT) MIME-Version: 1.0 References: <20240408160609.1264205-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Mon, 8 Apr 2024 09:58:01 -0700 Message-ID: Subject: Re: [PATCH] elf: Check objname before calling fatal_error To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3019.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Apr 8, 2024 at 9:47=E2=80=AFAM Adhemerval Zanella Netto wrote: > > > > On 08/04/24 13:06, H.J. Lu wrote: > > _dl_signal_error may be called with objname =3D=3D NULL. _dl_exception= _create > > checks objname =3D=3D NULL. But fatal_error doesn't. Check objname be= fore > > calling fatal_error. This fixes BZ #31596. > > Do we have a reproducer for this? The one from BZ#31596 does seems to tri= gger > it. We don't. But it may happen in theory. > > --- > > elf/dl-catch.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/elf/dl-catch.c b/elf/dl-catch.c > > index 2109516dba..8ef7a4c706 100644 > > --- a/elf/dl-catch.c > > +++ b/elf/dl-catch.c > > @@ -126,7 +126,11 @@ _dl_signal_error (int errcode, const char *objname= , const char *occasion, > > __longjmp (lcatch->env[0].__jmpbuf, 1); > > } > > else > > - fatal_error (errcode, objname, occasion, errstring); > > + { > > + if (objname =3D=3D NULL) > > + objname =3D ""; > > + fatal_error (errcode, objname, occasion, errstring); > > + } > > } > > rtld_hidden_def (_dl_signal_error) > > --=20 H.J.