From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 21E5B396EC3F for ; Mon, 28 Jun 2021 11:42:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 21E5B396EC3F Received: by mail-pf1-x434.google.com with SMTP id d12so6153900pfj.2 for ; Mon, 28 Jun 2021 04:42:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0aU7+g4mU013NzxxBQlVP9PQ4amrDN5KGTX5nwad0Jo=; b=QTWQwdBKedpoiHrbSwfks4q74HiV8VXXDH3F5GQbJklgK2wIYpey8YaCEvMNMLgX6B pJo18QGOX2kjiBM4oyVqYk1Pa2EerwwXV1KYxrIhYQ1JTNYV3jS4gCiAED4yJ0t5awOE 0F5ovniAKpTfK6ihogNmlh2W2D3cBbffclBpm/JV5pkM27kPlEWxRd0ZKVgywMLdwWy9 IZdTCf9mDy9++bdXUr/awswuHAxxesDbawkOWBbML9n1qZ8YjFs3ezpoXsAlWAx1I4P9 M8x/tDE5qT04YSuY9hyIA+bl3N4cC+LuIuktK7/YGtWPbOXEjPtoaoOaoxFKt/H/vrYN 5Erw== X-Gm-Message-State: AOAM530O0gpwG0qcn1jzguLh9U1n5d4GjpYkATuMCkdwsJOKTpDr99yo gRaQaCXB0dIuY/o4uvC05r4yuXfqAnSw6MGJdHJcbk5NQcU= X-Google-Smtp-Source: ABdhPJwM9PkOvNuxCLM81Aom17e40PuZEkcHHAKZH/iYobOY7k20pP0NtVc3Y3wWIv90Zu84RavnVW88bjUSsdDn/gI= X-Received: by 2002:a65:478d:: with SMTP id e13mr23162824pgs.37.1624880556187; Mon, 28 Jun 2021 04:42:36 -0700 (PDT) MIME-Version: 1.0 References: <20210623222846.2162301-1-hjl.tools@gmail.com> <20210623222846.2162301-3-hjl.tools@gmail.com> <87o8bq8l7t.fsf@igel.home> In-Reply-To: From: "H.J. Lu" Date: Mon, 28 Jun 2021 04:42:00 -0700 Message-ID: Subject: Re: [PATCH v8 2/4] Update math: redirect roundeven function To: Stefan Liebler Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3025.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 11:42:38 -0000 On Mon, Jun 28, 2021 at 1:34 AM Stefan Liebler via Libc-alpha wrote: > > On 28/06/2021 10:08, Andreas Schwab wrote: > > s390x fails to build. > > > > gcc ../sysdeps/s390/fpu/s_roundevenl.c -c -std=3Dgnu11 -fgnu89-inline = -O2 -g -m64 -fmessage-length=3D0 -funwind-tables -fasynchronous-unwind-tabl= es -Wall -Wwrite-strings -Wundef -Werror -fmerge-all-constants -frounding-m= ath -fstack-protector -Wstrict-prototypes -Wold-style-definition -fno-math-= errno -mlong-double-128 -I../include -I/home/abuild/rpmbuild/BUIL= D/glibc-2.33.9000.810.g5adda61f62/cc-base/math -I/home/abuild/rpmbuild/BUI= LD/glibc-2.33.9000.810.g5adda61f62/cc-base -I../sysdeps/unix/sysv/linux/s3= 90/s390-64 -I../sysdeps/unix/sysv/linux/wordsize-64 -I../sysdeps/unix/sys= v/linux/s390/fpu -I../sysdeps/s390/fpu -I../sysdeps/unix/sysv/linux/s390 = -I../sysdeps/s390/nptl -I../sysdeps/ieee754/ldbl-64-128 -I../sysdeps/iee= e754/ldbl-opt -I../sysdeps/unix/sysv/linux/include -I../sysdeps/unix/sysv/= linux -I../sysdeps/nptl -I../sysdeps/pthread -I../sysdeps/gnu -I../sysd= eps/unix/inet -I../sysdeps/unix/sysv -I../sysdeps/unix -I../sysdeps/posi= x -I../sysdeps/s390/s390-64 -I../sysdeps/wordsize-64 -I../sysdeps/s390/m= ultiarch -I../sysdeps/s390 -I../sysdeps/ieee754/ldbl-128 -I../sysdeps/ie= ee754/dbl-64 -I../sysdeps/ieee754/flt-32 -I../sysdeps/ieee754 -I../sysde= ps/generic -I.. -I../libio -I. -D_LIBC_REENTRANT -include /home/abuild/rp= mbuild/BUILD/glibc-2.33.9000.810.g5adda61f62/cc-base/libc-modules.h -DMODUL= E_NAME=3Dlibm -include ../include/libc-symbols.h -DPIC -DTOP_NAMESPACE= =3Dglibc -o /home/abuild/rpmbuild/BUILD/glibc-2.33.9000.810.g5adda61f62/cc-= base/math/s_roundevenl.o -MD -MP -MF /home/abuild/rpmbuild/BUILD/glibc-2.33= .9000.810.g5adda61f62/cc-base/math/s_roundevenl.o.dt -MT /home/abuild/rpmbu= ild/BUILD/glibc-2.33.9000.810.g5adda61f62/cc-base/math/s_roundevenl.o > > /tmp/ccYVXAks.s: Assembler messages: > > /tmp/ccYVXAks.s:42: Error: symbol `__roundevenl' is already defined > > make[2]: *** [/home/abuild/rpmbuild/BUILD/glibc-2.33.9000.810.g5adda61f= 62/cc-base/sysd-rules:135: /home/abuild/rpmbuild/BUILD/glibc-2.33.9000.810.= g5adda61f62/cc-base/math/s_roundevenl.o] Error 1 > > > > Andreas. > > > > Hi Andreas, > > I've also just recognized this issue and will post a patch later. > Sorry for this. Why didn't scripts/build-many-glibcs.py catch it? $ s390x-glibc-linux-gnu-gcc ../sysdeps/s390/fpu/s_roundevenl.c -c -std=3Dgnu11 -fgnu89-inline -g -O2 -Wall -Wwrite-strings -Wundef -Werror -fmerge-all-constants -frounding-math -fno-stack-protector -Wstrict-prototypes -Wold-style-definition -fno-math-errno -mlong-double-128 -I../include -I/export/project/tools-build/glibc-many/build/glibcs/s390x-linux-gnu/glibc= /math -I/export/project/tools-build/glibc-many/build/glibcs/s390x-linux-gnu/glib= c -I../sysdeps/unix/sysv/linux/s390/s390-64 -I../sysdeps/unix/sysv/linux/wordsize-64 -I../sysdeps/unix/sysv/linux/s390/fpu -I../sysdeps/s390/fpu -I../sysdeps/unix/sysv/linux/s390 -I../sysdeps/s390/nptl -I../sysdeps/ieee754/ldbl-64-128 -I../sysdeps/ieee754/ldbl-opt -I../sysdeps/unix/sysv/linux/include -I../sysdeps/unix/sysv/linux -I../sysdeps/nptl -I../sysdeps/pthread -I../sysdeps/gnu -I../sysdeps/unix/inet -I../sysdeps/unix/sysv -I../sysdeps/unix -I../sysdeps/posix -I../sysdeps/s390/s390-64 -I../sysdeps/wordsize-64 -I../sysdeps/s390/multiarch -I../sysdeps/s390 -I../sysdeps/ieee754/ldbl-128 -I../sysdeps/ieee754/dbl-64 -I../sysdeps/ieee754/flt-32 -I../sysdeps/ieee754 -I../sysdeps/generic -I.. -I../libio -I. -D_LIBC_REENTRANT -include /export/project/tools-build/glibc-many/build/glibcs/s390x-linux-gnu/glibc/l= ibc-modules.h -DMODULE_NAME=3Dlibm -include ../include/libc-symbols.h -DTOP_NAMESPACE=3Dglibc -o /export/project/tools-build/glibc-many/build/glibcs/s390x-linux-gnu/glibc/m= ath/s_roundevenl.o -MD -MP -MF /export/project/tools-build/glibc-many/build/glibcs/s390x-linux= -gnu/glibc/math/s_roundevenl.o.dt -MT /export/project/tools-build/glibc-many/build/glibcs/s390x-linux-gnu/gli= bc/math/s_roundevenl.o compiled fine. --=20 H.J.