From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com
 [IPv6:2607:f8b0:4864:20::62d])
 by sourceware.org (Postfix) with ESMTPS id AE220385842F
 for <libc-alpha@sourceware.org>; Sat, 12 Feb 2022 15:47:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AE220385842F
Received: by mail-pl1-x62d.google.com with SMTP id u12so7014531plf.13
 for <libc-alpha@sourceware.org>; Sat, 12 Feb 2022 07:47:13 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=OS+8HR+FheD/EwNjnwOqWFRnbYhW5WDRPdGucDTqqt0=;
 b=lpxTCVQETLyweezIiyG2nq0QJbn26KcaSkXuW8mAspn79EhpScGpiqiUXbFn3bpqN8
 6ErkDUih7rgLYasAnSlfihHMGWIBM0jEkK/24MeHFT0q+ybq7WLIjWV1MCMjZk7PaeAJ
 16HnERwqu+00SvWnx8almobhmcvNzn1dnVc4NcJDn1FVwul3uBIJVRxg1HQ5PM/nVgFJ
 wDKARPgeBzZlUzRLb7ugX21Twl4biBNdGUmVSu5IBc3V6mPjVRCUy/6jXoEX/NCZQnAZ
 IUKsA8mBY/lrD81OqpnJTilJAyS4t0eaUcP2IG/7Z70cRF7Atxin6pGpXusjk7qPqK68
 /alA==
X-Gm-Message-State: AOAM530jfwrOWcoW38hanFX5N/6bpH362lzxuDwkfF+21xfVtHy60kPF
 EAcvNeaWvVcrNGUnZQgaNk1RmxLBEM1wb1MUdCo=
X-Google-Smtp-Source: ABdhPJxGj8bEsx1RSFhb8iNwl0hmmq9l5eWzB95KJu9NtlmjfE3/kYmpIt/64Zjl8WLYux0gutfWIkl8TCWftYBBetY=
X-Received: by 2002:a17:902:e84f:: with SMTP id
 t15mr6321545plg.102.1644680832692; 
 Sat, 12 Feb 2022 07:47:12 -0800 (PST)
MIME-Version: 1.0
References: <20220212102529.1380928-1-goldstein.w.n@gmail.com>
In-Reply-To: <20220212102529.1380928-1-goldstein.w.n@gmail.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Sat, 12 Feb 2022 07:46:36 -0800
Message-ID: <CAMe9rOq8mXuHvTLnpa_awhm5Cr_qDNg9YQNsis0RTQ7cgY3bKA@mail.gmail.com>
Subject: Re: [PATCH v1] x86: Set .text section in memset-vec-unaligned-erms
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
 "Carlos O'Donell" <carlos@systemhalted.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3026.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Feb 2022 15:47:14 -0000

On Sat, Feb 12, 2022 at 2:25 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> commit 3d9f171bfb5325bd5f427e9fc386453358c6e840
> Author: H.J. Lu <hjl.tools@gmail.com>
> Date:   Mon Feb 7 05:55:15 2022 -0800
>
>     x86-64: Optimize bzero
>
> Remove setting the .text section for the code. This commit
> adds that back.
> ---
>  sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> index 7c94fcdae1..785fee1d57 100644
> --- a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> +++ b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> @@ -114,6 +114,7 @@
>  # error SECTION is not defined!
>  #endif
>
> +       .section SECTION(.text), "ax", @progbits
>  #if IS_IN (libc)
>  # if defined SHARED
>  ENTRY_CHK (WMEMSET_CHK_SYMBOL (__wmemset_chk, unaligned))
> --
> 2.25.1
>

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.

-- 
H.J.