From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 4F5703850406 for ; Mon, 1 Mar 2021 23:20:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4F5703850406 Received: by mail-ot1-x32e.google.com with SMTP id 40so9845551otu.0 for ; Mon, 01 Mar 2021 15:20:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4alHIGFQ/eGoQCFcjC+QQFXjIcrJAZoVhwJ0+2oMYAc=; b=aTnffH0wY7qYgjulc7dSE5QvkddcqwRpT1UG3Hj0EvRkhc1Cgo9yptYaJTO8CzpAZT JwULgOiPK05O7AM7tQBaCUdDOkS3H+c9UOgFUsD9uj9iKwaftAHKcIwPA+AuVJoEl0XJ PiDh8y6JpVMsdNTrqgDx33MomgjZGBKO6DnMu+Ndk22bxMFbE+97pfPit/DTV24ikZva psjhvk8JxsLi16r5IWx/7U2pijp9UfhABubXyLmTe3si3J9vLMRCILALOoPCgtu7xjOq EAJCP5yFKbVSt55kLuaD0+HYwAucomkrkDYn08ugTf/KhK5/yOu6sOecawz6hc4xucdf a+5Q== X-Gm-Message-State: AOAM533a9uNtICoQQPUTxZBVV0sbbYsY5WLPFAsHODbjj3uqVz5dOjQG LOkCClEgX4LpgAGA63/E+cNzp43MsdXByDhqnhU= X-Google-Smtp-Source: ABdhPJzbbp1plHkRlx72CBEHmLZ/sLmZzyfO8c9XT+Dl7j1omOQ9V7duvOC1/hCZmUUj3IhDV3Qgs3T9rEAdRwwOjAc= X-Received: by 2002:a05:6830:1098:: with SMTP id y24mr7897780oto.269.1614640855754; Mon, 01 Mar 2021 15:20:55 -0800 (PST) MIME-Version: 1.0 References: <875z2hshtn.fsf@oldenburg.str.redhat.com> <87y2fdr37u.fsf@oldenburg.str.redhat.com> In-Reply-To: <87y2fdr37u.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Mon, 1 Mar 2021 15:20:19 -0800 Message-ID: Subject: Re: [PATCH 2/2] x86: Add CPU-specific diagnostics to ld.so --list-diagnostics To: Florian Weimer Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3035.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2021 23:20:57 -0000 On Wed, Feb 24, 2021 at 6:58 AM Florian Weimer via Libc-alpha wrote: > > --- > sysdeps/x86/dl-diagnostics.h | 154 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 154 insertions(+) > > diff --git a/sysdeps/x86/dl-diagnostics.h b/sysdeps/x86/dl-diagnostics.h > new file mode 100644 > index 0000000000..92c3b9541e > --- /dev/null > +++ b/sysdeps/x86/dl-diagnostics.h > @@ -0,0 +1,154 @@ > +/* Print diagnostics data in ld.so. x86 version. > + Copyright (C) 2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#ifndef _DL_DIAGNOSTICS_H > +#define _DL_DIAGNOSTICS_H > + > +static void > +print_cpu_features_value (const char *label, uint64_t value) > +{ > + _dl_printf ("x86.cpu_features."); > + _dl_diagnostics_print_labeled_value (label, value); > +} > + > +static void > +print_cpu_feature_internal (unsigned int index, const char *kind, > + unsigned int reg, uint32_t value) > +{ > + _dl_printf ("x86.cpu_features.features[0x%x].%s[0x%x]=0x%x\n", > + index, kind, reg, value); > +} > + > +static void > +print_cpu_feature_preferred (const char *label, unsigned int flag) > +{ > + _dl_printf("x86.cpu_features.preferred.%s=0x%x\n", label, flag); > +} > + > +static inline void > +_dl_diagnostics_sysdeps (void) > +{ > + const struct cpu_features *cpu_features = __get_cpu_features (); > + > + print_cpu_features_value ("basic.kind", cpu_features->basic.kind); > + print_cpu_features_value ("basic.max_cpuid", cpu_features->basic.max_cpuid); > + print_cpu_features_value ("basic.family", cpu_features->basic.family); > + print_cpu_features_value ("basic.model", cpu_features->basic.model); > + print_cpu_features_value ("basic.stepping", cpu_features->basic.stepping); > + > + for (unsigned int index = 0; index < CPUID_INDEX_MAX; ++index) > + { > + /* The index values are part of the ABI via > + , so translating them to strings is not > + necessary. */ > + for (unsigned int reg = 0; reg < 4; ++reg) > + print_cpu_feature_internal > + (index, "cpuid", reg, > + cpu_features->features[index].cpuid_array[reg]); > + for (unsigned int reg = 0; reg < 4; ++reg) > + print_cpu_feature_internal > + (index, "usable", reg, > + cpu_features->features[index].usable_array[reg]); > + } No changes when new CPUID leaves are added. > + /* The preferred indicators are not part of the ABI and need to be > + translated. */ > + print_cpu_feature_preferred > + ("i586", CPU_FEATURE_PREFERRED_P (cpu_features, I586)); > + print_cpu_feature_preferred > + ("i686", CPU_FEATURE_PREFERRED_P (cpu_features, I686)); > + print_cpu_feature_preferred > + ("fast_rep_string", > + CPU_FEATURE_PREFERRED_P (cpu_features, Fast_Rep_String)); > + print_cpu_feature_preferred > + ("fast_copy_backward", > + CPU_FEATURE_PREFERRED_P (cpu_features, Fast_Copy_Backward)); > + print_cpu_feature_preferred > + ("fast_unaligned_load", > + CPU_FEATURE_PREFERRED_P (cpu_features, Fast_Unaligned_Load)); > + print_cpu_feature_preferred > + ("fast_unaligned_copy", > + CPU_FEATURE_PREFERRED_P (cpu_features, Fast_Unaligned_Copy)); > + print_cpu_feature_preferred > + ("slow_bsf", CPU_FEATURE_PREFERRED_P (cpu_features, Slow_BSF)); > + print_cpu_feature_preferred > + ("slow_sse4_2", CPU_FEATURE_PREFERRED_P (cpu_features, Slow_SSE4_2)); > + print_cpu_feature_preferred > + ("avx_fast_unaligned_load", > + CPU_FEATURE_PREFERRED_P (cpu_features, AVX_Fast_Unaligned_Load)); > + print_cpu_feature_preferred > + ("prefer_map_32bit_exec", > + CPU_FEATURE_PREFERRED_P (cpu_features, Prefer_MAP_32BIT_EXEC)); > + print_cpu_feature_preferred > + ("prefer_pminub_for_stringop", > + CPU_FEATURE_PREFERRED_P (cpu_features, Prefer_PMINUB_for_stringop)); > + print_cpu_feature_preferred > + ("prefer_no_vzeroupper", > + CPU_FEATURE_PREFERRED_P (cpu_features, Prefer_No_VZEROUPPER)); > + print_cpu_feature_preferred > + ("prefer_erms", CPU_FEATURE_PREFERRED_P (cpu_features, Prefer_ERMS)); > + print_cpu_feature_preferred > + ("prefer_fsrm", CPU_FEATURE_PREFERRED_P (cpu_features, Prefer_FSRM)); > + print_cpu_feature_preferred > + ("prefer_no_avx512", > + CPU_FEATURE_PREFERRED_P (cpu_features, Prefer_No_AVX512)); > + print_cpu_feature_preferred > + ("mathvec_prefer_no_avx512", > + CPU_FEATURE_PREFERRED_P (cpu_features, MathVec_Prefer_No_AVX512)); These should be auto-define/generated from sysdeps/x86/include/cpu-features.h. > + print_cpu_features_value ("isa_1", cpu_features->isa_1); > + print_cpu_features_value ("xsave_state_size", > + cpu_features->xsave_state_size); > + print_cpu_features_value ("xsave_state_full_size", > + cpu_features->xsave_state_full_size); > + print_cpu_features_value ("data_cache_size", cpu_features->data_cache_size); > + print_cpu_features_value ("shared_cache_size", > + cpu_features->shared_cache_size); > + print_cpu_features_value ("non_temporal_threshold", > + cpu_features->non_temporal_threshold); > + print_cpu_features_value ("rep_movsb_threshold", > + cpu_features->rep_movsb_threshold); > + print_cpu_features_value ("rep_movsb_stop_threshold", > + cpu_features->rep_movsb_stop_threshold); > + print_cpu_features_value ("rep_stosb_threshold", > + cpu_features->rep_stosb_threshold); > + print_cpu_features_value ("level1_icache_size", > + cpu_features->level1_icache_size); > + print_cpu_features_value ("level1_dcache_size", > + cpu_features->level1_dcache_size); > + print_cpu_features_value ("level1_dcache_assoc", > + cpu_features->level1_dcache_assoc); > + print_cpu_features_value ("level1_dcache_linesize", > + cpu_features->level1_dcache_linesize); > + print_cpu_features_value ("level2_cache_size", > + cpu_features->level2_cache_size); > + print_cpu_features_value ("level2_cache_assoc", > + cpu_features->level2_cache_assoc); > + print_cpu_features_value ("level2_cache_linesize", > + cpu_features->level2_cache_linesize); > + print_cpu_features_value ("level3_cache_size", > + cpu_features->level3_cache_size); > + print_cpu_features_value ("level3_cache_assoc", > + cpu_features->level3_cache_assoc); > + print_cpu_features_value ("level3_cache_linesize", > + cpu_features->level3_cache_linesize); > + print_cpu_features_value ("level4_cache_size", > + cpu_features->level4_cache_size); Can they be auto-define/generated from sysdeps/x86/include/cpu-features.h? > +} > + > +#endif /* _DL_DIAGNOSTICS_H */ > -- H.J.