From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by sourceware.org (Postfix) with ESMTPS id 358F23851C27 for ; Thu, 4 Jun 2020 12:05:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 358F23851C27 Received: by mail-io1-xd44.google.com with SMTP id o5so5967861iow.8 for ; Thu, 04 Jun 2020 05:05:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q5z37lHPZW7Z2GtFQ/qJxCqWiIGdGO1IBFD8hG0RG14=; b=HwyCHKEWH18A0Y3GHMfRjv+i+bhQ5s5wRvG49dXRSp0NX/IgXSvSHLdS8b++IuJZ+A w5VQ9WlTZckPdJF6mMg+wL77dWLCmYBSREEgnmaBb6ZlmO9ILWY+euZjVB38wNWxF5/T SsXiiUhX4fzM5HT9k8SUzSuJXZne7QyWb38+Z3MQkZfBy6cBzZPuVyLqpKGhcXRhZJ7I Bx9DBTwWhfXCpzB3XLvSSJYlWwkb3WEiz/H9jeVHGEzjb3wwtwDF3LlY65+KJoSBlSek eexAG2DXU9Ls/Pkx+nASegwRtPpdLjTuHYDnq8K+tpVXCi1o/YU6gOKFPEDnkG1bOM2O BkQA== X-Gm-Message-State: AOAM532DxP3hfnMhKHos2LhmFLFjvGS1QJpNvjGwKutQ4/nUUMNwd2fL RfEhaZ/1cbIYnaYh0kyy7xLn12gSV3vfKptirbY= X-Google-Smtp-Source: ABdhPJyoNkS5Wl7RnX3SQeu5S8/N4YjlZdpYjmk8lhJS45t++bhvx57/eho2xrUHml9KENBGvEhr15rls7dZRzd1fFo= X-Received: by 2002:a5e:c112:: with SMTP id v18mr3743195iol.37.1591272299675; Thu, 04 Jun 2020 05:04:59 -0700 (PDT) MIME-Version: 1.0 References: <0bcd0114-8547-2d2c-8b14-c2bc459a72c0@linaro.org> <87367cw334.fsf@arm.com> In-Reply-To: <87367cw334.fsf@arm.com> From: "H.J. Lu" Date: Thu, 4 Jun 2020 05:04:23 -0700 Message-ID: Subject: Re: [PATCH] aarch64: MTE compatible strchrnul To: Andrea Corallo Cc: Adhemerval Zanella , nd , GNU C Library , Wilco Dijkstra Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2020 12:05:01 -0000 On Wed, Jun 3, 2020 at 9:02 AM Andrea Corallo wrote: > > Adhemerval Zanella writes: > > > On 03/06/2020 06:43, Andrea Corallo wrote: > >> Hi all, > >> > >> I'd like to submit this patch introducing an Arm MTE compatible > >> strchrnul implementation. > >> > >> Follows a performance comparison of the strchrnul benchmark run on > >> Cortex-A72, Cortex-A53, Neoverse N1. > > > > How these performance numbers were calculated? Did you use glibc benchtests > > or an external one? > > Yes the glibc benchtests has been used, forgot to mention sorry. > > > Besides it the commit message does not give an overall description of > > which changes it does to the generic implementation neither the requirements > > of MTE support. > > I'll improve the commit message as suggested. Regarding the MTE > requirements given the function is backward compatible not sure what > should be mentioned. > My impression is if some object files aren't MTE compatible, you can't enable MTE in the executable. Is that correct? -- H.J.