From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id 3808C383942B for ; Fri, 24 Jun 2022 17:06:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3808C383942B Received: by mail-pj1-x102e.google.com with SMTP id w19-20020a17090a8a1300b001ec79064d8dso6379077pjn.2 for ; Fri, 24 Jun 2022 10:06:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Niq8kFIEqBmktn5nRLb3waRVeumAg3LLnHjIE3F8I1A=; b=lFlSHjR+lB+L/QkhKf9NSxvTyzIVimKl2fsm9fNHR3XrHD5gyHn52Y6SEemq29hmRS aEIBdBAs7UyiGJNJdX6IOgYwYHPt2KKAq+BNpgdQqkT02zccdiz2lVbfPPirEMX0YIOH gY2ab7aXMozMc1tb1a44qR2GLCPdgkLR+r1954Ll8xprKThueyFKNSMXg0NsjVXU5Yhe 31Sxbqp3/6bOwSYRqAWtDqT3/eWDfyHjLCn+zlksF8R+C/3jIbNxRYnr4bs2kpp+QHqN 7PV0zVcbZk8dj+Q/vepeb8UtXaYvM0fK4E1eGu5+CVrNBTa4m1+upTl058LH8L51kz1E 3Gtg== X-Gm-Message-State: AJIora9+2ZVlvU1U83X0KGC4wUdpFzJS+nYG6HUPfXtcT+NulQdDOamw uHH5g4mt7lbClmkntOGW9afY/MRXQCMad6zFJaw1v7M5 X-Google-Smtp-Source: AGRyM1shG7PTWCXT7SQJx6WzcLQe1Hn8g78mnf94esGg77SCgXr02CQRC2ecJYTyYX3KsPq8JcHVi3Z4vnzYlEtHymc= X-Received: by 2002:a17:902:b215:b0:168:da4b:c925 with SMTP id t21-20020a170902b21500b00168da4bc925mr29951plr.155.1656090364335; Fri, 24 Jun 2022 10:06:04 -0700 (PDT) MIME-Version: 1.0 References: <20220624164216.2129400-1-goldstein.w.n@gmail.com> <20220624164216.2129400-4-goldstein.w.n@gmail.com> In-Reply-To: <20220624164216.2129400-4-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Fri, 24 Jun 2022 10:05:28 -0700 Message-ID: Subject: Re: [PATCH v2] x86: Put wcs{n}len-sse4.1 in the sse4.1 text section To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3025.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 17:06:07 -0000 On Fri, Jun 24, 2022 at 9:42 AM Noah Goldstein wrote: > > Previously was missing but the two implementations shouldn't get in > the sse2 (generic) text section. > --- > sysdeps/x86_64/multiarch/strlen-vec.S | 6 +++++- > sysdeps/x86_64/multiarch/wcslen-sse4_1.S | 1 + > sysdeps/x86_64/multiarch/wcsnlen-sse4_1.S | 1 + > 3 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/sysdeps/x86_64/multiarch/strlen-vec.S b/sysdeps/x86_64/multiarch/strlen-vec.S > index 42b6124dfd..874123d604 100644 > --- a/sysdeps/x86_64/multiarch/strlen-vec.S > +++ b/sysdeps/x86_64/multiarch/strlen-vec.S > @@ -28,6 +28,10 @@ > # define SHIFT_RETURN > #endif > > +#ifndef SECTION > +# define SECTION(p) p > +#endif > + > /* Long lived register in strlen(s), strnlen(s, n) are: > > %xmm3 - zero > @@ -37,7 +41,7 @@ > */ > > > -.text > + .section SECTION(.text),"ax",@progbits > ENTRY(strlen) > > /* Test 64 bytes from %rax for zero. Save result as bitmask in %rdx. */ > diff --git a/sysdeps/x86_64/multiarch/wcslen-sse4_1.S b/sysdeps/x86_64/multiarch/wcslen-sse4_1.S > index 7e62621afc..e306a77f51 100644 > --- a/sysdeps/x86_64/multiarch/wcslen-sse4_1.S > +++ b/sysdeps/x86_64/multiarch/wcslen-sse4_1.S > @@ -1,4 +1,5 @@ > #define AS_WCSLEN > #define strlen __wcslen_sse4_1 > +#define SECTION(p) p##.sse4.1 > > #include "strlen-vec.S" > diff --git a/sysdeps/x86_64/multiarch/wcsnlen-sse4_1.S b/sysdeps/x86_64/multiarch/wcsnlen-sse4_1.S > index 5fa51fe07c..d2f7dd6e22 100644 > --- a/sysdeps/x86_64/multiarch/wcsnlen-sse4_1.S > +++ b/sysdeps/x86_64/multiarch/wcsnlen-sse4_1.S > @@ -1,5 +1,6 @@ > #define AS_WCSLEN > #define AS_STRNLEN > #define strlen __wcsnlen_sse4_1 > +#define SECTION(p) p##.sse4.1 > > #include "strlen-vec.S" > -- > 2.34.1 > LGTM. Thanks. -- H.J.