* glibc master won't build with GCC 10
@ 2020-04-28 21:57 H.J. Lu
2020-04-28 23:08 ` Andrew Pinski
0 siblings, 1 reply; 4+ messages in thread
From: H.J. Lu @ 2020-04-28 21:57 UTC (permalink / raw)
To: GNU C Library
commit 6d246cb852d3c5ab721dc583112a59ac47dc374e
Author: Florian Weimer <fweimer@redhat.com>
Date: Tue Apr 28 12:10:32 2020 +0200
misc: Remove sstk from the autogenerated system call list
This change should not have an effect because the system call was
never defined. Also add the misssing attribute_compat_text_section
attribute to the sstk function (a minor optimization). Also update the
NEWS file to document the change.
Fixes commit 9cc93ba0973ad04ee26c515a1552afb85e73c6ba
("misc: Turn sstk into a compat symbol").
won't build with GCC 10:
rtld.c: In function ‘dl_main’:
rtld.c:1016:27: error: array subscript ‘cnt’ is outside the bounds of
an interior zero-length array ‘struct auditstate[0]’
[-Werror=zero-length-bounds]
1016 | GL(dl_rtld_map).l_audit[cnt].cookie = (intptr_t) &GL(dl_rtld_map);
In file included from ../include/dlfcn.h:4,
from rtld.c:20:
../include/link.h:335:7: note: while referencing ‘l_audit’
335 | } l_audit[0];
| ^~~~~~~
cc1: all warnings being treated as errors
make[5]: *** [../o-iterator.mk:9:
/export/build/gnu/tools-build/glibc/build-x86_64-linux/elf/rtld.os]
Error 1
--
H.J.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: glibc master won't build with GCC 10
2020-04-28 21:57 glibc master won't build with GCC 10 H.J. Lu
@ 2020-04-28 23:08 ` Andrew Pinski
2020-04-29 10:31 ` Florian Weimer
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Pinski @ 2020-04-28 23:08 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library
This should have been fixed already:
https://sourceware.org/bugzilla/show_bug.cgi?id=25097
Thanks,
Andrew
On Tue, Apr 28, 2020 at 3:54 PM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> commit 6d246cb852d3c5ab721dc583112a59ac47dc374e
> Author: Florian Weimer <fweimer@redhat.com>
> Date: Tue Apr 28 12:10:32 2020 +0200
>
> misc: Remove sstk from the autogenerated system call list
>
> This change should not have an effect because the system call was
> never defined. Also add the misssing attribute_compat_text_section
> attribute to the sstk function (a minor optimization). Also update the
> NEWS file to document the change.
>
> Fixes commit 9cc93ba0973ad04ee26c515a1552afb85e73c6ba
> ("misc: Turn sstk into a compat symbol").
>
> won't build with GCC 10:
>
> rtld.c: In function ‘dl_main’:
> rtld.c:1016:27: error: array subscript ‘cnt’ is outside the bounds of
> an interior zero-length array ‘struct auditstate[0]’
> [-Werror=zero-length-bounds]
> 1016 | GL(dl_rtld_map).l_audit[cnt].cookie = (intptr_t) &GL(dl_rtld_map);
> In file included from ../include/dlfcn.h:4,
> from rtld.c:20:
> ../include/link.h:335:7: note: while referencing ‘l_audit’
> 335 | } l_audit[0];
> | ^~~~~~~
> cc1: all warnings being treated as errors
> make[5]: *** [../o-iterator.mk:9:
> /export/build/gnu/tools-build/glibc/build-x86_64-linux/elf/rtld.os]
> Error 1
>
>
> --
> H.J.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: glibc master won't build with GCC 10
2020-04-28 23:08 ` Andrew Pinski
@ 2020-04-29 10:31 ` Florian Weimer
2020-04-29 12:44 ` H.J. Lu
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2020-04-29 10:31 UTC (permalink / raw)
To: Andrew Pinski via Libc-alpha
* Andrew Pinski via Libc-alpha:
> This should have been fixed already:
> https://sourceware.org/bugzilla/show_bug.cgi?id=25097
>
> Thanks,
> Andrew
>
> On Tue, Apr 28, 2020 at 3:54 PM H.J. Lu via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
>>
>> commit 6d246cb852d3c5ab721dc583112a59ac47dc374e
>> Author: Florian Weimer <fweimer@redhat.com>
>> Date: Tue Apr 28 12:10:32 2020 +0200
>>
>> misc: Remove sstk from the autogenerated system call list
>>
>> This change should not have an effect because the system call was
>> never defined. Also add the misssing attribute_compat_text_section
>> attribute to the sstk function (a minor optimization). Also update the
>> NEWS file to document the change.
>>
>> Fixes commit 9cc93ba0973ad04ee26c515a1552afb85e73c6ba
>> ("misc: Turn sstk into a compat symbol").
>>
>> won't build with GCC 10:
>>
>> rtld.c: In function ‘dl_main’:
>> rtld.c:1016:27: error: array subscript ‘cnt’ is outside the bounds of
>> an interior zero-length array ‘struct auditstate[0]’
>> [-Werror=zero-length-bounds]
>> 1016 | GL(dl_rtld_map).l_audit[cnt].cookie = (intptr_t) &GL(dl_rtld_map);
>> In file included from ../include/dlfcn.h:4,
>> from rtld.c:20:
>> ../include/link.h:335:7: note: while referencing ‘l_audit’
>> 335 | } l_audit[0];
>> | ^~~~~~~
>> cc1: all warnings being treated as errors
>> make[5]: *** [../o-iterator.mk:9:
>> /export/build/gnu/tools-build/glibc/build-x86_64-linux/elf/rtld.os]
>> Error 1
Agreed, this error doesn't look like something from glibc master to
me. master does not contain the string “l_audit[0]” anymore.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: glibc master won't build with GCC 10
2020-04-29 10:31 ` Florian Weimer
@ 2020-04-29 12:44 ` H.J. Lu
0 siblings, 0 replies; 4+ messages in thread
From: H.J. Lu @ 2020-04-29 12:44 UTC (permalink / raw)
To: Florian Weimer; +Cc: Andrew Pinski via Libc-alpha, Andrew Pinski
On Wed, Apr 29, 2020 at 3:31 AM Florian Weimer <fw@deneb.enyo.de> wrote:
>
> * Andrew Pinski via Libc-alpha:
>
> > This should have been fixed already:
> > https://sourceware.org/bugzilla/show_bug.cgi?id=25097
> >
> > Thanks,
> > Andrew
> >
> > On Tue, Apr 28, 2020 at 3:54 PM H.J. Lu via Libc-alpha
> > <libc-alpha@sourceware.org> wrote:
> >>
> >> commit 6d246cb852d3c5ab721dc583112a59ac47dc374e
> >> Author: Florian Weimer <fweimer@redhat.com>
> >> Date: Tue Apr 28 12:10:32 2020 +0200
> >>
> >> misc: Remove sstk from the autogenerated system call list
> >>
> >> This change should not have an effect because the system call was
> >> never defined. Also add the misssing attribute_compat_text_section
> >> attribute to the sstk function (a minor optimization). Also update the
> >> NEWS file to document the change.
> >>
> >> Fixes commit 9cc93ba0973ad04ee26c515a1552afb85e73c6ba
> >> ("misc: Turn sstk into a compat symbol").
> >>
> >> won't build with GCC 10:
> >>
> >> rtld.c: In function ‘dl_main’:
> >> rtld.c:1016:27: error: array subscript ‘cnt’ is outside the bounds of
> >> an interior zero-length array ‘struct auditstate[0]’
> >> [-Werror=zero-length-bounds]
> >> 1016 | GL(dl_rtld_map).l_audit[cnt].cookie = (intptr_t) &GL(dl_rtld_map);
> >> In file included from ../include/dlfcn.h:4,
> >> from rtld.c:20:
> >> ../include/link.h:335:7: note: while referencing ‘l_audit’
> >> 335 | } l_audit[0];
> >> | ^~~~~~~
> >> cc1: all warnings being treated as errors
> >> make[5]: *** [../o-iterator.mk:9:
> >> /export/build/gnu/tools-build/glibc/build-x86_64-linux/elf/rtld.os]
> >> Error 1
>
> Agreed, this error doesn't look like something from glibc master to
> me. master does not contain the string “l_audit[0]” anymore.
Never mind. Pilot error.
--
H.J.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-29 12:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28 21:57 glibc master won't build with GCC 10 H.J. Lu
2020-04-28 23:08 ` Andrew Pinski
2020-04-29 10:31 ` Florian Weimer
2020-04-29 12:44 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).