From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id 2177E3858D3C for ; Thu, 24 Mar 2022 19:37:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2177E3858D3C Received: by mail-pj1-x102b.google.com with SMTP id mj15-20020a17090b368f00b001c637aa358eso10386131pjb.0 for ; Thu, 24 Mar 2022 12:37:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e8PN9P1Zhk3Eoi0i6YghuhHKzDE2QILkgTnfP/9ZEqM=; b=q3nZPyw838Yu0lRHJN3LZZCNDd2vFmCDANSTqMKm9Q1MPSJNfxWhvM02BziHTumK+V ZNlcaqYidvRyMXp2yXQQ3uxpFjwSluOqJ+hYZoSryX4PO2ZXS+2dssZo0pnLXfltjucR QXmdjlmZzeaDJQjno73DTM1GZs54vAfhaLQku2gSTDlKn4yyN1eYbKRY+HmH7PrFGG+e x/KQD4qQCygbSSrxA4zNsZu0l2K9B07+iUu5yDPSiNmNCYtS4qeWtL5HOgCv00mx9IY9 1YO5hu4PczWZ/rck5KHsgjaYgaedXRfpEjVNc9UtgYBuTDLSCa3NcMU1ozP2OnS4G++b 3k4A== X-Gm-Message-State: AOAM533fEYPASG9nMbsqFLeTY66WzCf0p9uf/MaUQxt3cKaTS+LcPYNT VaGz7zM5IJBBcBwmATftJCWzbHx4bWDJ+UgcSmk= X-Google-Smtp-Source: ABdhPJxOgS6l/BzlsNabihdQFEfFaBS/EvfRH5NFuvfjIVMbskEypIZKVDqANf/4RojI4RePM7sYMPw45CHBd8bh8SA= X-Received: by 2002:a17:902:d508:b0:154:2f99:a52e with SMTP id b8-20020a170902d50800b001542f99a52emr7443301plg.102.1648150632216; Thu, 24 Mar 2022 12:37:12 -0700 (PDT) MIME-Version: 1.0 References: <20220323215734.3927131-1-goldstein.w.n@gmail.com> <20220323215734.3927131-3-goldstein.w.n@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Thu, 24 Mar 2022 12:36:36 -0700 Message-ID: Subject: Re: [PATCH v1 03/23] x86: Code cleanup in strchr-avx2 and comment justifying branch To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3020.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2022 19:37:14 -0000 On Thu, Mar 24, 2022 at 12:20 PM Noah Goldstein wrote: > > On Thu, Mar 24, 2022 at 1:53 PM H.J. Lu wrote: > > > > On Wed, Mar 23, 2022 at 2:58 PM Noah Goldstein wrote: > > > > > > Small code cleanup for size: -53 bytes. > > > > > > Add comment justifying using a branch to do NULL/non-null return. > > > > > > Do you have followup patches to improve its performance? We are > > backporting all x86-64 improvements to Intel release branches: > > > > https://gitlab.com/x86-glibc/glibc/-/wikis/home > > > > Patches without performance improvements are undesirable. > > No further changes planned at the moment, code size saves > seem worth it for master though. Also in favor of adding the comment > as I think its non-intuitive. > LGTM. Reviewed-by: H.J. Lu Thanks. -- H.J.