From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by sourceware.org (Postfix) with ESMTPS id 4F156395ACEB for ; Wed, 29 Apr 2020 15:23:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4F156395ACEB Received: by mail-il1-x143.google.com with SMTP id c16so2800503ilr.3 for ; Wed, 29 Apr 2020 08:23:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bR5L9YD4ogsJVHvNP53OUpOWgKemnspGdg6vVudOPjk=; b=N2o+wtyiwGq9bEgTFH0D64TVrTgVyyV0byThCIovsUTNuzidgf4x/gFdkkwJda1bKp LtcH5Q9DQTpypM8kLe5evqtKadWtllwzwWsFdQW0owCAtDbQUhKOQCjTAwzxMRcBtZks TOnUKkQKL6VS5y1UENZR/nfuB4tujDBXp1SZldlnOROfEEQzsqzMyFNNDSxqr9N4+P4q 6VHiUrKKmHJ1CRU6lkJybEVeriKik+Tt8dWSMyjja2F5L67jatX79jN3dgHnJ9Hu3O8V epnSeM8qhn9LKn2sVM+MxQZifiAkYnNM3ZzJCIF/tFmfcaUmMG47f5wFVVoAXd4qhMCj VREg== X-Gm-Message-State: AGi0Pubb3zJ+xsvlHjzKHaQlbehpVB2JWr0ZMHlozJdGVeZ8ART7r7+/ Gb4KU/lRBBmeEHSmaM2/KIpgctW5Y4AEvGN8WViKUB9w X-Google-Smtp-Source: APiQypJZ7MC55fDJgKchLhz/K3eEHyTzTQUU2RUgx68l4hqW89+67WFHlwcqeIc0kTL0xkmVPPs2UZmVpjVQNlZrTQU= X-Received: by 2002:a92:cc4a:: with SMTP id t10mr31643239ilq.292.1588173807801; Wed, 29 Apr 2020 08:23:27 -0700 (PDT) MIME-Version: 1.0 References: <20200429144727.3769136-1-hjl.tools@gmail.com> <20200429144727.3769136-2-hjl.tools@gmail.com> <874kt2s5id.fsf@oldenburg2.str.redhat.com> <87tv12qq0c.fsf@oldenburg2.str.redhat.com> In-Reply-To: <87tv12qq0c.fsf@oldenburg2.str.redhat.com> From: "H.J. Lu" Date: Wed, 29 Apr 2020 08:22:52 -0700 Message-ID: Subject: Re: [PATCH 2/2] Add C wrappers for prctl/process_vm_readv/process_vm_writev [BZ #25810] To: Florian Weimer Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 15:23:29 -0000 On Wed, Apr 29, 2020 at 8:18 AM Florian Weimer wrote: > > * H. J. Lu: > > > On Wed, Apr 29, 2020 at 7:58 AM Florian Weimer wrote: > >> > >> * H. J. Lu: > >> > >> > Since the the U marker can only be applied to 2 unsigned long arguments, > >> > add a C wrapper for prctl, process_vm_readv and process_vm_writev syscals > >> > which have more than 2 unsigned long arguments. > >> > >> I forgot: Please mention syscalls.list somewhere in the commit message, > >> so that it is clear that the U marker refers to that. > >> > >> Thanks, > >> Florian > > > > This is I am going to push: > > > > commit 86f4f2263bf21ff7f80905b3062c16213b016fe6 (HEAD -> master) > > Author: H.J. Lu > > Date: Wed Apr 29 08:08:40 2020 -0700 > > > > Mark unsigned long arguments with U in more syscalls [BZ #25810] > > > > Mark unsigned long arguments in mmap, read, recv, recvfrom, send, sendto, > > write, ioperm, sendfile64, setxattr, lsetxattr, fsetxattr, getxattr, > > lgetxattr, fgetxattr, listxattr, llistxattr and flistxattr with U in > > syscalls.list files. > > This is for the other commit. In that context, U is clear. It is less > clear for the prctl/process_vm_readv/process_vm_writev commit. How about Since the the U marker can only be applied to 2 unsigned long arguments in syscalls.list files, add a C wrapper for prctl, process_vm_readv and process_vm_writev syscals which have more than 2 unsigned long arguments. -- H.J.