From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com
 [IPv6:2607:f8b0:4864:20::342])
 by sourceware.org (Postfix) with ESMTPS id 74360385780B
 for <libc-alpha@sourceware.org>; Tue, 13 Oct 2020 12:53:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 74360385780B
Received: by mail-ot1-x342.google.com with SMTP id f37so18851154otf.12
 for <libc-alpha@sourceware.org>; Tue, 13 Oct 2020 05:53:32 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=hiWGjGauTmntAYyH1Dd4sVzcCiuKCTeuDJclZM4eMVs=;
 b=V7pn7U8t49ovhLDVGJ4NZKCQ63NtE1ErX5M8A35/bhhuq9fpLgzr7ruthyIW1zpP2k
 ePlDrVvx81f7x5ji0pFwRtdfgeeE2IxMKzA2X8w3LYSMxTXdU8SLEL1UP32J5Tm7kx2u
 TJbtHYhh4/2MEknixVufaaejFFEOHtpQooyW6WObs0hi4tuMohSCcszO+msTfL9qDBDX
 5uPvE8pr9pZJkBoXSzESCNWEJlvQiInZ+lfkvppxg3egkAL9UJAVs2Sn5hgMiibjDO4S
 Z3T7IfUfmcH/z5WsrOPZPvaaO4L4Bey3AM5b8wsqwlMGBpwmCMHOPPc8EsFbarLv+8g/
 gC9Q==
X-Gm-Message-State: AOAM531Q7VeCQk5ahhNqlrS/oxo1zsTP9FjxI+6pffk+nqL8tmEiKyur
 bnmT5Nj7A+81A2tK9bqjQmXTOheRtAKfHXcoScnjRCTg
X-Google-Smtp-Source: ABdhPJzF9gAGL1eLysOW75lZ52UOTOFEGvffMPv7Y99XbxAFul2ckHCEk8h9cl3Ks+Q9K/XYEP8N7IC7qkzloVGjHtg=
X-Received: by 2002:a9d:335:: with SMTP id 50mr20539614otv.90.1602593611840;
 Tue, 13 Oct 2020 05:53:31 -0700 (PDT)
MIME-Version: 1.0
References: <20200922121300.3503-1-eb@emlix.com>
 <CAMe9rOq7M6=FMddON+PU75oYgqwWiY6EZCe=jRjZZmuiYNuhTA@mail.gmail.com>
 <26714339.cpny5S42I3@devpool47>
In-Reply-To: <26714339.cpny5S42I3@devpool47>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 13 Oct 2020 05:52:55 -0700
Message-ID: <CAMe9rOqTGrD6b_+EcHByhcUXvdhYt2qH5ZrU0cAkNxVnPBZeAw@mail.gmail.com>
Subject: Re: [PATCH 1/2] rtld: fix typo in comment
To: Rolf Eike Beer <eb@emlix.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3037.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Oct 2020 12:53:33 -0000

On Mon, Oct 12, 2020 at 12:08 AM Rolf Eike Beer <eb@emlix.com> wrote:
>
> Am Dienstag, 22. September 2020, 14:23:40 CEST schrieb H.J. Lu:
> > On Tue, Sep 22, 2020 at 5:13 AM Rolf Eike Beer <eb@emlix.com> wrote:
> > > ---
> > >
> > >  elf/rtld.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/elf/rtld.c b/elf/rtld.c
> > > index 5b882163fa..99d130cd1c 100644
> > > --- a/elf/rtld.c
> > > +++ b/elf/rtld.c
> > > @@ -352,7 +352,7 @@ struct rtld_global _rtld_global =
> > >
> > >    };
> > >
> > >  /* If we would use strong_alias here the compiler would see a
> > >
> > >     non-hidden definition.  This would undo the effect of the previous
> > >
> > > -   declaration.  So spell out was strong_alias does plus add the
> > > +   declaration.  So spell out what strong_alias does plus add the
> > >
> > >     visibility attribute.  */
> > >
> > >  extern struct rtld_global _rtld_local
> > >
> > >      __attribute__ ((alias ("_rtld_global"), visibility ("hidden")));
> > >
> > > --
> > > 2.28.0
> >
> > LGTM.
>
> Is anyone going to pick it up?

I checked it in for you.

Thanks.

-- 
H.J.