From: "H.J. Lu" <hjl.tools@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 3/3] elf/tst-dl_find_object: Disable subtests for non-contiguous maps (bug 28732)
Date: Fri, 14 Jan 2022 07:09:52 -0800 [thread overview]
Message-ID: <CAMe9rOqVP7MorMVS-b49H0REDj3uCUCsuPoB+qum3SYn5eWDJg@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOo-0LOqnTGCRrXm6z6r=9=9F+5EmbWihmxhxVCXhu6Scg@mail.gmail.com>
On Fri, Jan 14, 2022 at 7:06 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Mon, Jan 3, 2022 at 9:13 AM Florian Weimer via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
> >
> > ---
> > elf/tst-dl_find_object.c | 29 +++++++++++++++++------------
> > 1 file changed, 17 insertions(+), 12 deletions(-)
> >
> > diff --git a/elf/tst-dl_find_object.c b/elf/tst-dl_find_object.c
> > index 21cdc0f848..2ad1924088 100644
> > --- a/elf/tst-dl_find_object.c
> > +++ b/elf/tst-dl_find_object.c
> > @@ -71,19 +71,24 @@ check (void *address,
> > __FILE__, line, address,
> > actual.dlfo_flags, expected->dlfo_flags);
> > }
> > - if (actual.dlfo_flags != expected->dlfo_flags)
> > + if (expected->dlfo_link_map->l_contiguous)
> > {
> > - support_record_failure ();
> > - printf ("%s:%d: error: %p: map start is %p, expected %p\n",
> > - __FILE__, line,
> > - address, actual.dlfo_map_start, expected->dlfo_map_start);
> > - }
> > - if (actual.dlfo_map_end != expected->dlfo_map_end)
> > - {
> > - support_record_failure ();
> > - printf ("%s:%d: error: %p: map end is %p, expected %p\n",
> > - __FILE__, line,
> > - address, actual.dlfo_map_end, expected->dlfo_map_end);
> > + /* If the mappings are not contiguous, the actual and execpted
> > + mappings may differ, so this subtest will not work. */
> > + if (actual.dlfo_flags != expected->dlfo_flags)
> > + {
> > + support_record_failure ();
> > + printf ("%s:%d: error: %p: map start is %p, expected %p\n",
> > + __FILE__, line,
> > + address, actual.dlfo_map_start, expected->dlfo_map_start);
> > + }
> > + if (actual.dlfo_map_end != expected->dlfo_map_end)
> > + {
> > + support_record_failure ();
> > + printf ("%s:%d: error: %p: map end is %p, expected %p\n",
> > + __FILE__, line,
> > + address, actual.dlfo_map_end, expected->dlfo_map_end);
> > + }
> > }
> > if (actual.dlfo_link_map != expected->dlfo_link_map)
> > {
> > --
> > 2.33.1
> >
>
> I still see
>
> FAIL: elf/tst-dl_find_object
>
> even when using the new linker with the fix for
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=28743
>
> to remove the 1-page gap. Which file doesn't have
> non-contiguous mapping?
>
The linker bug isn't really fixed:
[21] .eh_frame PROGBITS 0000000000005ef0 005ef0
000758 00 A 0 0 8
[22] .init_array INIT_ARRAY 0000000000007000 007000
000010 08 WA 0 0 8
[23] .fini_array FINI_ARRAY 0000000000007010 007010
000008 08 WA 0 0 8
[24] .data.rel.ro PROGBITS 0000000000007020 007020
0000a0 00 WA 0 0 32
[25] .dynamic DYNAMIC 00000000000070c0 0070c0
000200 10 WA 8 0 8
[26] .got PROGBITS 00000000000072c0 0072c0
000078 08 WA 0 0 8
[27] .got.plt PROGBITS 0000000000008000 008000
0001d0 08 WA 0 0 8
--
H.J.
next prev parent reply other threads:[~2022-01-14 15:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 17:11 [PATCH 0/3] Fix elf/tst-dl_find_objects with --enable-hardcoded-path-in-tests Florian Weimer
2022-01-03 17:11 ` [PATCH 1/3] elf: Introduce rtld_setup_main_map Florian Weimer
2022-01-16 0:11 ` H.J. Lu
2022-01-03 17:11 ` [PATCH 2/3] elf: Set l_contiguous to 1 for the main map in more cases Florian Weimer
2022-01-16 0:10 ` H.J. Lu
2022-01-03 17:11 ` [PATCH 3/3] elf/tst-dl_find_object: Disable subtests for non-contiguous maps (bug 28732) Florian Weimer
2022-01-14 15:06 ` H.J. Lu
2022-01-14 15:09 ` H.J. Lu [this message]
2022-01-14 15:10 ` Florian Weimer
2022-01-14 15:19 ` H.J. Lu
2022-01-14 15:39 ` Florian Weimer
2022-01-14 15:47 ` H.J. Lu
2022-01-14 15:51 ` Florian Weimer
2022-01-14 15:54 ` H.J. Lu
2022-01-14 15:56 ` Florian Weimer
2022-01-14 16:06 ` H.J. Lu
2022-01-14 16:12 ` Florian Weimer
2022-01-16 14:05 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOqVP7MorMVS-b49H0REDj3uCUCsuPoB+qum3SYn5eWDJg@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).