From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id DB0823835C16 for ; Fri, 14 Jan 2022 15:10:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DB0823835C16 Received: by mail-pf1-x435.google.com with SMTP id i65so2986290pfc.9 for ; Fri, 14 Jan 2022 07:10:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JF9hMYGLaQC4vhHsJDLQWD1C1Ww6D9Ole3hbH7Hb1ik=; b=wGPii0nK7l8K1nw05dAvqeaBWmEs3aPKjA7NfAXJT+rLivuZVdhc0A9znFWJtsmqhP Ue9Pj/TPo9okMSnnMHKzLArAOeKzM62Uj9WIJXI6Sw4Hd+6iVYakAuQRTOj/tilyMRyi AST5qWYeEeCjF3YA1IKG+nFGTugdp7FFDFLq9f6uLAGc30z4EkYm2lls7sSO8mxqJ5lU WCKKdi6uBRtmn0It1bsv7Bff618hwKYR0QHlnM1lKduipqBuNb+pYsap1WnRsuNyOaRe C8qzk8daLDwgDc1yN9BBDcVPjqTC8CMiAop8PfZZ9VT4FvNXj6VRX0zMUx5A4nQdr5PQ wuMw== X-Gm-Message-State: AOAM532uDGKYKX5escCprIb39KcXapvKK8EIZ6/0x7PLAzU3XxgvVP78 8xpDVAVGxRVVEqnJ9nCot3Oncm8x5Q/+OhUkGUEVMMSY1Lo= X-Google-Smtp-Source: ABdhPJxhJ9oMG/kU2u2VpQTk5G2WakC6hb0FSZzc7Sg8ClUV0uoBa1ugTAOM1ifxTPHzAFBq2I9faD4S6ySq+gA0Vw8= X-Received: by 2002:a05:6a00:1311:b0:4ba:1288:67dc with SMTP id j17-20020a056a00131100b004ba128867dcmr9278096pfu.43.1642173028981; Fri, 14 Jan 2022 07:10:28 -0800 (PST) MIME-Version: 1.0 References: <636c6da259e612258791a6e816bfc7bbfed97e3a.1641228666.git.fweimer@redhat.com> In-Reply-To: From: "H.J. Lu" Date: Fri, 14 Jan 2022 07:09:52 -0800 Message-ID: Subject: Re: [PATCH 3/3] elf/tst-dl_find_object: Disable subtests for non-contiguous maps (bug 28732) To: Florian Weimer Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3027.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 15:10:32 -0000 On Fri, Jan 14, 2022 at 7:06 AM H.J. Lu wrote: > > On Mon, Jan 3, 2022 at 9:13 AM Florian Weimer via Libc-alpha > wrote: > > > > --- > > elf/tst-dl_find_object.c | 29 +++++++++++++++++------------ > > 1 file changed, 17 insertions(+), 12 deletions(-) > > > > diff --git a/elf/tst-dl_find_object.c b/elf/tst-dl_find_object.c > > index 21cdc0f848..2ad1924088 100644 > > --- a/elf/tst-dl_find_object.c > > +++ b/elf/tst-dl_find_object.c > > @@ -71,19 +71,24 @@ check (void *address, > > __FILE__, line, address, > > actual.dlfo_flags, expected->dlfo_flags); > > } > > - if (actual.dlfo_flags != expected->dlfo_flags) > > + if (expected->dlfo_link_map->l_contiguous) > > { > > - support_record_failure (); > > - printf ("%s:%d: error: %p: map start is %p, expected %p\n", > > - __FILE__, line, > > - address, actual.dlfo_map_start, expected->dlfo_map_start); > > - } > > - if (actual.dlfo_map_end != expected->dlfo_map_end) > > - { > > - support_record_failure (); > > - printf ("%s:%d: error: %p: map end is %p, expected %p\n", > > - __FILE__, line, > > - address, actual.dlfo_map_end, expected->dlfo_map_end); > > + /* If the mappings are not contiguous, the actual and execpted > > + mappings may differ, so this subtest will not work. */ > > + if (actual.dlfo_flags != expected->dlfo_flags) > > + { > > + support_record_failure (); > > + printf ("%s:%d: error: %p: map start is %p, expected %p\n", > > + __FILE__, line, > > + address, actual.dlfo_map_start, expected->dlfo_map_start); > > + } > > + if (actual.dlfo_map_end != expected->dlfo_map_end) > > + { > > + support_record_failure (); > > + printf ("%s:%d: error: %p: map end is %p, expected %p\n", > > + __FILE__, line, > > + address, actual.dlfo_map_end, expected->dlfo_map_end); > > + } > > } > > if (actual.dlfo_link_map != expected->dlfo_link_map) > > { > > -- > > 2.33.1 > > > > I still see > > FAIL: elf/tst-dl_find_object > > even when using the new linker with the fix for > > https://sourceware.org/bugzilla/show_bug.cgi?id=28743 > > to remove the 1-page gap. Which file doesn't have > non-contiguous mapping? > The linker bug isn't really fixed: [21] .eh_frame PROGBITS 0000000000005ef0 005ef0 000758 00 A 0 0 8 [22] .init_array INIT_ARRAY 0000000000007000 007000 000010 08 WA 0 0 8 [23] .fini_array FINI_ARRAY 0000000000007010 007010 000008 08 WA 0 0 8 [24] .data.rel.ro PROGBITS 0000000000007020 007020 0000a0 00 WA 0 0 32 [25] .dynamic DYNAMIC 00000000000070c0 0070c0 000200 10 WA 8 0 8 [26] .got PROGBITS 00000000000072c0 0072c0 000078 08 WA 0 0 8 [27] .got.plt PROGBITS 0000000000008000 008000 0001d0 08 WA 0 0 8 -- H.J.