From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-il1-x142.google.com (mail-il1-x142.google.com
 [IPv6:2607:f8b0:4864:20::142])
 by sourceware.org (Postfix) with ESMTPS id AA44938930C3
 for <libc-alpha@sourceware.org>; Wed, 29 Apr 2020 15:36:58 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AA44938930C3
Received: by mail-il1-x142.google.com with SMTP id q10so2870119ile.0
 for <libc-alpha@sourceware.org>; Wed, 29 Apr 2020 08:36:58 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=lbUOINki+yoJWDWnTcuoHRyj3MAmk5K1HWN8gI06R5k=;
 b=aWdDjt99c5gn1Trla4kdbYaxvEDFTAfpz5EXfxiOmvahuTqSLYK7RD+9hUMTQ/OmL8
 ZRcnowiL9INeaM7p3XodOhHBmaiOjBHbKJfwQVwY+eGvUf9NW8YzH8uLi5mkhQ077K/O
 7eM98EiOjxCX6rwdTYGU7ySX+yo4FqFOCVNyfiJ84Aw91yoVYPAEayhpAC59nDtKp+wp
 Cx1U7xssWaIXbs3i4VX7zsTcdQkEvRbbrerZ8nfVIK9VIjhh40s7yuY1bo6jhpo68ovG
 ssmDcRjJsBw3u+EZkMiOtmITG5kLqDovZdRbYCE0HGjfiBbP6RBNcONGWU54SQKzbWNl
 Op7g==
X-Gm-Message-State: AGi0PubWIeMYWs98ytmQ6lzB2MNhG+RYQj92ZYX22C380kjRfxvIBmny
 Y0EA6kIBlDU/Thfb3Tc6RuCImOTSBB/NEiLOhXg=
X-Google-Smtp-Source: APiQypIBum8xb6GUD3kMjHqvSKnMk7Tn5ABXeurojP1BP+AI5B5wcyKHmIjTT73vxuWodCdxYBU/AKd8UBc+8Q1KXn0=
X-Received: by 2002:a92:c150:: with SMTP id b16mr33044374ilh.13.1588174618131; 
 Wed, 29 Apr 2020 08:36:58 -0700 (PDT)
MIME-Version: 1.0
References: <20200429144727.3769136-1-hjl.tools@gmail.com>
 <20200429144727.3769136-2-hjl.tools@gmail.com>
 <87d07qs5n4.fsf@oldenburg2.str.redhat.com>
 <20200429152017.GA3811691@gmail.com> <87zhau2tpa.fsf@igel.home>
In-Reply-To: <87zhau2tpa.fsf@igel.home>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 29 Apr 2020 08:36:22 -0700
Message-ID: <CAMe9rOqXTxg6DW7MQ5zEttS5u_JkFshEzTwr7Ltt9t_WxRek+A@mail.gmail.com>
Subject: Re: V2 [PATCH 2/2] Add C wrappers for
 prctl/process_vm_readv/process_vm_writev [BZ #25810]
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>,
 Florian Weimer <fweimer@redhat.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Apr 2020 15:37:09 -0000

On Wed, Apr 29, 2020 at 8:32 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Apr 29 2020, H.J. Lu via Libc-alpha wrote:
>
> >> > +int
> >> > +__prctl (int option, unsigned long arg2, unsigned long arg3,
> >> > +   unsigned long arg4, unsigned long arg5)
> >>
> >> unsigned long int everywhere.
> >
> > Fixed.
> >
> >>
> >> > +{
> >> > +  return INLINE_SYSCALL_CALL (prctl, option, arg2, arg3, arg4, arg5);
> >> > +}
> >> > +
> >> > +hidden_def (__prctl)
> >> > +weak_alias (__prctl, prctl)
> >> > +hidden_weak (prctl)
> >>
> >> Can't you use libc_hidden_proto in include/sys/prctl.h and
> >> libc_hidden_proto here?
> >>
> >
> > Since include/sys/prctl.h has
> >
> > extern int __prctl (int __option, ...);
> >
> > it can't be used.
>
> You cannot implement a function declared as varargs with a non-varargs
> definition.

True.  There is a separate bug:

https://sourceware.org/bugzilla/show_bug.cgi?id=25896

-- 
H.J.