From: "H.J. Lu" <hjl.tools@gmail.com>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
"Carlos O'Donell" <carlos@systemhalted.org>
Subject: Re: [PATCH v1 1/4] x86: Rename STRCASECMP_NONASCII macro to STRCASECMP_L_NONASCII
Date: Tue, 12 Jul 2022 16:30:18 -0700 [thread overview]
Message-ID: <CAMe9rOqZMROTjOCQWcGaVD70gSHmoyku+rdu10W8S_Z86fwBnA@mail.gmail.com> (raw)
In-Reply-To: <20220712192808.335531-1-goldstein.w.n@gmail.com>
On Tue, Jul 12, 2022 at 12:28 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> The previous macro name can be confusing given that both
> `__strcasecmp_l_nonascii` and `__strcasecmp_nonascii` are
> functions and we use the `_l` version.
> ---
> sysdeps/x86_64/multiarch/strcmp-avx2.S | 6 +++---
> sysdeps/x86_64/multiarch/strcmp-evex.S | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> index 516cde1145..3ab21e3a58 100644
> --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
> +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> @@ -89,12 +89,12 @@
> # define STRCASECMP __strncasecmp_avx2
> # define LOCALE_REG rcx
> # define LOCALE_REG_LP RCX_LP
> -# define STRCASECMP_NONASCII __strncasecmp_l_nonascii
> +# define STRCASECMP_L_NONASCII __strncasecmp_l_nonascii
> # else
> # define STRCASECMP __strcasecmp_avx2
> # define LOCALE_REG rdx
> # define LOCALE_REG_LP RDX_LP
> -# define STRCASECMP_NONASCII __strcasecmp_l_nonascii
> +# define STRCASECMP_L_NONASCII __strcasecmp_l_nonascii
> # endif
> # endif
>
> @@ -215,7 +215,7 @@ STRCMP:
> mov (%LOCALE_REG), %RAX_LP
> # endif
> testl $1, LOCALE_DATA_VALUES + _NL_CTYPE_NONASCII_CASE * SIZEOF_VALUES(%rax)
> - jne STRCASECMP_NONASCII
> + jne STRCASECMP_L_NONASCII
> leaq _nl_C_LC_CTYPE_tolower + 128 * 4(%rip), TOLOWER_BASE
> # endif
>
> diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> index e97d51bb26..afbf13a230 100644
> --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> @@ -123,12 +123,12 @@
> # define STRCASECMP __strncasecmp_evex
> # define LOCALE_REG rcx
> # define LOCALE_REG_LP RCX_LP
> -# define STRCASECMP_NONASCII __strncasecmp_l_nonascii
> +# define STRCASECMP_L_NONASCII __strncasecmp_l_nonascii
> # else
> # define STRCASECMP __strcasecmp_evex
> # define LOCALE_REG rdx
> # define LOCALE_REG_LP RDX_LP
> -# define STRCASECMP_NONASCII __strcasecmp_l_nonascii
> +# define STRCASECMP_L_NONASCII __strcasecmp_l_nonascii
> # endif
> # endif
>
> @@ -241,7 +241,7 @@ STRCMP:
> mov (%LOCALE_REG), %RAX_LP
> # endif
> testl $1, LOCALE_DATA_VALUES + _NL_CTYPE_NONASCII_CASE * SIZEOF_VALUES(%rax)
> - jne STRCASECMP_NONASCII
> + jne STRCASECMP_L_NONASCII
> leaq _nl_C_LC_CTYPE_tolower + 128 * 4(%rip), TOLOWER_BASE
> # endif
>
> --
> 2.34.1
>
LGTM.
Thanks.
--
H.J.
prev parent reply other threads:[~2022-07-12 23:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 19:28 Noah Goldstein
2022-07-12 19:28 ` [PATCH v1 2/4] x86: Move strcmp SSE2 implementation to multiarch/strcmp-sse2.S Noah Goldstein
2022-07-12 23:57 ` H.J. Lu
2022-07-12 19:28 ` [PATCH v1 3/4] x86: Move wcscmp SSE2 implementation to multiarch/wcscmp-sse2.S Noah Goldstein
2022-07-13 0:05 ` H.J. Lu
2022-07-12 19:28 ` [PATCH v1 4/4] x86: Move strcmp SSE42 implementation to multiarch/strcmp-sse4_2.S Noah Goldstein
2022-07-13 0:07 ` H.J. Lu
2022-07-12 23:30 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOqZMROTjOCQWcGaVD70gSHmoyku+rdu10W8S_Z86fwBnA@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=carlos@systemhalted.org \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).