From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id 03C973857344 for ; Tue, 12 Jul 2022 23:30:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 03C973857344 Received: by mail-pj1-x1029.google.com with SMTP id o31-20020a17090a0a2200b001ef7bd037bbso857422pjo.0 for ; Tue, 12 Jul 2022 16:30:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Yg8rrZG57f3hXuV8RjO/MCknfqWqnBeZevW1lsXf+hk=; b=nQuzNwyjr3wE10sYDwGj+kXw7c0vmd/P13OuzQq1xtPByKG6s5PVYPrf/A1rgEHaUy fkdet77Yci646z2/pU11FPVw06KHmThwI3NUKaFnaxSiKFHLGOxMlwgGBWPg4XxhWGtY hQZuUzrnEBZi4KNTJLFEPRSTS2CXLtrvqKLMhbGW4va7cOyh8kZ8JxDZEUFFk1HhwF2Z TdmoDb8M6utl31FW16K/E+pLlgNwz+nhW36Px3SqwME6s0WP5wJXDkr/X75rXEme+o06 DZhTiTAKijMjbdph28Sq6cAcJKeS8nRd7ai4PvQa69Xk6F6gPWNtoMRcrDGM11NB0RCW RxyA== X-Gm-Message-State: AJIora9VGDfnHpqs9UtzFaSqUBgT3sm6tua1R8wmwI39gB65nTvNyU4Y SpztYrv2HexH4PCaQ6GixzyQ7Z99InZHpPZHyZyvQ8fb X-Google-Smtp-Source: AGRyM1uV2LTL5M7esghLMRfonOqzpvvtkHkL3zWTEOqz5eXxaB88JlZ3nQTc8IjB+chN+xCGBBNFCmHlRQSJmp/gXDw= X-Received: by 2002:a17:902:d50e:b0:16c:1664:81e5 with SMTP id b14-20020a170902d50e00b0016c166481e5mr333990plg.149.1657668654056; Tue, 12 Jul 2022 16:30:54 -0700 (PDT) MIME-Version: 1.0 References: <20220712192808.335531-1-goldstein.w.n@gmail.com> In-Reply-To: <20220712192808.335531-1-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Tue, 12 Jul 2022 16:30:18 -0700 Message-ID: Subject: Re: [PATCH v1 1/4] x86: Rename STRCASECMP_NONASCII macro to STRCASECMP_L_NONASCII To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3024.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 23:30:56 -0000 On Tue, Jul 12, 2022 at 12:28 PM Noah Goldstein wrote: > > The previous macro name can be confusing given that both > `__strcasecmp_l_nonascii` and `__strcasecmp_nonascii` are > functions and we use the `_l` version. > --- > sysdeps/x86_64/multiarch/strcmp-avx2.S | 6 +++--- > sysdeps/x86_64/multiarch/strcmp-evex.S | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S > index 516cde1145..3ab21e3a58 100644 > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S > @@ -89,12 +89,12 @@ > # define STRCASECMP __strncasecmp_avx2 > # define LOCALE_REG rcx > # define LOCALE_REG_LP RCX_LP > -# define STRCASECMP_NONASCII __strncasecmp_l_nonascii > +# define STRCASECMP_L_NONASCII __strncasecmp_l_nonascii > # else > # define STRCASECMP __strcasecmp_avx2 > # define LOCALE_REG rdx > # define LOCALE_REG_LP RDX_LP > -# define STRCASECMP_NONASCII __strcasecmp_l_nonascii > +# define STRCASECMP_L_NONASCII __strcasecmp_l_nonascii > # endif > # endif > > @@ -215,7 +215,7 @@ STRCMP: > mov (%LOCALE_REG), %RAX_LP > # endif > testl $1, LOCALE_DATA_VALUES + _NL_CTYPE_NONASCII_CASE * SIZEOF_VALUES(%rax) > - jne STRCASECMP_NONASCII > + jne STRCASECMP_L_NONASCII > leaq _nl_C_LC_CTYPE_tolower + 128 * 4(%rip), TOLOWER_BASE > # endif > > diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S > index e97d51bb26..afbf13a230 100644 > --- a/sysdeps/x86_64/multiarch/strcmp-evex.S > +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S > @@ -123,12 +123,12 @@ > # define STRCASECMP __strncasecmp_evex > # define LOCALE_REG rcx > # define LOCALE_REG_LP RCX_LP > -# define STRCASECMP_NONASCII __strncasecmp_l_nonascii > +# define STRCASECMP_L_NONASCII __strncasecmp_l_nonascii > # else > # define STRCASECMP __strcasecmp_evex > # define LOCALE_REG rdx > # define LOCALE_REG_LP RDX_LP > -# define STRCASECMP_NONASCII __strcasecmp_l_nonascii > +# define STRCASECMP_L_NONASCII __strcasecmp_l_nonascii > # endif > # endif > > @@ -241,7 +241,7 @@ STRCMP: > mov (%LOCALE_REG), %RAX_LP > # endif > testl $1, LOCALE_DATA_VALUES + _NL_CTYPE_NONASCII_CASE * SIZEOF_VALUES(%rax) > - jne STRCASECMP_NONASCII > + jne STRCASECMP_L_NONASCII > leaq _nl_C_LC_CTYPE_tolower + 128 * 4(%rip), TOLOWER_BASE > # endif > > -- > 2.34.1 > LGTM. Thanks. -- H.J.