From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 303573836015 for ; Fri, 14 Jan 2022 18:39:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 303573836015 Received: by mail-pg1-x52f.google.com with SMTP id r135so292282pgr.6 for ; Fri, 14 Jan 2022 10:39:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=poXo+RBzsAkB3QuLGbg3LQreo+mOiqjSLhhPw0xJzF4=; b=FK65q4Y1vcRIIe22UFPQsprs/1H4fei14u/MrCUEEwqYmjJzmlLHSjQq+At7ou+zTx oJefJCjhdEYKgjxrAtjeKnnYeHenZj5qxCd/YHS4z4jBlbCvwXakAEl6LWr/jBv7MvuM NeGq1HB8vE976G+HFFTt8m/QvdU/XSgUX5gEsK+0JKsNyfOySfVqPVpJga4uqJ1hFfPs LiyKzP5+tZtuszfxpyvtpYigHrBGetJ0JLcroh6GWpqfu0Q4qYqs8ljuC6m7ChPAiDk0 6XONAU0nPLakqfa9mbiPRE54hYedXS/+gdRizocQDlA+nGjIR/9EZIfpbdclg3Z7KWEl XNaw== X-Gm-Message-State: AOAM531pgRp7KDhlJgVBe0nzZ9rd4NwJSCzkZ78LUG+pT7hqAHbBrVcP DyshSgHyn9v13/n3jlF01FQf12s2HuBJLvLy0gc= X-Google-Smtp-Source: ABdhPJwdDXGpLNaiOqXbju/EtVfBI1Qelp5VYzbeIXsqFLEPtM9hNU0X9BSBJpcSwp718uqQgWkgc4LPlkDs05NW7cE= X-Received: by 2002:a05:6a00:1311:b0:4ba:1288:67dc with SMTP id j17-20020a056a00131100b004ba128867dcmr10072072pfu.43.1642185565179; Fri, 14 Jan 2022 10:39:25 -0800 (PST) MIME-Version: 1.0 References: <715520a1d4e694057ead5b76e58eac4af5ee76f5.1642179009.git.fweimer@redhat.com> In-Reply-To: <715520a1d4e694057ead5b76e58eac4af5ee76f5.1642179009.git.fweimer@redhat.com> From: "H.J. Lu" Date: Fri, 14 Jan 2022 10:38:49 -0800 Message-ID: Subject: Re: [PATCH v2 3/6] Add --with-rtld-early-cflags configure option To: Florian Weimer Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3028.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 18:39:30 -0000 On Fri, Jan 14, 2022 at 8:54 AM Florian Weimer via Libc-alpha wrote: > > --- > v2: Rename configure option. Regenerate INSTALL. > INSTALL | 8 ++++++++ > config.make.in | 1 + > configure | 13 +++++++++++++ > configure.ac | 6 ++++++ > elf/Makefile | 8 ++++++++ > manual/install.texi | 7 +++++++ > 6 files changed, 43 insertions(+) > > diff --git a/INSTALL b/INSTALL > index 331d405e56..a9dc12fa31 100644 > --- a/INSTALL > +++ b/INSTALL > @@ -106,6 +106,14 @@ if 'CFLAGS' is specified it must enable optimization. For example: > particular case and potentially change debugging information and > metadata only). > > +'--with-rtld-early-cflags=CFLAGS' > + Use additional compiler flags CFLAGS to build the early startup > + code of the dynamic linker. These flags can be used to enable > + early dynamic linker diagnostics to run on CPUs which are not > + compatible with the rest of the GNU C Library, for example, due to > + compiler flags which target a later instruction set architecture > + (ISA). > + > '--with-timeoutfactor=NUM' > Specify an integer NUM to scale the timeout of test programs. This > factor can be changed at run time using 'TIMEOUTFACTOR' environment > diff --git a/config.make.in b/config.make.in > index e8630a8d0c..6d43e691f7 100644 > --- a/config.make.in > +++ b/config.make.in > @@ -110,6 +110,7 @@ CFLAGS = @CFLAGS@ > CPPFLAGS-config = @CPPFLAGS@ > CPPUNDEFS = @CPPUNDEFS@ > extra-nonshared-cflags = @extra_nonshared_cflags@ > +rtld-early-cflags = @rtld_early_cflags@ > ASFLAGS-config = @ASFLAGS_config@ > AR = @AR@ > NM = @NM@ > diff --git a/configure b/configure > index 3f956cf777..6a7e5c6164 100755 > --- a/configure > +++ b/configure > @@ -681,6 +681,7 @@ force_install > bindnow > hardcoded_path_in_tests > enable_timezone_tools > +rtld_early_cflags > extra_nonshared_cflags > use_default_link > sysheaders > @@ -761,6 +762,7 @@ with_selinux > with_headers > with_default_link > with_nonshared_cflags > +with_rtld_early_cflags > with_timeoutfactor > enable_sanity_checks > enable_shared > @@ -1480,6 +1482,8 @@ Optional Packages: > --with-default-link do not use explicit linker scripts > --with-nonshared-cflags=CFLAGS > build nonshared libraries with additional CFLAGS > + --with-rtld-early-cflags=CFLAGS > + build early initialization with additional CFLAGS > --with-timeoutfactor=NUM > specify an integer to scale the timeout > --with-cpu=CPU select code for CPU variant > @@ -3386,6 +3390,15 @@ fi > > > > +# Check whether --with-rtld-early-cflags was given. > +if test "${with_rtld_early_cflags+set}" = set; then : > + withval=$with_rtld_early_cflags; rtld_early_cflags=$withval > +else > + rtld_early_cflags= > +fi > + > + > + > > # Check whether --with-timeoutfactor was given. > if test "${with_timeoutfactor+set}" = set; then : > diff --git a/configure.ac b/configure.ac > index 277d3527d2..40f2de1661 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -162,6 +162,12 @@ AC_ARG_WITH([nonshared-cflags], > [extra_nonshared_cflags=$withval], > [extra_nonshared_cflags=]) > AC_SUBST(extra_nonshared_cflags) > +AC_ARG_WITH([rtld-early-cflags], > + AS_HELP_STRING([--with-rtld-early-cflags=CFLAGS], > + [build early initialization with additional CFLAGS]), > + [rtld_early_cflags=$withval], > + [rtld_early_cflags=]) > +AC_SUBST(rtld_early_cflags) > > AC_ARG_WITH([timeoutfactor], > AS_HELP_STRING([--with-timeoutfactor=NUM], > diff --git a/elf/Makefile b/elf/Makefile > index 3df49742ff..e6a28b243b 100644 > --- a/elf/Makefile > +++ b/elf/Makefile > @@ -167,6 +167,14 @@ CFLAGS-.o += $(call elide-stack-protector,.o,$(elide-routines.os)) > CFLAGS-.op += $(call elide-stack-protector,.op,$(elide-routines.os)) > CFLAGS-.os += $(call elide-stack-protector,.os,$(all-rtld-routines)) > > +# Add the requested compiler flags to the early startup code. > +CFLAGS-dl-printf.os += $(rtld-early-cflags) > +CFLAGS-dl-sysdep.os += $(rtld-early-cflags) > +CFLAGS-dl-tunables.os += $(rtld-early-cflags) > +CFLAGS-dl-write.os += $(rtld-early-cflags) > +CFLAGS-dl-writev.os += $(rtld-early-cflags) > +CFLAGS-rtld.os += $(rtld-early-cflags) > + > ifeq ($(unwind-find-fde),yes) > routines += unwind-dw2-fde-glibc > shared-only-routines += unwind-dw2-fde-glibc > diff --git a/manual/install.texi b/manual/install.texi > index b1afc56f5a..accaef45fa 100644 > --- a/manual/install.texi > +++ b/manual/install.texi > @@ -131,6 +131,13 @@ that the objects in @file{libc_nonshared.a} are compiled with this flag > (although this will not affect the generated code in this particular > case and potentially change debugging information and metadata only). > > +@item --with-rtld-early-cflags=@var{cflags} > +Use additional compiler flags @var{cflags} to build the early startup > +code of the dynamic linker. These flags can be used to enable early > +dynamic linker diagnostics to run on CPUs which are not compatible with > +the rest of @theglibc{}, for example, due to compiler flags which target > +a later instruction set architecture (ISA). > + > @item --with-timeoutfactor=@var{NUM} > Specify an integer @var{NUM} to scale the timeout of test programs. > This factor can be changed at run time using @env{TIMEOUTFACTOR} > -- > 2.34.1 > > LGTM. Reviewed-by: H.J. Lu Thanks. -- H.J.