From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id 51306385840C for ; Fri, 8 Oct 2021 14:27:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 51306385840C Received: by mail-pg1-x529.google.com with SMTP id 133so3282559pgb.1 for ; Fri, 08 Oct 2021 07:27:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eJg6HMV69lyYDodu+TZm4PdEuYT55aSuDmYZXZUUX28=; b=oczcsuKWFGXlAlCm6aXqOv9E7Llbn1eb+uRc7QzDsxmCkzhSYedko4D8lh2jjP+zRh 5nYjOkh6qJiZv2elvRCaFqToqYFeRbnAAUQYUliemkAcGTfgQOvmXNFN9Q9Lvd4eO8WY ShbpFHVvUF8OPaLIu0yJyNgdwSPZTtdvbyo69S8u4vEVj2RejYTlfv1sYYxWYNTrr8hm X+Dt1SkGCS3S30d919arLwLwAL+T0Ocj4kVc71vOByMjuuT+DkhgvY6/aUF1HG6taY7t YX7AxME88rux9CEvvg0s9rv6Ta74imU472SN8DYlfApQ2E7hZhhcqjZ5QjcpdpX9wf0C OpoQ== X-Gm-Message-State: AOAM531oapO7DJE0XMc3942+FJybTW9LXk14l/T/Vl1Tvagq+zb5ggMr woaKJ4qyRyH45EJz4f2PHQp6xu6AeGc2sANfLJA= X-Google-Smtp-Source: ABdhPJw9nEHroVHk24x9G2Okr9w9JApRkAu0rOJ8WBLiJl3O0KbMn8qO8bFRtyJAOfyFZT2xDf3rzqPLFNkLVtHM62E= X-Received: by 2002:a62:7752:0:b0:44c:eb65:8561 with SMTP id s79-20020a627752000000b0044ceb658561mr315542pfc.43.1633703257208; Fri, 08 Oct 2021 07:27:37 -0700 (PDT) MIME-Version: 1.0 References: <20210926205306.900081-1-goldstein.w.n@gmail.com> <20210926205306.900081-2-goldstein.w.n@gmail.com> In-Reply-To: <20210926205306.900081-2-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Fri, 8 Oct 2021 07:27:01 -0700 Message-ID: Subject: Re: [PATCH v1 2/3] x86: Modify ENTRY in sysdep.h so that p2align can be specified To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3029.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Oct 2021 14:27:40 -0000 On Sun, Sep 26, 2021 at 1:53 PM Noah Goldstein wrote: > > No bug. > > This change adds a new macro ENTRY_P2ALIGN which takes a second > argument, log2 of the desired function alignment. > > The old ENTRY(name) macro is just ENTRY_P2ALIGN(name, 4) so this > doesn't affect any existing functionality. > > Signed-off-by: Noah Goldstein > --- > Note this is a duplicate of: > [v2,1/2] x86: Modify ENTRY in sysdep.h so that p2align can be specified > https://patchwork.sourceware.org/project/glibc/patch/20210922051657.1655745-1-goldstein.w.n@gmail.com/ > > sysdeps/x86/sysdep.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/sysdeps/x86/sysdep.h b/sysdeps/x86/sysdep.h > index cac1d762fb..937180c1bd 100644 > --- a/sysdeps/x86/sysdep.h > +++ b/sysdeps/x86/sysdep.h > @@ -78,15 +78,18 @@ enum cf_protection_level > #define ASM_SIZE_DIRECTIVE(name) .size name,.-name; > > /* Define an entry point visible from C. */ > -#define ENTRY(name) \ > +#define ENTRY_P2ALIGN(name, alignment) \ > .globl C_SYMBOL_NAME(name); \ > .type C_SYMBOL_NAME(name),@function; \ > - .align ALIGNARG(4); \ > + .align ALIGNARG(alignment); \ > C_LABEL(name) \ > cfi_startproc; \ > _CET_ENDBR; \ > CALL_MCOUNT > > +/* Common entry 16 byte aligns. */ > +#define ENTRY(name) ENTRY_P2ALIGN (name, 4) > + > #undef END > #define END(name) \ > cfi_endproc; \ > -- > 2.25.1 > LGTM. Reviewed-by: H.J. Lu Thanks. -- H.J.