From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id 8B25D386F42F for ; Sat, 20 Mar 2021 00:07:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8B25D386F42F Received: by mail-ot1-x32f.google.com with SMTP id m21-20020a9d7ad50000b02901b83efc84a0so10149420otn.10 for ; Fri, 19 Mar 2021 17:07:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3MXGB7lhy1+f9WnQk4Br8xdHCEUsUNVPGKjJSSRJv4k=; b=WKGgmkcsoOhdkk3oovhBEdQVWWRw14LAuXuUpAXClYyBLQMOVvUEN9w+RrhrUAhIPN 6BlKsLR6EjNftVr/6pZCeej1wlpnQMftsgegKTcIs/xxUyZQ4GTzLPmb6qPH+u6XaJhD rmrLg7UVmKkO6nJ8DlNa9W0mCmTb3HIX2D3HXlUpA0HraFHONP9pvFvR2/bqb3ufXBvB Nn/yUWeZAYC0ZnehbtH3s8wsPkMVhmykyk7kwy1+SfYohtzdi+9pS2bEOjbMUd8wZUhE 5AnwkCb//tVaWZRAc6eY/lp8rPiCLMxvuU10lA+e/XspI76S/2W/h4BZGIXDke8KtgTx v8bA== X-Gm-Message-State: AOAM5312hVvx7JRG0LoJcBXnus2MoVgYm8+HbLwd7yYQow9+yrNGnmCj EFJxXwRzdRGWRsCC2McUHQkp2yNDHbuxMa6Ru3A= X-Google-Smtp-Source: ABdhPJxn/aVL+oeltHEGyrDt1BN/kMlKrhfDSm6eqtSU4aRg6Z/YnJi9eEx1oQ4AegTxrOGnmvJNcSuoBc20RSRoR4E= X-Received: by 2002:a05:6830:1515:: with SMTP id k21mr2985045otp.269.1616198826927; Fri, 19 Mar 2021 17:07:06 -0700 (PDT) MIME-Version: 1.0 References: <20210319132751.3845006-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Fri, 19 Mar 2021 17:06:30 -0700 Message-ID: Subject: [PATCH v3] x86: Properly disable XSAVE related features [BZ #27605] To: DJ Delorie Cc: GNU C Library Content-Type: multipart/mixed; boundary="000000000000f7725505bdec9c12" X-Spam-Status: No, score=-3036.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Mar 2021 00:07:09 -0000 --000000000000f7725505bdec9c12 Content-Type: text/plain; charset="UTF-8" On Fri, Mar 19, 2021 at 3:22 PM H.J. Lu wrote: > > On Fri, Mar 19, 2021 at 2:42 PM DJ Delorie wrote: > > > > "H.J. Lu" writes: > > > If OSXSAVE is disabled by glibc tunables, disable features which depend > > > on OSXSAVE. > > > > This one seems to ignore -XSAVE, both on an 11th gen (-XSAVE,-XSAVEC -> > > xsave()) and on 4th (just -XSAVE). Is this patch supposed to be used > > with the previous patch, or standalone? > > > > Fixed. Here is the v2 patch. OK for master? > Here is the v3 patch to disable all XSAVE related features if both XSAVE and XSAVEC aren't usable. -- H.J. --000000000000f7725505bdec9c12 Content-Type: text/x-patch; charset="US-ASCII"; name="v3-0001-x86-Properly-disable-XSAVE-related-features-BZ-27.patch" Content-Disposition: attachment; filename="v3-0001-x86-Properly-disable-XSAVE-related-features-BZ-27.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kmgz0ozk0 RnJvbSA3ZWQzMGM3NmE3ZTIwZjc3ZWIxYjY1ZjliMzhjOTA1ODE5YWQxODgwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IEZyaSwgMTkgTWFyIDIwMjEgMDY6MTU6MzcgLTA3MDAKU3ViamVjdDogW1BBVENIIHYzXSB4ODY6 IFByb3Blcmx5IGRpc2FibGUgWFNBVkUgcmVsYXRlZCBmZWF0dXJlcyBbQlogIzI3NjA1XQoKMS4g U3VwcG9ydCBHTElCQ19UVU5BQkxFUz1nbGliYy5jcHUuaHdjYXBzPS1YU0FWRS4KMi4gRGlzYWJs ZSBhbGwgZmVhdHVyZXMgd2hpY2ggZGVwZW5kIG9uIFhTQVZFOgogICBhLiBJZiBPU1hTQVZFIGlz IGRpc2FibGVkIGJ5IGdsaWJjIHR1bmFibGVzLiAgT3IKICAgYi4gSWYgYm90aCBYU0FWRSBhbmQg WFNBVkVDIGFyZW4ndCB1c2FibGUuCi0tLQogc3lzZGVwcy94ODYvY3B1LWZlYXR1cmVzLmMgfCA1 NSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogc3lzZGVwcy94ODYvY3B1 LXR1bmFibGVzLmMgfCAgMSArCiAyIGZpbGVzIGNoYW5nZWQsIDU2IGluc2VydGlvbnMoKykKCmRp ZmYgLS1naXQgYS9zeXNkZXBzL3g4Ni9jcHUtZmVhdHVyZXMuYyBiL3N5c2RlcHMveDg2L2NwdS1m ZWF0dXJlcy5jCmluZGV4IGQ3MjQ4Y2JiNDUuLmU5OWU2N2YzNGQgMTAwNjQ0Ci0tLSBhL3N5c2Rl cHMveDg2L2NwdS1mZWF0dXJlcy5jCisrKyBiL3N5c2RlcHMveDg2L2NwdS1mZWF0dXJlcy5jCkBA IC02NTQsNiArNjU0LDYxIEBAIG5vX2NwdWlkOgogCiAjaWYgSEFWRV9UVU5BQkxFUwogICBUVU5B QkxFX0dFVCAoaHdjYXBzLCB0dW5hYmxlX3ZhbF90ICosIFRVTkFCTEVfQ0FMTEJBQ0sgKHNldF9o d2NhcHMpKTsKKworICBib29sIGRpc2FibGVfeHNhdmVfZmVhdHVyZXMgPSBmYWxzZTsKKworICBp ZiAoIUNQVV9GRUFUVVJFX1VTQUJMRV9QIChjcHVfZmVhdHVyZXMsIE9TWFNBVkUpKQorICAgIHsK KyAgICAgIC8qIFRoZXNlIGZlYXR1cmVzIGFyZSB1c2FibGUgb25seSBpZiBPU1hTQVZFIGlzIHVz YWJsZS4gICovCisgICAgICBDUFVfRkVBVFVSRV9VTlNFVCAoY3B1X2ZlYXR1cmVzLCBYU0FWRSk7 CisgICAgICBDUFVfRkVBVFVSRV9VTlNFVCAoY3B1X2ZlYXR1cmVzLCBYU0FWRU9QVCk7CisgICAg ICBDUFVfRkVBVFVSRV9VTlNFVCAoY3B1X2ZlYXR1cmVzLCBYU0FWRUMpOworICAgICAgQ1BVX0ZF QVRVUkVfVU5TRVQgKGNwdV9mZWF0dXJlcywgWEdFVEJWX0VDWF8xKTsKKyAgICAgIENQVV9GRUFU VVJFX1VOU0VUIChjcHVfZmVhdHVyZXMsIFhGRCk7CisKKyAgICAgIGRpc2FibGVfeHNhdmVfZmVh dHVyZXMgPSB0cnVlOworICAgIH0KKworICBpZiAoZGlzYWJsZV94c2F2ZV9mZWF0dXJlcworICAg ICAgfHwgKCFDUFVfRkVBVFVSRV9VU0FCTEVfUCAoY3B1X2ZlYXR1cmVzLCBYU0FWRSkKKwkgICYm ICFDUFVfRkVBVFVSRV9VU0FCTEVfUCAoY3B1X2ZlYXR1cmVzLCBYU0FWRUMpKSkKKyAgICB7Cisg ICAgICAvKiBDbGVhciB4c2F2ZV9zdGF0ZV9zaXplIGlmIGJvdGggWFNBVkUgYW5kIFhTQVZFQyBh cmVuJ3QgdXNhYmxlLiAgKi8KKyAgICAgIGNwdV9mZWF0dXJlcy0+eHNhdmVfc3RhdGVfc2l6ZSA9 IDA7CisKKyAgICAgIENQVV9GRUFUVVJFX1VOU0VUIChjcHVfZmVhdHVyZXMsIEFWWCk7CisgICAg ICBDUFVfRkVBVFVSRV9VTlNFVCAoY3B1X2ZlYXR1cmVzLCBBVlgyKTsKKyAgICAgIENQVV9GRUFU VVJFX1VOU0VUIChjcHVfZmVhdHVyZXMsIEFWWF9WTk5JKTsKKyAgICAgIENQVV9GRUFUVVJFX1VO U0VUIChjcHVfZmVhdHVyZXMsIEZNQSk7CisgICAgICBDUFVfRkVBVFVSRV9VTlNFVCAoY3B1X2Zl YXR1cmVzLCBWQUVTKTsKKyAgICAgIENQVV9GRUFUVVJFX1VOU0VUIChjcHVfZmVhdHVyZXMsIFZQ Q0xNVUxRRFEpOworICAgICAgQ1BVX0ZFQVRVUkVfVU5TRVQgKGNwdV9mZWF0dXJlcywgWE9QKTsK KyAgICAgIENQVV9GRUFUVVJFX1VOU0VUIChjcHVfZmVhdHVyZXMsIEYxNkMpOworICAgICAgQ1BV X0ZFQVRVUkVfVU5TRVQgKGNwdV9mZWF0dXJlcywgQVZYNTEyRik7CisgICAgICBDUFVfRkVBVFVS RV9VTlNFVCAoY3B1X2ZlYXR1cmVzLCBBVlg1MTJDRCk7CisgICAgICBDUFVfRkVBVFVSRV9VTlNF VCAoY3B1X2ZlYXR1cmVzLCBBVlg1MTJFUik7CisgICAgICBDUFVfRkVBVFVSRV9VTlNFVCAoY3B1 X2ZlYXR1cmVzLCBBVlg1MTJQRik7CisgICAgICBDUFVfRkVBVFVSRV9VTlNFVCAoY3B1X2ZlYXR1 cmVzLCBBVlg1MTJWTCk7CisgICAgICBDUFVfRkVBVFVSRV9VTlNFVCAoY3B1X2ZlYXR1cmVzLCBB Vlg1MTJEUSk7CisgICAgICBDUFVfRkVBVFVSRV9VTlNFVCAoY3B1X2ZlYXR1cmVzLCBBVlg1MTJC Vyk7CisgICAgICBDUFVfRkVBVFVSRV9VTlNFVCAoY3B1X2ZlYXR1cmVzLCBBVlg1MTJfNEZNQVBT KTsKKyAgICAgIENQVV9GRUFUVVJFX1VOU0VUIChjcHVfZmVhdHVyZXMsIEFWWDUxMl80Vk5OSVcp OworICAgICAgQ1BVX0ZFQVRVUkVfVU5TRVQgKGNwdV9mZWF0dXJlcywgQVZYNTEyX0JJVEFMRyk7 CisgICAgICBDUFVfRkVBVFVSRV9VTlNFVCAoY3B1X2ZlYXR1cmVzLCBBVlg1MTJfSUZNQSk7Cisg ICAgICBDUFVfRkVBVFVSRV9VTlNFVCAoY3B1X2ZlYXR1cmVzLCBBVlg1MTJfVkJNSSk7CisgICAg ICBDUFVfRkVBVFVSRV9VTlNFVCAoY3B1X2ZlYXR1cmVzLCBBVlg1MTJfVkJNSTIpOworICAgICAg Q1BVX0ZFQVRVUkVfVU5TRVQgKGNwdV9mZWF0dXJlcywgQVZYNTEyX1ZOTkkpOworICAgICAgQ1BV X0ZFQVRVUkVfVU5TRVQgKGNwdV9mZWF0dXJlcywgQVZYNTEyX1ZQT1BDTlREUSk7CisgICAgICBD UFVfRkVBVFVSRV9VTlNFVCAoY3B1X2ZlYXR1cmVzLCBBVlg1MTJfVlAySU5URVJTRUNUKTsKKyAg ICAgIENQVV9GRUFUVVJFX1VOU0VUIChjcHVfZmVhdHVyZXMsIEFWWDUxMl9CRjE2KTsKKyAgICAg IENQVV9GRUFUVVJFX1VOU0VUIChjcHVfZmVhdHVyZXMsIEFWWDUxMl9GUDE2KTsKKyAgICAgIENQ VV9GRUFUVVJFX1VOU0VUIChjcHVfZmVhdHVyZXMsIEFNWF9CRjE2KTsKKyAgICAgIENQVV9GRUFU VVJFX1VOU0VUIChjcHVfZmVhdHVyZXMsIEFNWF9USUxFKTsKKyAgICAgIENQVV9GRUFUVVJFX1VO U0VUIChjcHVfZmVhdHVyZXMsIEFNWF9JTlQ4KTsKKworICAgICAgQ1BVX0ZFQVRVUkVfVU5TRVQg KGNwdV9mZWF0dXJlcywgRk1BNCk7CisgICAgfQorCiAjZWxpZiBkZWZpbmVkIFNIQVJFRAogICAv KiBSZXVzZSBkbF9wbGF0Zm9ybSwgZGxfaHdjYXAgYW5kIGRsX2h3Y2FwX21hc2sgZm9yIHg4Ni4g IFRoZQogICAgICBnbGliYy5jcHUuaHdjYXBfbWFzayB0dW5hYmxlIGlzIGluaXRpYWxpemVkIGFs cmVhZHksIHNvIG5vCmRpZmYgLS1naXQgYS9zeXNkZXBzL3g4Ni9jcHUtdHVuYWJsZXMuYyBiL3N5 c2RlcHMveDg2L2NwdS10dW5hYmxlcy5jCmluZGV4IDEyNjg5NmY0MWIuLjYxYjA1ZTViMWQgMTAw NjQ0Ci0tLSBhL3N5c2RlcHMveDg2L2NwdS10dW5hYmxlcy5jCisrKyBiL3N5c2RlcHMveDg2L2Nw dS10dW5hYmxlcy5jCkBAIC0xNjgsNiArMTY4LDcgQEAgVFVOQUJMRV9DQUxMQkFDSyAoc2V0X2h3 Y2FwcykgKHR1bmFibGVfdmFsX3QgKnZhbHApCiAJICAgICAgQ0hFQ0tfR0xJQkNfSUZVTkNfQ1BV X09GRiAobiwgY3B1X2ZlYXR1cmVzLCBNT1ZCRSwgNSk7CiAJICAgICAgQ0hFQ0tfR0xJQkNfSUZV TkNfQ1BVX09GRiAobiwgY3B1X2ZlYXR1cmVzLCBTSFNUSywgNSk7CiAJICAgICAgQ0hFQ0tfR0xJ QkNfSUZVTkNfQ1BVX09GRiAobiwgY3B1X2ZlYXR1cmVzLCBTU1NFMywgNSk7CisJICAgICAgQ0hF Q0tfR0xJQkNfSUZVTkNfQ1BVX09GRiAobiwgY3B1X2ZlYXR1cmVzLCBYU0FWRSwgNSk7CiAJICAg IH0KIAkgIGJyZWFrOwogCWNhc2UgNjoKLS0gCjIuMzAuMgoK --000000000000f7725505bdec9c12--