From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com
 [IPv6:2607:f8b0:4864:20::52c])
 by sourceware.org (Postfix) with ESMTPS id B8601385840E
 for <libc-alpha@sourceware.org>; Thu, 11 Nov 2021 16:49:46 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8601385840E
Received: by mail-pg1-x52c.google.com with SMTP id f5so5605542pgc.12
 for <libc-alpha@sourceware.org>; Thu, 11 Nov 2021 08:49:46 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=qQX6ZkN+aQq3kdhOyk3VEIv29SrNT42rN+Xqv9d00eM=;
 b=i3wRv7gG0g+FIyabvl/jbNgOQMAgjLqaWxm43TFyr5s/kFMZglh61jLBAHt/Pn2U53
 enwOMh/yZfTmXwVFhdp9CH1nUMVno9qNRKgPMClSxZWr6ddhRhJ3dgSvuVlLzv7H3eBu
 jdn88CK0Y8uQWK2ZkFo2u/qIGP0EcQpNXjd+iOEv/ll5u3BBCX6cWbR8g8DjRJX9vAKS
 /2sudOBlkSj8G8iFh8Xi7OrdGs6Kb2/Sl7k0eFPEO9EyC3f3fI1v+KCx0wuuAEpKWwOT
 /Ss7P1YfdGI7HZrXmMq7ZiDJwpZFtpG1CRH3NfYwzcc7WSNJ25O4+X2glzsrCEBvFTm2
 OmYA==
X-Gm-Message-State: AOAM533e0o9qG4sZ10T/tcYS0q0GUCvh9nX3N3u8XTsOBFWzki40+gnr
 6jQmy98I4F4+NBQTu4Pj97WZZsaajqGxDYPItJE=
X-Google-Smtp-Source: ABdhPJwNcXzTz4bAtBkDGMY0uqvqszPoXo14JqRtqOt0mdkf0cjNpvPe9Vz2tBTObqeJ/VTaPn//NUVnjNJ8h4Fs7P8=
X-Received: by 2002:a05:6a00:b4c:b0:481:2a:f374 with SMTP id
 p12-20020a056a000b4c00b00481002af374mr7961688pfo.60.1636649385793; Thu, 11
 Nov 2021 08:49:45 -0800 (PST)
MIME-Version: 1.0
References: <20211110235016.254025-1-goldstein.w.n@gmail.com>
 <CAMe9rOoNx=0JtNtORp5gYJe5yfx1jkm1s8BXRym+zVh+FW2upg@mail.gmail.com>
 <CAFUsyf+bqNsBve1OPoGs4LodvxixPRNrdeGqZFfhSfzcyiN0Xw@mail.gmail.com>
In-Reply-To: <CAFUsyf+bqNsBve1OPoGs4LodvxixPRNrdeGqZFfhSfzcyiN0Xw@mail.gmail.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 11 Nov 2021 08:49:09 -0800
Message-ID: <CAMe9rOqe-ZVYRNjU-ypcs5t1jSPN=foMGHxq7ie4kXnfQ5a1oA@mail.gmail.com>
Subject: Re: [PATCH v1] String: Split memcpy tests so that parallel build is
 faster
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
 "Carlos O'Donell" <carlos@systemhalted.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3023.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Nov 2021 16:49:48 -0000

> >
> > LGTM.
> >

> > Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

>
> Thanks. Pushed.

I got

before:

time string/test-memcpy --direct
                        builtin_memcpy simple_memcpy
__memcpy_avx_unaligned __memcpy_avx_unaligned_erms
__memcpy_avx_unaligned_rtm __memcpy_avx_unaligned_erms_rtm
__memcpy_evex_unaligned __memcpy_evex_unaligned_erms
__memcpy_ssse3_back __memcpy_ssse3 __memcpy_avx512_no_vzeroupper
__memcpy_avx512_unaligned __memcpy_avx512_unaligned_erms
__memcpy_sse2_unaligned __memcpy_sse2_unaligned_erms __memcpy_erms
string/test-memcpy --direct  289.72s user 14.95s system 99% cpu 5:05.38 total

time string/test-mempcpy --direct
                        simple_mempcpy __mempcpy_avx512_no_vzeroupper
__mempcpy_avx512_unaligned __mempcpy_avx512_unaligned_erms
__mempcpy_avx_unaligned__mempcpy_avx_unaligned_erms
__mempcpy_avx_unaligned_rtm __mempcpy_avx_unaligned_erms_rtm
__mempcpy_evex_unaligned __mempcpy_evex_unaligned_erms
__mempcpy_ssse3_back __mempcpy_ssse3 __mempcpy_sse2_unaligned
__mempcpy_sse2_unaligned_erms __mempcpy_erms
string/test-mempcpy --direct  174.11s user 9.41s system 99% cpu 3:03.93 total

after:

time string/test-mempcpy --direct
                        simple_mempcpy __mempcpy_avx512_no_vzeroupper
__mempcpy_avx512_unaligned __mempcpy_avx512_unaligned_erms
__mempcpy_avx_unaligned __mempcpy_avx_unaligned_erms
__mempcpy_avx_unaligned_rtm __mempcpy_avx_unaligned_erms_rtm
__mempcpy_evex_unaligned __mempcpy_evex_unaligned_erms
__mempcpy_ssse3_back __mempcpy_ssse3 __mempcpy_sse2_unaligned
__mempcpy_sse2_unaligned_erms __mempcpy_erms
string/test-mempcpy --direct  155.37s user 9.01s system 99% cpu 2:44.77 total

time string/test-memcpy --direct
                        builtin_memcpy simple_memcpy
__memcpy_avx_unaligned __memcpy_avx_unaligned_erms
__memcpy_avx_unaligned_rtm __memcpy_avx_unaligned_erms_rtm
__memcpy_evex_unaligned __memcpy_evex_unaligned_erms
__memcpy_ssse3_back __memcpy_ssse3 __memcpy_avx512_no_vzeroupper
__memcpy_avx512_unaligned __memcpy_avx512_unaligned_erms
__memcpy_sse2_unaligned __memcpy_sse2_unaligned_erms __memcpy_erms
string/test-memcpy --direct  163.20s user 9.09s system 99% cpu 2:52.69 total

Why isn't string/test-mempcpy run-time almost unchanged?


-- 
H.J.