Re: [PATCH] x86_64: Disable libmvec tests if multiarch not enabled [BZ# 28869]

["H.J. Lu" <hjl.tools@gmail.com>]

On Wed, Feb 23, 2022 at 2:43 PM Sunil K Pandey <skpgkp2@gmail.com> wrote:
>
> This patch disable libmvec math tests if multiarch not enabled.
>
> This fixes [BZ# 28869]
> ---
>  sysdeps/x86_64/fpu/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/sysdeps/x86_64/fpu/Makefile b/sysdeps/x86_64/fpu/Makefile
> index 9fb587cf8f..8278ce104a 100644
> --- a/sysdeps/x86_64/fpu/Makefile
> +++ b/sysdeps/x86_64/fpu/Makefile
> @@ -24,6 +24,8 @@ libmvec-support += \
>      $(addprefix svml_s_,$(addsuffix $(l),$(libmvec-funcs))))
>  endif
>
> +# Do not run libmvec tests if multiarch not enabled.
> +ifneq ($(multi-arch),no)
>  # Variables for libmvec tests.
>  ifeq ($(subdir)$(build-mathvec),mathyes)
>  libmvec-tests += double-vlen2 double-vlen4 double-vlen4-avx2 \
> @@ -112,3 +114,4 @@ $(objpfx)bench-double-%.c: $(bench-libmvec-deps)
>         $(PYTHON) $(..)sysdeps/x86_64/fpu/scripts/bench_libmvec.py $(basename $(@F)); } > $@-tmp
>         mv -f $@-tmp $@
>  endif
> +endif
> --
> 2.34.1
>

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.

-- 
H.J.