From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com
 [IPv6:2607:f8b0:4864:20::435])
 by sourceware.org (Postfix) with ESMTPS id C33BE3858409
 for <libc-alpha@sourceware.org>; Wed, 23 Feb 2022 22:54:50 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C33BE3858409
Received: by mail-pf1-x435.google.com with SMTP id z16so253030pfh.3
 for <libc-alpha@sourceware.org>; Wed, 23 Feb 2022 14:54:50 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=2pnjN21jEvSXwSWPl8sZFUEKnAZskTVVHCIACFoZwns=;
 b=so7Ij+cB+CA0wy4OtWsVSvk7ERvIq7CnVRR8cJQgfUqGDgCBSFKvAUWN9STOSjCFg8
 jvydaE7IbUz4si1UnjakjLOAISVe+Wjc4o+VphSw46rgGO4l5pclgelPz/iiFjqsySI7
 tkUJNufPky3HrwHxdgGiefAepattTfDDBY99Vys1NUetZihnHkhZYuwvH9+gNd15PZxJ
 4R4eZuzW+EHpAyHaRSuynsadww788uy8DzysniUhIHFWIstjrhyV93shBKB0n7wqvwfH
 MXvG3XWhydsborr2tyv5LUtYEwUftBr4zJ1v6Xg4ai6o/wp08OAxz4v7QB4v8GB/9poo
 ncmQ==
X-Gm-Message-State: AOAM530g+qwUkH5pMbuJobWzzPBoy3K73/lGdP4qWoDD1Ipd94D5usg0
 KIEArF1iUQkYr0QFo/jyb0y7wKh8qi/Jcwu0nVA6G4n0S4g=
X-Google-Smtp-Source: ABdhPJzo673icouR9z5i8XR4Rpvotk2l0FTOimQynTrGQtexXeTy8m8IJ/mWV4LvkNlbvvHbOStpo34s6rYQrKlG08M=
X-Received: by 2002:aa7:8d54:0:b0:4e0:bd6:cfb9 with SMTP id
 s20-20020aa78d54000000b004e00bd6cfb9mr2028349pfe.60.1645656889914; Wed, 23
 Feb 2022 14:54:49 -0800 (PST)
MIME-Version: 1.0
References: <20220223224255.2077646-1-skpgkp2@gmail.com>
In-Reply-To: <20220223224255.2077646-1-skpgkp2@gmail.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 23 Feb 2022 14:54:14 -0800
Message-ID: <CAMe9rOqiUyx3vDCFcfLWTN-Tx=YgqvJJsS1fQ3hG910cj16hwA@mail.gmail.com>
Subject: Re: [PATCH] x86_64: Disable libmvec tests if multiarch not enabled
 [BZ# 28869]
To: Sunil K Pandey <skpgkp2@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3026.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Feb 2022 22:54:52 -0000

On Wed, Feb 23, 2022 at 2:43 PM Sunil K Pandey <skpgkp2@gmail.com> wrote:
>
> This patch disable libmvec math tests if multiarch not enabled.
>
> This fixes [BZ# 28869]
> ---
>  sysdeps/x86_64/fpu/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/sysdeps/x86_64/fpu/Makefile b/sysdeps/x86_64/fpu/Makefile
> index 9fb587cf8f..8278ce104a 100644
> --- a/sysdeps/x86_64/fpu/Makefile
> +++ b/sysdeps/x86_64/fpu/Makefile
> @@ -24,6 +24,8 @@ libmvec-support += \
>      $(addprefix svml_s_,$(addsuffix $(l),$(libmvec-funcs))))
>  endif
>
> +# Do not run libmvec tests if multiarch not enabled.
> +ifneq ($(multi-arch),no)
>  # Variables for libmvec tests.
>  ifeq ($(subdir)$(build-mathvec),mathyes)
>  libmvec-tests += double-vlen2 double-vlen4 double-vlen4-avx2 \
> @@ -112,3 +114,4 @@ $(objpfx)bench-double-%.c: $(bench-libmvec-deps)
>         $(PYTHON) $(..)sysdeps/x86_64/fpu/scripts/bench_libmvec.py $(basename $(@F)); } > $@-tmp
>         mv -f $@-tmp $@
>  endif
> +endif
> --
> 2.34.1
>

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.

-- 
H.J.