From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id 1B688385741C for ; Thu, 24 Mar 2022 18:58:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1B688385741C Received: by mail-pj1-x1029.google.com with SMTP id gb19so5505497pjb.1 for ; Thu, 24 Mar 2022 11:58:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5oA2TNm/8oGZjP147vaVja0Vg6pdaQ/mX06LIh4Ecys=; b=L2Q6d1zprSbODLDqSDXLf28XWq34AH0HiIkRmoDvAIxTQAzPcFvGSGNx1wOCNB8+ss dWRddOvutx7Oul54SEZAESur9TpVem7fepm6vvpy1VZ1rJdz1giVf3FH7qB3cUdKJVFT OIeG0RwCB9KnZDWgZ/D7KxCLIKvqtpSpPJTeAzrPsOjke4q9igfKA7219HUKKkpb8ZV1 VR7VdmysNtupiV8dzp5oS7X4Y4nIXxZgojqSDIWMKkj/F2IK181NAnk5uevNc5zOIbdK A0Fbx92cWSDGpyuycQPmG+Aj8Az/ePYOtsx7i9poKoYeP2OWB2XCilmBcS7ER6aC2Q7H Ww3w== X-Gm-Message-State: AOAM53033Vp941FQz9KzYGygky+9oxa+5BrZOHki8M9k7XIxmneBpDjF NzQxosvBa17SZEdOISGfYPpGAyj+pd4BqM1/464= X-Google-Smtp-Source: ABdhPJwtLlURKNcQFPlBSHtuW6vUKB2HwFiA4gDRieA8SkvFST/Qn92oIIkz+Eqevd0v9mM0BDf3kIQvDrHE4eJ6dRA= X-Received: by 2002:a17:902:f690:b0:154:2ceb:f18a with SMTP id l16-20020a170902f69000b001542cebf18amr7425701plg.4.1648148283969; Thu, 24 Mar 2022 11:58:03 -0700 (PDT) MIME-Version: 1.0 References: <20220323215734.3927131-1-goldstein.w.n@gmail.com> <20220323215734.3927131-10-goldstein.w.n@gmail.com> In-Reply-To: <20220323215734.3927131-10-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Thu, 24 Mar 2022 11:57:28 -0700 Message-ID: Subject: Re: [PATCH v1 10/23] x86: Remove strpbrk-sse2.S and use the generic implementation To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3026.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2022 18:58:06 -0000 On Wed, Mar 23, 2022 at 3:00 PM Noah Goldstein wrote: > > The generic implementation is faster (see strcspn commit). > > All string/memory tests pass. > --- > .../x86_64/multiarch/{strpbrk-sse2.S => strpbrk-sse2.c} | 9 ++++----- > sysdeps/x86_64/strpbrk.S | 3 --- > 2 files changed, 4 insertions(+), 8 deletions(-) > rename sysdeps/x86_64/multiarch/{strpbrk-sse2.S => strpbrk-sse2.c} (84%) > delete mode 100644 sysdeps/x86_64/strpbrk.S > > diff --git a/sysdeps/x86_64/multiarch/strpbrk-sse2.S b/sysdeps/x86_64/multiarch/strpbrk-sse2.c > similarity index 84% > rename from sysdeps/x86_64/multiarch/strpbrk-sse2.S > rename to sysdeps/x86_64/multiarch/strpbrk-sse2.c > index d537b6c27b..d03214c4fb 100644 > --- a/sysdeps/x86_64/multiarch/strpbrk-sse2.S > +++ b/sysdeps/x86_64/multiarch/strpbrk-sse2.c > @@ -1,4 +1,4 @@ > -/* strpbrk optimized with SSE2. > +/* strpbrk. > Copyright (C) 2017-2022 Free Software Foundation, Inc. > This file is part of the GNU C Library. > > @@ -19,11 +19,10 @@ > #if IS_IN (libc) > > # include > -# define strcspn __strpbrk_sse2 > +# define STRPBRK __strpbrk_sse2 > > # undef libc_hidden_builtin_def > -# define libc_hidden_builtin_def(strpbrk) > +# define libc_hidden_builtin_def(STRPBRK) > #endif > > -#define USE_AS_STRPBRK > -#include > +#include > diff --git a/sysdeps/x86_64/strpbrk.S b/sysdeps/x86_64/strpbrk.S > deleted file mode 100644 > index 21888a5b92..0000000000 > --- a/sysdeps/x86_64/strpbrk.S > +++ /dev/null > @@ -1,3 +0,0 @@ > -#define strcspn strpbrk > -#define USE_AS_STRPBRK > -#include > -- > 2.25.1 > LGTM. Reviewed-by: H.J. Lu Thanks. -- H.J.