From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id CBA13383468C for ; Tue, 28 Jun 2022 03:31:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CBA13383468C Received: by mail-pf1-x433.google.com with SMTP id x138so8131941pfc.3 for ; Mon, 27 Jun 2022 20:31:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6l0xOPy1RZ6m4qCx2HN1pIyZze2n5MlOkbqdrGEnpvI=; b=aBPcqUY4rEgMNIVfxGWNT3dpj7/CZpjSpYyEJseUr499knqJvvDv0vsWRdFv8vwE7j F9mkqDSrVMiGFeK2GTRaw0+bmxJX8WGUOXS9yRdmZDcjIxfKlm25CqLmngAEmLDhNxNn Ga6/1tCKf0orSkLat0FcCcPaZwBUjEergFzkmujNXNmKdIyeH2B94QZx+Kua9KDi9LIZ jsC2SG8nxK2wFjNIZN4XnzJZx0a4qxxyClf8tcn2yWwQj6FH9RmVjGhQW3tFS0RoCM9A USNDg5NMOujWnuBMcOQYAMS5sZz44egJFEHGzkOIdAYeigFh/ME6ArUNbM45UHJCLWt3 bT2g== X-Gm-Message-State: AJIora/PxWFIwfTs2vf3NfuW+uaHO40CtnNWIlZ9375lugmO3t0wE3zG 6OjnGtB+r/+caQ3BAxlIL4VRzNNTpHeBMww4kTw= X-Google-Smtp-Source: AGRyM1ttfDsVNXg3HaeuEJ/s5bjFRv+r3WETrdbz9kotanUtC+pWNeCw165ltoFY1rQU9CQJkGwrTY87a+OXwwlj3lU= X-Received: by 2002:a05:6a00:14c4:b0:525:9341:288 with SMTP id w4-20020a056a0014c400b0052593410288mr2487902pfu.1.1656387073873; Mon, 27 Jun 2022 20:31:13 -0700 (PDT) MIME-Version: 1.0 References: <20220628010446.3464287-1-goldstein.w.n@gmail.com> <20220628032602.218678-1-goldstein.w.n@gmail.com> In-Reply-To: <20220628032602.218678-1-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Mon, 27 Jun 2022 20:30:37 -0700 Message-ID: Subject: Re: [PATCH v3] x86: Add more feature definitions to isa-level.h To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3025.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 03:31:16 -0000 On Mon, Jun 27, 2022 at 8:26 PM Noah Goldstein wrote: > > This commit doesn't change anything in itself. It is just to add > definitions that will be needed by future patches. > --- > sysdeps/x86/isa-level.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/sysdeps/x86/isa-level.h b/sysdeps/x86/isa-level.h > index f293aea906..443631662f 100644 > --- a/sysdeps/x86/isa-level.h > +++ b/sysdeps/x86/isa-level.h > @@ -71,11 +71,13 @@ > #define AVX512F_X86_ISA_LEVEL 4 > #define AVX512VL_X86_ISA_LEVEL 4 > #define AVX512BW_X86_ISA_LEVEL 4 > +#define AVX512DQ_X86_ISA_LEVEL 4 > > /* ISA level >= 3 guaranteed includes. */ > #define AVX_X86_ISA_LEVEL 3 > #define AVX2_X86_ISA_LEVEL 3 > #define BMI2_X86_ISA_LEVEL 3 > +#define MOVBE_X86_ISA_LEVEL 3 > > /* NB: This feature is enabled when ISA level >= 3, which was disabled > for the following CPUs: > @@ -89,6 +91,13 @@ > when ISA level < 3. */ > #define Prefer_No_VZEROUPPER_X86_ISA_LEVEL 3 > > +/* ISA level >= 2 guaranteed includes. */ > +#define SSE4_2_X86_ISA_LEVEL 2 > +#define SSSE3_X86_ISA_LEVEL 2 Please move them immediately after MOVBE_X86_ISA_LEVEL. > +/* This feature is enabled when ISA level >= 2. */ > +#define Fast_Unaligned_Load_X86_ISA_LEVEL 2 > + > /* Both X86_ISA_CPU_FEATURE_USABLE_P and X86_ISA_CPU_FEATURES_ARCH_P > macros are wrappers for the respective CPU_FEATURE{S}_{USABLE|ARCH}_P > runtime checks. They differ in two ways. > -- > 2.34.1 > -- H.J.