From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by sourceware.org (Postfix) with ESMTPS id B8D8F3847725 for ; Wed, 3 Apr 2024 20:01:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B8D8F3847725 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B8D8F3847725 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b2b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712174473; cv=none; b=jtcQDvOnJ+Ca6ojCV8L0tarAgCuBSEfc82ArDaKUxoq0Uriee18U/fwldIzqc4MhO7hTlSW9F6Kzie9ejOH/+K5ZXio5pUh9crN/bF0XAvEtXwMu3LsMpPOD4US6za8E1V1kbTK2MkajK5HUCuXEPYSreVHnwH0dSTs+hg0BJPQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712174473; c=relaxed/simple; bh=5uDfQ8+6Zs4RmwROYYAUPcp4XO3v6rsxfOznfeFOvHk=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=gua/9Z3TWe4PtrkYRhmZqaC78ZuwHSfkSoZ6x81ndg2ReYva/iG47tF/JxpJz7FWdMugKM43sTcvXdjLq4u2uS078wRXPUgg08WgUjAhV/G5EvR0eGiquICk3DGFiWCC68sMRFZEv6s0za7zeWJ/lZbDyL8CX4QbhETnsTahibU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb2b.google.com with SMTP id 3f1490d57ef6-dd161eb03afso274863276.0 for ; Wed, 03 Apr 2024 13:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712174470; x=1712779270; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IX2+IuA1+UE7P1bU2J6g+KxeewtUREwcN+nkH+7b9tQ=; b=IGDikrJDXwCTHwLyQlwM3T06oSXLIgqpu8+sxb7IT7HkCrxTbkaaZo1+S6y8gNfGnO QxVeUwUpPPpE6LtzsxkX96Ku+LBCY3GX/jZSMXqZ5gRVUW2DZhwBk086KoEsgv5QHh42 MNSgsyj/k/1ViQMIQg5NB0362A5VXAc5uzxKaN56aUsIUjsiP5DiT2BNqPj5a4rR1Vkr CT4lMfxHtCvth90qP/FjTazGXS9C0fiS9uD13joqeGTpeaK3zQbLAfckiBZcFhKe15HR HGmFxZ/vVzQQoh6fadDt/8/psYVkE+iikRi9goDdgIQcWbUMdDObacwr6MyOGPmZkK77 m/Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712174470; x=1712779270; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IX2+IuA1+UE7P1bU2J6g+KxeewtUREwcN+nkH+7b9tQ=; b=bgt2bS2SN/OTQ+OfumHVrIXNSkjgChdIgEfGeiz3ToUecSge4zu41ws+dEMRQzDJGj /zPkEBIL+cq3Lev8YLUDHOi7gbBFq+Fd09w5/cUjO0lpzgCK2Ndvw8XdAhfwIamirWwa 1PViCMqwAVB3GTQ8cDxUQ7QJiv5/Sn4rQ135W2e5czxUPwK+DsNq/IjfedPl8hHU14fr 5rOSL/+a0eImfKe95isobbhtqX++ZmgUTAKoePA+tddbKqLk7zNvrM/ueGlIvnRtDBa5 qSbdDxCLVOGL3St1fPQPLwy1rhG9ger/73doXYy09jGjxJdLeFwmJjkjv0Q5BR6iis4E 9pHw== X-Gm-Message-State: AOJu0Yw/Xb6spAA9ObBwtWzDypy/Hy/lstWYZo7vMa2rb9/u8H1VSjdW gkSpcBLNK54bC+Lc2JhhZUayNB1rOBTGgw4d4Gu+BK0qKdVrbwTP4li/oJMHH1pqRZlN5/mxtDJ LHC+6EnClU4/m5U0zSO4PDxXefP2I3Q8zsUI= X-Google-Smtp-Source: AGHT+IGkcMoykEvfWsPZQE5E1YR5O3PWSL+lMMLUmLWM3Xd57yH42ovY7GDKIfV6nkYIS5i6BZoAaGE3cbds1eQaZks= X-Received: by 2002:a05:6902:54f:b0:dcb:fe58:a08b with SMTP id z15-20020a056902054f00b00dcbfe58a08bmr483674ybs.15.1712174470034; Wed, 03 Apr 2024 13:01:10 -0700 (PDT) MIME-Version: 1.0 References: <20240403123928.165033-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Wed, 3 Apr 2024 13:00:33 -0700 Message-ID: Subject: Re: [PATCH] elf: Don't call fatal_error in _dl_signal_error To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3019.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Apr 3, 2024 at 12:54=E2=80=AFPM Adhemerval Zanella Netto wrote: > > > > On 03/04/24 09:39, H.J. Lu wrote: > > Don't call fatal_error in _dl_signal_error since _dl_signal_error shoul= d > > only be called from _dl_catch_exception and get_catch should never retu= rn > > NULL. Otherwise, fatal_error should be called directly instead. > > Is this related to BZ#31596 or did you catch it by code review? I think Yes, it is related. I noticed by code review. > this is required for lazy binding being fatal error on initializer > functions (elf/dl-open.c:829). elf/dl-open.c:829 calls _dl_catch_exception. > > --- > > elf/dl-catch.c | 13 ++++--------- > > 1 file changed, 4 insertions(+), 9 deletions(-) > > > > diff --git a/elf/dl-catch.c b/elf/dl-catch.c > > index 2109516dba..a023555165 100644 > > --- a/elf/dl-catch.c > > +++ b/elf/dl-catch.c > > @@ -117,16 +117,11 @@ _dl_signal_error (int errcode, const char *objnam= e, const char *occasion, > > if (! errstring) > > errstring =3D N_("DYNAMIC LINKER BUG!!!"); > > > > - if (lcatch !=3D NULL) > > - { > > - _dl_exception_create (lcatch->exception, objname, errstring); > > - *lcatch->errcode =3D errcode; > > + _dl_exception_create (lcatch->exception, objname, errstring); > > + *lcatch->errcode =3D errcode; > > > > - /* We do not restore the signal mask because none was saved. */ > > - __longjmp (lcatch->env[0].__jmpbuf, 1); > > - } > > - else > > - fatal_error (errcode, objname, occasion, errstring); > > + /* We do not restore the signal mask because none was saved. */ > > + __longjmp (lcatch->env[0].__jmpbuf, 1); > > } > > rtld_hidden_def (_dl_signal_error) > > --=20 H.J.