From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id 68B58385E451 for ; Thu, 24 Mar 2022 19:00:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 68B58385E451 Received: by mail-pg1-x536.google.com with SMTP id o13so4553162pgc.12 for ; Thu, 24 Mar 2022 12:00:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2XByPUe3LUxTYrow4VsFt8KiRl3AbZ1Ecvzk4wrVxpw=; b=K+8FgH5yF7Qb0XxSgEh42Pg+NoVhrsqd5b41jCcDFumwz3dG8J+sx8V1dPRKFRuAK5 lhYhbKbAyyv2TGsFndq6tyQM6nJ9h7lW/diTkHU3RB0lS44c+dGLOs217FPdCJksxAZ4 cBsWEzcTHiXf4RMjZg5oF3z8H9Wj4l8noVer4cs7+EEuhrjbyXpnYQy+39s1qj3R3ORQ 7acsXxXABxLVSYFoaMlctZ0Tevp9QjEoWve27dSoEumpeEEgZKPQQFpofnqntd97Poc6 ThQgcYyqKZKbOIZurRXCWUybl8zk5KBlXE4l0tQ20CMvDhJYBbQGqfaPe8qYIIzntagV UFwQ== X-Gm-Message-State: AOAM533gR8q5YyDeJRCsseN5Xd0lnUpPuTMosP2O0issOgJj1fuNzUi6 OrQiLgH9lOe1FMizWCJGafPKJ1T9OEc/CkCxcR0= X-Google-Smtp-Source: ABdhPJwO1B0LdzC/HlcEMkUfXDa8sQomS5StPfn6ywk/rnv9KePAB2wO5LqNkL7AmuYGLgMLhi86Ej6rOi+JsZLcTLY= X-Received: by 2002:a63:dd47:0:b0:381:2bb3:86ba with SMTP id g7-20020a63dd47000000b003812bb386bamr5089522pgj.381.1648148412529; Thu, 24 Mar 2022 12:00:12 -0700 (PDT) MIME-Version: 1.0 References: <20220323215734.3927131-1-goldstein.w.n@gmail.com> <20220323215734.3927131-12-goldstein.w.n@gmail.com> In-Reply-To: <20220323215734.3927131-12-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Thu, 24 Mar 2022 11:59:36 -0700 Message-ID: Subject: Re: [PATCH v1 12/23] x86: Fix fallback for wcsncmp_avx2 in strcmp-avx2.S [BZ #28896] To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2022 19:00:15 -0000 On Wed, Mar 23, 2022 at 3:01 PM Noah Goldstein wrote: > > Overflow case for __wcsncmp_avx2_rtm should be __wcscmp_avx2_rtm not > __wcscmp_avx2. > > All string/memory tests pass. > --- > sysdeps/x86_64/multiarch/strcmp-avx2.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S > index 52ff5ad724..86a86b68e3 100644 > --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S > +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S > @@ -122,7 +122,7 @@ ENTRY(STRCMP) > are cases where length is large enough that it can never be a > bound on valid memory so just use wcscmp. */ > shrq $56, %rcx > - jnz __wcscmp_avx2 > + jnz OVERFLOW_STRCMP > > leaq (, %rdx, 4), %rdx > # endif > -- > 2.25.1 > Isn't it a bug? Is there a glibc bug? Should this also be fixed on release branches? -- H.J.