From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com
 [IPv6:2607:f8b0:4864:20::52a])
 by sourceware.org (Postfix) with ESMTPS id 93D2D3858413
 for <libc-alpha@sourceware.org>; Wed,  3 Aug 2022 16:59:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 93D2D3858413
Received: by mail-pg1-x52a.google.com with SMTP id h132so15633753pgc.10
 for <libc-alpha@sourceware.org>; Wed, 03 Aug 2022 09:59:33 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=cU6pKCRXnbPlWllXUa8Uj/Q+9oLUk0AEi45JgSXjbSg=;
 b=Qao7IFWckCaMSjKz+5R5uQeVidgxFF4KTvSev00w63MNBcztvOyCLQTx/BxhU3PPiW
 HjRG8+izUmW/hx9K+9cgueqyh4Tx/JdGefa6cEHZM7stV/St11M+S7CEyGxsj0+DqGjA
 lE/tJCQP9NB8EMN0X/uEVpoqopgNbXg/ZJgZ3zFBkRHYHsvPfmxmcPX148HvMDrccZmL
 ST+cVfM3wMyN0Mm1S/3JphTrt3zCpNxSEDfuI0ohS+mAXcQqLJVw7V4Q7gHz6cjPxsc3
 qPMD1G5RcUCELuMLx0sCDtdJKXChZqvP69HOEEUDJA9F69rcH0oIR5+khuIrzDLK4gaw
 Iq6Q==
X-Gm-Message-State: ACgBeo1/LQzxtmuU8ZDQJt+S1q0rk5DNi3PyBqqvZmLJ1xhxGaRu/rPA
 yIRwpVB5z+wh9mn6FGEZhrdIe4NYwuUTn/bB2S0=
X-Google-Smtp-Source: AA6agR5X7pLgf5bK6KoPLP6LP7LajngcGJIoLrP9Y4aZ7zMzAfANFFC5j6If1IYw/7VZhAS5gaa9ULkduXYkLP0XEkg=
X-Received: by 2002:a62:cec9:0:b0:52d:414b:c70f with SMTP id
 y192-20020a62cec9000000b0052d414bc70fmr17959358pfg.20.1659545972458; Wed, 03
 Aug 2022 09:59:32 -0700 (PDT)
MIME-Version: 1.0
References: <87o7x1b9y7.fsf@oldenburg.str.redhat.com>
In-Reply-To: <87o7x1b9y7.fsf@oldenburg.str.redhat.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 3 Aug 2022 09:58:56 -0700
Message-ID: <CAMe9rOqtbL9Yj5nMzO05htwB8UhbkJuq8q0Zj4c+zbAXz+RwwA@mail.gmail.com>
Subject: Re: [PATCH] Linux: Remove exit system call from _exit
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3024.4 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Aug 2022 16:59:34 -0000

On Wed, Aug 3, 2022 at 8:53 AM Florian Weimer via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> exit only terminates the current thread, not the whole process, so it
> is the wrong fallback system call in this context.  All supported
> Linux versions implement the exit_group system call anyway.
>
> ---
>  sysdeps/unix/sysv/linux/_exit.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/sysdeps/unix/sysv/linux/_exit.c b/sysdeps/unix/sysv/linux/_exit.c
> index 7ad3e0aae4..f916d97ae2 100644
> --- a/sysdeps/unix/sysv/linux/_exit.c
> +++ b/sysdeps/unix/sysv/linux/_exit.c
> @@ -28,7 +28,6 @@ _exit (int status)
>    while (1)
>      {
>        INLINE_SYSCALL (exit_group, 1, status);
> -      INLINE_SYSCALL (exit, 1, status);
>
>  #ifdef ABORT_INSTRUCTION
>        ABORT_INSTRUCTION;
>

LGTM.

Thanks.

-- 
H.J.