From: "H.J. Lu" <hjl.tools@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] ldconfig/x86: Store ISA level in cache and aux cache
Date: Thu, 28 Jan 2021 12:43:35 -0800 [thread overview]
Message-ID: <CAMe9rOqu8j+yiYKM9miSSsnaYXx1DvB8kQ_RYO2wTvuUS9ay_A@mail.gmail.com> (raw)
In-Reply-To: <87im7g24qt.fsf@oldenburg.str.redhat.com>
On Thu, Jan 28, 2021 at 12:20 PM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu via Libc-alpha:
>
> > Subject: [PATCH] ldconfig/x86: Store ISA level in cache and aux cache
> >
> > Store ISA level in the portion of the unused upper 32 bits of the hwcaps
> > field in cache and the unused pad field in aux cache. ISA level is stored
> > and checked only for shared objects in glibc-hwcaps subdirectories. The
> > shared objects in the default directories aren't checked since there are
> > no fallbacks for these shared objects.
>
> Why is it necessary to duplicate the ISA levels in the cache when they
> are implied by the subdirectory name?
>
> I would have expected to store the ISA levels in the cache for DSOs
> *not* in glibc-hwcaps subdirectories. The redundancy does not make
> sense to me.
>
> ldconfig checking for matches between ISA levels and subdirectory names
> makes sense too.
>
A v4 DSO may be placed in v2 subdirectory by mistake.
--
H.J.
next prev parent reply other threads:[~2021-01-28 20:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 14:49 V5 [PATCH 0/2] x86: Support GNU_PROPERTY_X86_ISA_1_NEEDED marker [BZ #26717] H.J. Lu
2020-12-06 14:49 ` V5 [PATCH 1/2] x86: Support GNU_PROPERTY_X86_ISA_1_V[234] " H.J. Lu
2021-01-06 12:00 ` Adhemerval Zanella
2021-01-06 17:11 ` V6 " H.J. Lu
2021-01-07 20:09 ` Adhemerval Zanella
2021-01-07 20:58 ` H.J. Lu
2021-01-18 11:17 ` Florian Weimer
2021-01-18 13:49 ` H.J. Lu
2021-01-18 15:15 ` Florian Weimer
2020-12-06 14:49 ` V5 [PATCH 2/2] ldconfig/x86: Add ISA level check to glibc-hwcaps H.J. Lu
2020-12-07 10:00 ` Florian Weimer
2020-12-08 13:25 ` H.J. Lu
2020-12-08 13:31 ` Florian Weimer
2020-12-08 14:10 ` H.J. Lu
2020-12-08 14:18 ` Florian Weimer
2020-12-08 14:23 ` H.J. Lu
2020-12-08 15:15 ` Florian Weimer
2020-12-08 15:31 ` H.J. Lu
2020-12-09 3:27 ` [PATCH] ldconfig/x86: Store ISA level in cache and aux cache H.J. Lu
2021-01-12 16:25 ` Adhemerval Zanella
2021-01-12 23:32 ` V2 " H.J. Lu
2021-01-13 13:47 ` Adhemerval Zanella
2021-01-13 14:12 ` H.J. Lu
2021-01-28 20:20 ` Florian Weimer
2021-01-28 20:43 ` H.J. Lu [this message]
2021-01-29 8:56 ` Florian Weimer
2021-01-29 12:44 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOqu8j+yiYKM9miSSsnaYXx1DvB8kQ_RYO2wTvuUS9ay_A@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).