From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com
 [IPv6:2607:f8b0:4864:20::102f])
 by sourceware.org (Postfix) with ESMTPS id 38CF83954433
 for <libc-alpha@sourceware.org>; Tue,  3 May 2022 16:47:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38CF83954433
Received: by mail-pj1-x102f.google.com with SMTP id
 iq2-20020a17090afb4200b001d93cf33ae9so2759999pjb.5
 for <libc-alpha@sourceware.org>; Tue, 03 May 2022 09:47:32 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=dOxawG6q1C1kyF1IE2LBU2qPlu4+ZxqcLfAcPK0+UJs=;
 b=EZhNk2dOunFeiRlMG7ZkH4c2rz60gKORQg6Npfs9ji7nzxpekck4CcVqHY53RzskAA
 zn9KS2vI5oQ1K7OdQsM+zo4fFvf1Mc6GCNlPTj0+Me+qaradyuDvMXywMrMsMj/DyWPr
 ns2/fv9soPRJli9ztqz9flMNjD0M8K63GoE8+QBY9gORn99tBqY5SaKS/ESySdjsjxge
 6gaFgj6zUS5KbpXeSbAdp6mUA9zvOolTge1d7W8oxwzfYemLT6sGjhp4ih6RHOIBr+PE
 TcT75vkLX+8cr7AZb48nWg+G60JGmFIm/WtM8zPpQNjAU2o5cMNaw5z+qo9NocCSPElv
 iwUg==
X-Gm-Message-State: AOAM533QjkeDiz8wFj3pdQIqhbnmS3IfWSySVsyi5nvHhHru/bO1feP0
 pIeTQ5TxslDYKHycLQTI1VGDVpY1+VNMsvQxFil/M3ni29I=
X-Google-Smtp-Source: ABdhPJwXFvqMRplpAMFvdy0Y+peo/YQyGLAbK1QERmdVSjPQUKssXNa4XZKEQZElAdAof0dY5SyBnoGl+lP9UQul0qQ=
X-Received: by 2002:a17:902:8f8d:b0:15b:7b98:22e6 with SMTP id
 z13-20020a1709028f8d00b0015b7b9822e6mr17227533plo.102.1651596451236; Tue, 03
 May 2022 09:47:31 -0700 (PDT)
MIME-Version: 1.0
References: <cover.1651518694.git.fweimer@redhat.com>
 <7a6a51b346a81484046ba392a9854a88568a92aa.1651518694.git.fweimer@redhat.com>
 <CAMe9rOpdARCeL7RoDXqYYBYA2dHS3HEHr0Lu_RN7ioO2wyYOwQ@mail.gmail.com>
 <87ilqn4spx.fsf@oldenburg.str.redhat.com>
 <CAMe9rOqp8YAy5Xopm8++s0L=UfgVssqDz7FG4TTydDpN5hoU4Q@mail.gmail.com>
 <877d734qne.fsf@oldenburg.str.redhat.com>
 <87bkwfxkhg.fsf@oldenburg.str.redhat.com>
 <CAMe9rOo3iPYVT0F2mGkrSht13KDt_Hm9TXD+8EQSe0L7gdrwBw@mail.gmail.com>
 <87levifvwm.fsf@oldenburg.str.redhat.com>
 <CAMe9rOrMuS8RgAFat9DYy3FGFDM9keHigRvbxfu0yoE0LGK6Eg@mail.gmail.com>
 <87h766ftx0.fsf@oldenburg.str.redhat.com>
In-Reply-To: <87h766ftx0.fsf@oldenburg.str.redhat.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 3 May 2022 09:46:55 -0700
Message-ID: <CAMe9rOqxavjZ=aA2Cfvd-og6tPCW8PuX668qG4thGVo+dG3xcA@mail.gmail.com>
Subject: Re: [PATCH 1/5] Linux: Implement a useful version of _startup_fatal
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3019.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 03 May 2022 16:47:33 -0000

On Tue, May 3, 2022 at 9:44 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu:
>
> > On Tue, May 3, 2022 at 9:01 AM Florian Weimer <fweimer@redhat.com> wrote:
> >>
> >> * H. J. Lu:
> >>
> >> > The startup codes can't use cancellation before it is ready.  Do we need to
> >> > check SHARED in this case?
> >>
> >> I think __libc_fatal shouldn't be a cancellation point.  That's not
> >> really related to SHARED.
> >
> > Should we define _startup_fatal unconditionally and always define
> > I386_USE_SYSENTER as 0 for i386 so that _startup_fatal can be
> > used safely during startup?
>
> Hmm.  Isn't that what my patch does?
>

Your patch still checks BUILD_PIE_DEFAULT and SHARED.

-- 
H.J.