From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id 573A3385DC39 for ; Mon, 3 May 2021 21:00:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 573A3385DC39 Received: by mail-oi1-x22a.google.com with SMTP id m13so6688697oiw.13 for ; Mon, 03 May 2021 14:00:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SNNvDlNzVSuO6IyPTaRS54FGapIIN9etcz/EDAH561M=; b=sJmCiUcJh8M2leut/55Hrgxfif/8tobJ5uiDaioV/YBhB2GXXdhwfsUMNbDGaAh/lk COg3y7/HeiTQw+c7QyPVCnhJC5eeJ33eUXUUrvs3sw6zGIliIP5HPRvoC2RClRnzO3ru PlyI6IHItkVM2dOBYVS7Y40i8Its3L7x45jpv2MIp3AbZcq3nMDf/YwGvMQwWZEpbTjS qPw2YpSicFrvTTtyGBJImP4ENdtGAhp/LiIyVp6CTJmclZIDcAXnTLOyHOWNUu8Asjq+ jrSR0U8TAu+OWaZIJFBco+FIghKY66c5eVxOJ79noNH8mMKkvrA9DnpwBZP+7UssSA6F Pw5Q== X-Gm-Message-State: AOAM5316JmNor0elgUHgsYfXhtZTEccgNFFP/nFUIEORXYczfCNZWxKO e875YvLv/UbNYFaod3nDO7u1SqKykAYLUECUg6B47c/yCyHc+w== X-Google-Smtp-Source: ABdhPJzSq2l047LXXciMBWOYfnMC+68jVKSqGWDoSbfb18C+w9tm9cBLyYxWsmz+pNxTHlU7YOv8J57oOJ3qfbE7hck= X-Received: by 2002:a05:6808:2d0:: with SMTP id a16mr14858232oid.116.1620075609759; Mon, 03 May 2021 14:00:09 -0700 (PDT) MIME-Version: 1.0 References: <20210503084435.160548-1-goldstein.w.n@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Mon, 3 May 2021 13:59:33 -0700 Message-ID: Subject: Re: [PATCH v1 1/3] Bench: Expand bench-memchr.c To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3034.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 May 2021 21:00:11 -0000 On Mon, May 3, 2021 at 12:52 PM Noah Goldstein wrote: > > On Mon, May 3, 2021 at 1:18 PM H.J. Lu wrote: > > > > On Mon, May 3, 2021 at 1:45 AM Noah Goldstein wrote: > > > > > > No bug. This commit adds some additional cases for bench-memchr.c > > > including testing medium sizes and testing short length with both an > > > inbound match and out of bound match. > > > > > > Signed-off-by: Noah Goldstein > > > --- > > > benchtests/bench-memchr.c | 13 +++++++++++++ > > > 1 file changed, 13 insertions(+) > > > > > > diff --git a/benchtests/bench-memchr.c b/benchtests/bench-memchr.c > > > index f5ced9d80d..5573f93312 100644 > > > --- a/benchtests/bench-memchr.c > > > +++ b/benchtests/bench-memchr.c > > > @@ -135,12 +135,25 @@ test_main (void) > > > do_test (i, i, 256, 0); > > > #endif > > > } > > > + for (i = 1; i < 8; ++i) > > > + { > > > + do_test (i, i << 5, 192, 23); > > > + do_test (i, i << 5, 192, 0); > > > + do_test (i, i << 5, 256, 23); > > > + do_test (i, i << 5, 256, 0); > > > + do_test (i, i << 5, 512, 23); > > > + do_test (i, i << 5, 512, 0); > > > + } > > > for (i = 1; i < 32; ++i) > > > { > > > do_test (0, i, i + 1, 23); > > > do_test (0, i, i + 1, 0); > > > do_test (i, i, i + 1, 23); > > > do_test (i, i, i + 1, 0); > > > + do_test (0, i, i - 1, 23); > > > + do_test (0, i, i - 1, 0); > > > + do_test (i, i, i - 1, 23); > > > + do_test (i, i, i - 1, 0); > > > #ifdef USE_AS_MEMRCHR > > > /* Also test the position close to the beginning for memrchr. */ > > > do_test (0, 1, i + 1, 23); > > > -- > > > 2.29.2 > > > > > > > LGTM. I will check it in for you. > > Thanks! > > > > > BTW, can you apply an account on sourceware.org: > > > > https://sourceware.org/ > > > > so that you can push your commits directly? You can put me down > > as your sponsor. > > Done. Are there any wikis / manuals on how to properly use write access? https://sourceware.org/glibc/wiki/HomePage has a lot of good information. > All I'm finding are resources on how to obtain it. > > > > > Thanks. > > > > -- > > H.J. -- H.J.