From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by sourceware.org (Postfix) with ESMTPS id 2E7AB3857000 for ; Tue, 9 Aug 2022 19:06:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2E7AB3857000 Received: by mail-qt1-x831.google.com with SMTP id j17so4740778qtp.12 for ; Tue, 09 Aug 2022 12:06:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=EofL4URGRJuy7jpRo3aQR8tzHjabo16dzA8hzLe8SfU=; b=5hLbt5hT4IjdssFz2yIuYrHzxKWQC+o3ePq6Vw0YeITnYXJSDXdDAsA9iZMNM6TLq9 OSoM607PyR8r6byjlytgIK/vr1A+HbbHYuijkR0ER1mRZYszdLqadSSUiS7cqaGWpHSP +vxzfDI8Xxid9kf5POZVOrf75GWLnjEFkTh3FHbrpsSt0FTv2o1+PGC65/9gMIzaHiq8 xoT9f/veo7hXgfkoLTkmBJGyXTapikNyT7Ky1KZgQjQ5zvYE+j3N1ZYhQOtx3hKzGHnw azaARynk+jOefUQGbx3v09X+n46Utkg+j5UjxGpjXpuYrTV+vEEo1dsXhV4Zf3/aHibT 6HbA== X-Gm-Message-State: ACgBeo2JjLWAXcEr3Z2Y/iAejtChRS7QBHxMSWo4jlY3UORBLRKQhVja p9lqHxRCSRO7AixlrOcYDPK9YIne10RR21I5akc= X-Google-Smtp-Source: AA6agR5Uh45/91WrjaTYS2ZvoGRE2YH5MSL1QovqjXcO4VqD/JHOmNBfe/vC7R9Rd6AVcIqJ40g4o07NYc0lHSIn1ho= X-Received: by 2002:ac8:7f02:0:b0:342:fdf7:b667 with SMTP id f2-20020ac87f02000000b00342fdf7b667mr7296342qtk.437.1660072009533; Tue, 09 Aug 2022 12:06:49 -0700 (PDT) MIME-Version: 1.0 References: <20220808200021.763123-1-adhemerval.zanella@linaro.org> <8edb1934-df86-6956-b90c-16032ff67df9@linaro.org> <9e01cc4b-7acd-5719-6615-8fb3cb6bf80b@linaro.org> In-Reply-To: <9e01cc4b-7acd-5719-6615-8fb3cb6bf80b@linaro.org> From: "H.J. Lu" Date: Tue, 9 Aug 2022 12:06:13 -0700 Message-ID: Subject: Re: [PATCH] elf: Remove -fno-tree-loop-distribute-patterns usage on dl-support To: Adhemerval Zanella Netto Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3018.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Aug 2022 19:06:53 -0000 On Tue, Aug 9, 2022 at 11:48 AM Adhemerval Zanella Netto wrote: > > > > On 09/08/22 15:31, H.J. Lu wrote: > > On Tue, Aug 9, 2022 at 5:11 AM Adhemerval Zanella Netto > > wrote: > >> > >> > >> > >> On 08/08/22 19:16, H.J. Lu wrote: > >> > >>>> --- a/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S > >>>> +++ b/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S > >>>> @@ -44,4 +44,7 @@ > >>>> > >>>> # define USE_LESS_VEC_MASK_STORE 1 > >>>> # include "memset-vec-unaligned-erms.S" > >>>> +# if !defined NO_MULTIARCH && MINIMUM_X86_ISA_LEVEL >= 4 > >>>> +strong_alias (__memset_evex_unaligned, __memset_generic) > >>>> +# endif > >>>> #endif > >>> > >>> This will define 2 __memset_generic for -march=x86-64-v4. > >> > >> Are you sure? Check with a x86_64 build with -march=x86-64-v4 I am seeing: > >> > >> $ readelf -Ws string/memset*.os | grep -w __memset_generic | wc -l > >> 1 > >> > >> And it is indeed provided only by string/memset-evex-unaligned-erms.os. > > > > You are right. Since dl-symbol-hacks.h defines memset to an alias, > > should it be moved to sysdes/generic and each arch can provide a > > suitable alias? > > The dl-symbol-hacks.h is meant to be used solely by loader code (that's > why I have added to elf/), but I don't have a strong preference. The default should be no alias. Only IFUNC targets need to define a proper alias. -- H.J.