From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id D558B3858416 for ; Thu, 21 Oct 2021 22:58:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D558B3858416 Received: by mail-pf1-x430.google.com with SMTP id x66so1946647pfx.13 for ; Thu, 21 Oct 2021 15:58:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RwBjDzJ+BWMwT0rGsuD+iWXQ4ujnR74iMcnilMc31/M=; b=31LUbJwz4D0hIvbgAjGBC7n9zuos/2AW/sCW6dgFsN9K606DdFqTOMyovkb3nWNGzI ZWH3Z27xnb8wfnLb24Tc+1Z0v9pM9/pswf6VjmYSI+ZajfEmu/Zp7m/szsGAX4DgPI40 2dbUWyeYS/fvoadrNAYbbin/Nt9MZIhxhbJU/+zuCBWAZU4cbpQxp2aAsIo7q/Utq/Sw hijWgNMJ8LotNBTqn8FNyELWc8Nvf3dfY+I9gYIH3lid07eB0p5e8wKTSJRXkOB4eE31 N/fW6DmRewYAKmrH7HpQyTV83bG2SCENUgn/3O8HEIJB3TLzHriAn//obIFcDgAAFg9K 9sBw== X-Gm-Message-State: AOAM533RkQshGLKiEWsBds7KXVlXSs1kD5opxL1F/lAoU4OSftvKCGIG RSmrbbjDEgryVXhfhsQBReVbRAXQ5YWneHib+U0= X-Google-Smtp-Source: ABdhPJxM4ZqXYiyShvA8xQcPzX2sd3yFOz9zL5KtnzyNxxtA3VWbkSCDDgj17gL5lKtpJuzM6fs2OfLAQIOkf3uC50E= X-Received: by 2002:a63:b51d:: with SMTP id y29mr6658598pge.75.1634857081959; Thu, 21 Oct 2021 15:58:01 -0700 (PDT) MIME-Version: 1.0 References: <20210927203827.2852935-1-goldstein.w.n@gmail.com> <20211021223850.415607-1-goldstein.w.n@gmail.com> <20211021223850.415607-3-goldstein.w.n@gmail.com> In-Reply-To: <20211021223850.415607-3-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Thu, 21 Oct 2021 15:57:26 -0700 Message-ID: Subject: Re: [PATCH v8 3/3] String: Add tests for __memcmpeq To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3023.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2021 22:58:04 -0000 On Thu, Oct 21, 2021 at 3:40 PM Noah Goldstein wrote: > > No bug. > > This commit adds tests for the new function __memcmpeq. The new tests > use the existing tests in 'test-memcmp.c' but relax the result > requirement to only check for zero or non-zero returns. > > All string tests include test-memcmpeq are passing. > --- > Note at the momement for test-memcmpeq.c the > tests only appear to do the generic versions. > > For example on x86_64 the output of test-memcmpeq.out is: > > > ``` > __memcmpeq simple_memcmp > ``` > > whereas test-memcmp.out is: > > ``` > simple_memcmp __memcmp_avx2_movbe > __memcmp_evex_movbe __memcmp_sse4_1 __memcmp_ssse3 __memcmp_sse2 > ``` > > So the test is not going through all available ifuncs. I'm not > sure if this is expected or indicates a bug in the previous > patches adding support for __memcmpeq. > This doesn't look right. If __memcmpeq is a true alias of memcmp, you should only have simple_memcmpeq and __memcmpeq. -- H.J.