public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] i386: Remove unused file sysdeps/unix/i386/sysdep.S
@ 2020-05-28  9:11 Florian Weimer
  2020-05-28 11:32 ` H.J. Lu
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer @ 2020-05-28  9:11 UTC (permalink / raw)
  To: libc-alpha

Linux overrides this file via sysdeps/unix/sysv/linux/i386/sysdep.c.
Hurd does not have sysdeps/unix/i386 on its search path, so it uses
csu/sysdep.c instead.

---
 sysdeps/unix/i386/sysdep.S | 64 ----------------------------------------------
 1 file changed, 64 deletions(-)

diff --git a/sysdeps/unix/i386/sysdep.S b/sysdeps/unix/i386/sysdep.S
deleted file mode 100644
index 60c4c604ca..0000000000
--- a/sysdeps/unix/i386/sysdep.S
+++ /dev/null
@@ -1,64 +0,0 @@
-/* Copyright (C) 1991-2020 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <https://www.gnu.org/licenses/>.  */
-
-#include <sysdep.h>
-#define _ERRNO_H
-#include <bits/errno.h>
-
-#if IS_IN (rtld)
-# include <dl-sysdep.h>		/* Defines RTLD_PRIVATE_ERRNO.  */
-#endif
-
-.globl C_SYMBOL_NAME(errno)
-.globl syscall_error
-
-__syscall_error:
-#if defined (EWOULDBLOCK_sys) && EWOULDBLOCK_sys != EAGAIN
-	/* We translate the system's EWOULDBLOCK error into EAGAIN.
-	   The GNU C library always defines EWOULDBLOCK==EAGAIN.
-	   EWOULDBLOCK_sys is the original number.  */
-	cmpl $EWOULDBLOCK_sys, %eax /* Is it the old EWOULDBLOCK?  */
-	jne notb		/* Branch if not.  */
-	movl $EAGAIN, %eax	/* Yes; translate it to EAGAIN.  */
-notb:
-#endif
-#ifndef	PIC
-# ifndef NO_TLS_DIRECT_SEG_REFS
-	movl %eax, %gs:C_SYMBOL_NAME(errno@NTPOFF)
-# else
-	movl %gs:0, %ecx
-	movl %eax, C_SYMBOL_NAME(errno@NTPOFF)(%ecx)
-# endif
-#else
-	/* The caller has pushed %ebx and then set it up to
-	   point to the GOT before calling us through the PLT.  */
-	movl C_SYMBOL_NAME(errno@GOTNTPOFF)(%ebx), %ecx
-
-	/* Pop %ebx value saved before jumping here.  */
-	popl %ebx
-# ifndef NO_TLS_DIRECT_SEG_REFS
-	addl %gs:0, %ecx
-	movl %eax, (%ecx)
-# else
-	movl %eax, %gs:0(%ecx)
-# endif
-#endif
-	movl $-1, %eax
-	ret
-
-#undef	__syscall_error
-END (__syscall_error)


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] i386: Remove unused file sysdeps/unix/i386/sysdep.S
  2020-05-28  9:11 [PATCH] i386: Remove unused file sysdeps/unix/i386/sysdep.S Florian Weimer
@ 2020-05-28 11:32 ` H.J. Lu
  0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2020-05-28 11:32 UTC (permalink / raw)
  To: Florian Weimer; +Cc: GNU C Library

On Thu, May 28, 2020 at 2:11 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> Linux overrides this file via sysdeps/unix/sysv/linux/i386/sysdep.c.
> Hurd does not have sysdeps/unix/i386 on its search path, so it uses
> csu/sysdep.c instead.
>
> ---
>  sysdeps/unix/i386/sysdep.S | 64 ----------------------------------------------
>  1 file changed, 64 deletions(-)

LGTM.

Thanks.

-- 
H.J.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-28 11:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28  9:11 [PATCH] i386: Remove unused file sysdeps/unix/i386/sysdep.S Florian Weimer
2020-05-28 11:32 ` H.J. Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).