From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94668 invoked by alias); 7 Dec 2016 21:50:06 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 94642 invoked by uid 89); 7 Dec 2016 21:50:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=hjltoolsgmailcom, hjl.tools@gmail.com, S, capital X-HELO: mail-qk0-f193.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uKpC8Gfchlk/PXSIbFHgmX0STmsugxmd2P8Sy65koEQ=; b=AzVifc+x+FkGui2SD/2sIAaa4NDPAa/n5vOPvyhd/XdkBUrGyI/HoSH4LTEF4HtXsL uAOA1d5vJBqKGIvRvGFadXF3pscYVqP0sKF5zMi01koQO/Mf/wrBTe1CIhivKALEZGtr sJEAGG2M+iVYbxzzOJmaK3MKkKsXFHGiaemN9nOINRbFV/Je8RkOEO3kyGNmXsq0X1V5 Wuq5NLy5M0DLt3Yzwlcis0EwOZBvEoW936cELUKw9Bf99j90azfTXMXqXS7Qtx19tqmD VTg6rGoUvV2UDanVzpJ1qlBC28+1U3JI10DOeHwCud3U2tbbJU64Gk5ToWrFmORHWFmY bdTg== X-Gm-Message-State: AKaTC010GnKpeinGTEvu/tVFoG+WqThc0w0RdIo7djZnY2HVt4gMN2DKGlYvW79QtZWY4UyT8nc0dZkK8bpcug== X-Received: by 10.55.94.135 with SMTP id s129mr58434162qkb.124.1481147394260; Wed, 07 Dec 2016 13:49:54 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: From: "H.J. Lu" Date: Wed, 07 Dec 2016 21:50:00 -0000 Message-ID: Subject: Re: [PATCH] Install libm.a as linker script [BZ #20539] To: Andrew Senkevich Cc: Andreas Schwab , libc-alpha Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-12/txt/msg00258.txt.bz2 On Wed, Dec 7, 2016 at 12:03 PM, Andrew Senkevich wrote: > 2016-12-07 19:21 GMT+03:00 H.J. Lu : >> On Wed, Dec 7, 2016 at 2:34 AM, Andrew Senkevich >> wrote: >>> 2016-12-07 0:48 GMT+03:00 H.J. Lu : >>>> On Tue, Dec 6, 2016 at 7:49 AM, Andrew Senkevich >>>> wrote: >>>>> 2016-12-06 18:21 GMT+03:00 Andreas Schwab : >>>>>> On Dez 06 2016, Andrew Senkevich wrote: >>>>>> >>>>>>> 2016-12-06 17:17 GMT+03:00 Andreas Schwab : >>>>>>>> On Dez 06 2016, Andrew Senkevich wrote: >>>>>>>> >>>>>>>>> +2016-12-06 Andrew Senkevich >>>>>>>>> + >>>>>>>>> + [BZ #20539] >>>>>>>>> + * math/Makefile (install-lib-ldscripts): added libm.a. >>>>>>>>> + ($(inst_libdir)/libm.a): added rule for installation as linker script. >>>>>>>>> + * Makerules (install-lib.a): filter out install-lib-ldscripts. >>>>>>>> >>>>>>>> ChangeLog entries should be in present tense, and written as full >>>>>>>> sentences. >>>>>>> >>>>>>> Which sentence is not full? >>>>>> >>>>>> Full sentences start with a capital. >>>>> >>>>> Oh yes of course, fixed. >>>>> >>>>> >>>>> -- >>>>> WBR, >>>>> Andrew >>>> >>>> diff --git a/Makerules b/Makerules >>>> index e865782..573c074 100644 >>>> --- a/Makerules >>>> +++ b/Makerules >>>> @@ -1190,7 +1190,8 @@ $(addprefix $(inst_sbindir)/,$(install-sbin)): \ >>>> $(do-install-program) >>>> endif >>>> ifdef install-lib >>>> -install-lib.a := $(filter lib%.a,$(install-lib)) >>>> +install-lib.a := $(filter-out libm.a,$(filter lib%.a,$(install-lib))) >>>> +install-lib.a := $(filter-out $(install-lib-ldscripts),$(install-lib.a)) >>>> >>>> Need to filler out libm.a separately since it is in install-lib-ldscripts >>>> already. >>> >>> Oh surely, attached. >>> >>> >>> -- >>> WBR, >>> Andrew >> >> diff --git a/math/Makefile b/math/Makefile >> index 848b093..77031b1 100644 >> --- a/math/Makefile >> +++ b/math/Makefile >> @@ -128,10 +128,10 @@ generated += $(foreach s,.c .S,$(call >> type-foreach, $(calls:s_%=m_%$(s)))) >> routines = $(call type-foreach, $(calls)) >> >> ifeq ($(build-mathvec),yes) >> -# We need to install libm.so as linker script >> -# for more comfortable use of vector math library. >> -install-lib-ldscripts := libm.so >> -install_subdir: $(inst_libdir)/libm.so >> +# We need to install libm.so and libm.a as linker scripts >> +# for transparent use of vector math library. >> +install-lib-ldscripts := libm.so libm.a >> +install-others: $(inst_libdir)/libm.so $(inst_libdir)/libm.a >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> >> Here is install-others. >> >> $(inst_libdir)/libm.so: $(common-objpfx)format.lds \ >> $(libm) \ >> $(libmvec) \ >> @@ -142,6 +142,18 @@ $(inst_libdir)/libm.so: $(common-objpfx)format.lds \ >> 'AS_NEEDED ( $(libdir)/libmvec_nonshared.a >> $(slibdir)/libmvec.so$(libmvec.so-version) ) )' \ >> ) > $@.new >> mv -f $@.new $@ >> + >> +install-others = $(inst_libdir)/libm.a >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> >> Is this needed? > > Indeed not needed. Tested with attached patch. > > Please update ChangeLog entry: install_subdir is removed and install-others is added in math/Makefile. Otherwise, it looks good to me. Thanks. -- H.J.