On Tue, Jan 4, 2022 at 6:36 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Andreas Schwab:
>
> > On Jan 04 2022, H.J. Lu wrote:
> >
> >> On Tue, Jan 4, 2022 at 12:38 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
> >>>
> >>> On Jan 03 2022, H.J. Lu via Libc-alpha wrote:
> >>>
> >>> > +tests-cxx = \
> >>> > +  tst-dlopen-nodelete-reloc \
> >>> > +  tst-nodelete \
> >>> > +  tst-unique3 \
> >>> > +  tst-unique4 \
> >>> > +
> >>>
> >>> > +  vismod1 \
> >>> > +  vismod2 \
> >>> > +  vismod3 \
> >>> > +
> >>>
> >>> > +  tst-unique3lib \
> >>> > +  tst-unique3lib2 \
> >>> > +  tst-unique4lib \
> >>> > +
> >>> > +modules-names += \
> >>> > +  $(if $(CXX),$(modules-names-cxx)) \
> >>> > +  $(modules-execstack-$(have-z-execstack)) \
> >>> > +  $(tst-tls-many-dynamic-modules) \
> >>> > +  $(tst-tls-many-dynamic-modules-dep) \
> >>> > +  $(tst-tls-many-dynamic-modules-dep-bad) \
> >>> > +  $(tlsmod17a-modules) \
> >>> > +  $(tlsmod18a-modules) \
> >>>
> >>>
> >>> Trailing backslashes are no good.
> >>
> >> It was added so that only one line is needed when appending
> >> to the list.
> >
> > The blank lines can easily get lost.
>
> That's why I use comments, so:
>
> +modules-names += \
> +  $(if $(CXX),$(modules-names-cxx)) \
> +  $(modules-execstack-$(have-z-execstack)) \
> +  $(tst-tls-many-dynamic-modules) \
> +  $(tst-tls-many-dynamic-modules-dep) \
> +  $(tst-tls-many-dynamic-modules-dep-bad) \
> +  $(tlsmod17a-modules) \
> +  $(tlsmod18a-modules) \
> +  # modules-names

Good suggestion.  I am checking in this.

Thanks.

-- 
H.J.