From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 6782F3858405 for ; Tue, 4 Jan 2022 15:01:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6782F3858405 Received: by mail-pf1-x42f.google.com with SMTP id v13so32450291pfi.3 for ; Tue, 04 Jan 2022 07:01:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HnxWux/dMxZKlBc9FFZl2uLU5WiL4oTWiW3SS9FFMU0=; b=sTmlAOILOUNAxJR9Bmbxc6Or/Y+M5CiU4Y3zDAzozpsU99jW9tfklOTuqxVArF7Riy LAFzD0UfQw5x6ZKGe7JoIoZN0D07DaxMgcKGYiljni8jOwFLx1hCGe1HtvioeM/1hJpN HOLXGyGuB3U2kF9+qYe3v8QI1S+DLvkBnCT2JYFJtrNUp80ZY/FOpfvGluodf6GP5kAz ekIcct29Cl2qnVd8rPMiOTNhvxa0GyWp4IYA4dTXFQXxv5JTgQ1DxINSs4/nLYB0Mbcg dkVPxH7bvWIZYLp7s14bLH8oBiMgb1uzidU9sqT3ML48q5br4bdUMHUSd4BSt7BzRZo9 fFDw== X-Gm-Message-State: AOAM531v2QnVLuhykOHXlMDAKUaJxE1SpL42Tjm9uufU9q1CfUUPG58y VBNyJFon7RX6ZLjVsR7CTpJsONk8vr7wKcMqSLU= X-Google-Smtp-Source: ABdhPJwwBo3n1pGMBBm88Ff5NxsIu3rTNiBKqQ9170vTDlN+Uhd/v+SKOnShC6+gtsrLVKj5ak4CvJ1a8RWHCgbyYfo= X-Received: by 2002:a63:6116:: with SMTP id v22mr45193034pgb.381.1641308476255; Tue, 04 Jan 2022 07:01:16 -0800 (PST) MIME-Version: 1.0 References: <20220103233243.2031364-1-hjl.tools@gmail.com> <87zgob3nh1.fsf@igel.home> <87tuej3702.fsf@igel.home> <87r19nftzb.fsf@oldenburg.str.redhat.com> In-Reply-To: <87r19nftzb.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Tue, 4 Jan 2022 07:00:40 -0800 Message-ID: Subject: [PATCH] elf: Add a comment after trailing backslashes To: Florian Weimer Cc: Andreas Schwab , "H.J. Lu via Libc-alpha" Content-Type: multipart/mixed; boundary="000000000000b1edae05d4c2e84b" X-Spam-Status: No, score=-3027.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2022 15:01:19 -0000 --000000000000b1edae05d4c2e84b Content-Type: text/plain; charset="UTF-8" On Tue, Jan 4, 2022 at 6:36 AM Florian Weimer wrote: > > * Andreas Schwab: > > > On Jan 04 2022, H.J. Lu wrote: > > > >> On Tue, Jan 4, 2022 at 12:38 AM Andreas Schwab wrote: > >>> > >>> On Jan 03 2022, H.J. Lu via Libc-alpha wrote: > >>> > >>> > +tests-cxx = \ > >>> > + tst-dlopen-nodelete-reloc \ > >>> > + tst-nodelete \ > >>> > + tst-unique3 \ > >>> > + tst-unique4 \ > >>> > + > >>> > >>> > + vismod1 \ > >>> > + vismod2 \ > >>> > + vismod3 \ > >>> > + > >>> > >>> > + tst-unique3lib \ > >>> > + tst-unique3lib2 \ > >>> > + tst-unique4lib \ > >>> > + > >>> > +modules-names += \ > >>> > + $(if $(CXX),$(modules-names-cxx)) \ > >>> > + $(modules-execstack-$(have-z-execstack)) \ > >>> > + $(tst-tls-many-dynamic-modules) \ > >>> > + $(tst-tls-many-dynamic-modules-dep) \ > >>> > + $(tst-tls-many-dynamic-modules-dep-bad) \ > >>> > + $(tlsmod17a-modules) \ > >>> > + $(tlsmod18a-modules) \ > >>> > >>> > >>> Trailing backslashes are no good. > >> > >> It was added so that only one line is needed when appending > >> to the list. > > > > The blank lines can easily get lost. > > That's why I use comments, so: > > +modules-names += \ > + $(if $(CXX),$(modules-names-cxx)) \ > + $(modules-execstack-$(have-z-execstack)) \ > + $(tst-tls-many-dynamic-modules) \ > + $(tst-tls-many-dynamic-modules-dep) \ > + $(tst-tls-many-dynamic-modules-dep-bad) \ > + $(tlsmod17a-modules) \ > + $(tlsmod18a-modules) \ > + # modules-names Good suggestion. I am checking in this. Thanks. -- H.J. --000000000000b1edae05d4c2e84b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-elf-Add-a-comment-after-trailing-backslashes.patch" Content-Disposition: attachment; filename="0001-elf-Add-a-comment-after-trailing-backslashes.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ky08n0tr0 RnJvbSBmNGY3MGMyODk1ZTNkMzI1MTg4YTQyYzEwZWI3YmI0MzM1YmU2NzczIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IFR1ZSwgNCBKYW4gMjAyMiAwNjo1ODozNCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIGVsZjogQWRk IGEgY29tbWVudCBhZnRlciB0cmFpbGluZyBiYWNrc2xhc2hlcwoKLS0tCiBlbGYvTWFrZWZpbGUg fCA0ICsrKysKIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9l bGYvTWFrZWZpbGUgYi9lbGYvTWFrZWZpbGUKaW5kZXggOGViN2U2ZTVkOS4uYjg2ZDExNmJlOSAx MDA2NDQKLS0tIGEvZWxmL01ha2VmaWxlCisrKyBiL2VsZi9NYWtlZmlsZQpAQCAtMzMzLDYgKzMz Myw3IEBAIHRlc3RzLWN4eCA9IFwKICAgdHN0LW5vZGVsZXRlIFwKICAgdHN0LXVuaXF1ZTMgXAog ICB0c3QtdW5pcXVlNCBcCisjIHRlc3RzLWN4eAogCiB0ZXN0cyArPSAkKGlmICQoQ1hYKSwkKHRl c3RzLWN4eCkpCiB0ZXN0cy1pbnRlcm5hbCArPSBsb2FkdGVzdCB1bmxvYWQgdW5sb2FkMiBjaXJj bGVsb2FkMSBcCkBAIC02MjYsNiArNjI3LDcgQEAgbW9kdWxlcy1uYW1lcyA9IFwKICAgdmlzbW9k MSBcCiAgIHZpc21vZDIgXAogICB2aXNtb2QzIFwKKyMgbW9kdWxlcy1uYW1lcwogCiBtb2R1bGVz LW5hbWVzLWN4eCA9IFwKICAgdHN0LWRsb3Blbi1ub2RlbGV0ZS1yZWxvYy1tb2QxIFwKQEAgLTY1 MSw2ICs2NTMsNyBAQCBtb2R1bGVzLW5hbWVzLWN4eCA9IFwKICAgdHN0LXVuaXF1ZTNsaWIgXAog ICB0c3QtdW5pcXVlM2xpYjIgXAogICB0c3QtdW5pcXVlNGxpYiBcCisjIG1vZHVsZXMtbmFtZXMt Y3h4CiAKIG1vZHVsZXMtbmFtZXMgKz0gXAogICAkKGlmICQoQ1hYKSwkKG1vZHVsZXMtbmFtZXMt Y3h4KSkgXApAQCAtNjYwLDYgKzY2Myw3IEBAIG1vZHVsZXMtbmFtZXMgKz0gXAogICAkKHRzdC10 bHMtbWFueS1keW5hbWljLW1vZHVsZXMtZGVwLWJhZCkgXAogICAkKHRsc21vZDE3YS1tb2R1bGVz KSBcCiAgICQodGxzbW9kMThhLW1vZHVsZXMpIFwKKyMgbW9kdWxlcy1uYW1lcwogCiAjIE1vc3Qg bW9kdWxlcyBidWlsZCB3aXRoIF9JU09NQUMgZGVmaW5lZCwgYnV0IHRob3NlIGZpbHRlcmVkIG91 dAogIyBkZXBlbmQgb24gaW50ZXJuYWwgaGVhZGVycy4KLS0gCjIuMzMuMQoK --000000000000b1edae05d4c2e84b--