From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by sourceware.org (Postfix) with ESMTPS id E1D3C385842F for ; Sat, 12 Feb 2022 15:51:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E1D3C385842F Received: by mail-pj1-x1033.google.com with SMTP id v13-20020a17090ac90d00b001b87bc106bdso14727726pjt.4 for ; Sat, 12 Feb 2022 07:51:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=6SaMCUQ6cz7MRUSEloKFGMW9FR4pkJ6913EaexBXmLM=; b=acySZC4fzJa/iHy/i8Z2t0bPn8PHg/foS56K6UKzzJEY96IwcW6/PeXMxkDavPITnm iFcbhMnT+QuKdnolX3phUZx3DNEkBfwnck9qupBtUVBzMSbpBxLaARGltX73s3KPXxZH sHXWYXhD85mIg+0gGXJcJhxu8AInpMUi2tyn5YFq4+QWi/UoXxfSf2d9znOY9zDdVDe+ tG0yb4W6oYtLulgCjGrT+If2EJghUtiG4Vgk9Bo2QDpN+dmvhA128gkGdNVBBI0uxmH9 85Y3xlDBxzKfyb26rB4WyCFD7Io/Osup92HlXDE1Kgc0xWURdNhJOd97KN/+EIPUUesT hMMw== X-Gm-Message-State: AOAM5308R+g88MZ0hOHDa4iUCKhaSz8YxFVGxnjZNeo3YDWgxULMppBt EkBJ+lETLbvX5xinfJ2DdcyQiWkr8BZyEafd0k1os9aM X-Google-Smtp-Source: ABdhPJy7tCjC9688UySvVmt0CJ5jjO+SHGNAsno6OcgzNQ84B+95v44cMOVc7b+BKrXJUxCKDnbgGrYjhxzGhri1fcw= X-Received: by 2002:a17:90b:3845:: with SMTP id nl5mr5710286pjb.143.1644681067870; Sat, 12 Feb 2022 07:51:07 -0800 (PST) MIME-Version: 1.0 References: <20220126202833.1810866-1-hjl.tools@gmail.com> In-Reply-To: <20220126202833.1810866-1-hjl.tools@gmail.com> From: "H.J. Lu" Date: Sat, 12 Feb 2022 07:50:32 -0800 Message-ID: Subject: Re: [PATCH] x86: Don't check PTWRITE in tst-cpu-features-cpuinfo.c To: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3027.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Feb 2022 15:51:10 -0000 On Wed, Jan 26, 2022 at 12:28 PM H.J. Lu wrote: > > Don't check PTWRITE against /proc/cpuinfo since kernel doesn't report > PTWRITE in /proc/cpuinfo. > --- > sysdeps/x86/tst-cpu-features-cpuinfo.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sysdeps/x86/tst-cpu-features-cpuinfo.c b/sysdeps/x86/tst-cpu-features-cpuinfo.c > index 91a656b61d..981b2be5fd 100644 > --- a/sysdeps/x86/tst-cpu-features-cpuinfo.c > +++ b/sysdeps/x86/tst-cpu-features-cpuinfo.c > @@ -218,7 +218,10 @@ do_test (int argc, char **argv) > fails += CHECK_PROC (popcnt, POPCNT); > fails += CHECK_PROC (3dnowprefetch, PREFETCHW); > fails += CHECK_PROC (prefetchwt1, PREFETCHWT1); > +#if 0 > + /* NB: /proc/cpuinfo doesn't report this feature. */ > fails += CHECK_PROC (ptwrite, PTWRITE); > +#endif > fails += CHECK_PROC (pse, PSE); > fails += CHECK_PROC (pse36, PSE_36); > fails += CHECK_PROC (psn, PSN); > -- > 2.34.1 > I will check in this next Monday to fix the test on Intel Alder Lake. -- H.J.