public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] string: Replace = with += in CFLAGS-tst-xbzero-opt.c
@ 2017-12-11 13:18 H.J. Lu
  2017-12-11 13:33 ` Andreas Schwab
  0 siblings, 1 reply; 5+ messages in thread
From: H.J. Lu @ 2017-12-11 13:18 UTC (permalink / raw)
  To: GNU C Library

Replace = with += in CFLAGS-tst-xbzero-opt.c to allow sysdeps Makefile
to define CFLAGS-tst-xbzero-opt.c.

Any comments?

H.J.
	* string/Makefile (CFLAGS-tst-xbzero-opt.c): Replace = with +=.
---
 string/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/string/Makefile b/string/Makefile
index d7e90a38a5..618b737b13 100644
--- a/string/Makefile
+++ b/string/Makefile
@@ -75,7 +75,7 @@ CFLAGS-tst-strlen.c = -fno-builtin
 CFLAGS-stratcliff.c = -fno-builtin
 CFLAGS-test-ffs.c = -fno-builtin
 CFLAGS-tst-inlcall.c = -fno-builtin
-CFLAGS-tst-xbzero-opt.c = -O3
+CFLAGS-tst-xbzero-opt.c += -O3
 # BZ 21006: Resolve all functions but at least explicit_bzero at startup.
 # Otherwise the test fails on s390x as the memcpy in prepare_test_buffer is
 # done by loading r4 / r5 with the test_pattern and using store multiple
-- 
2.14.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] string: Replace = with += in CFLAGS-tst-xbzero-opt.c
  2017-12-11 13:18 [PATCH] string: Replace = with += in CFLAGS-tst-xbzero-opt.c H.J. Lu
@ 2017-12-11 13:33 ` Andreas Schwab
  2017-12-11 13:35   ` H.J. Lu
  0 siblings, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2017-12-11 13:33 UTC (permalink / raw)
  To: H.J. Lu; +Cc: GNU C Library, H.J. Lu

On Dez 11 2017, "H.J. Lu" <hongjiu.lu@intel.com> wrote:

> Replace = with += in CFLAGS-tst-xbzero-opt.c to allow sysdeps Makefile
> to define CFLAGS-tst-xbzero-opt.c.
>
> Any comments?
>
> H.J.
> 	* string/Makefile (CFLAGS-tst-xbzero-opt.c): Replace = with +=.

I think that should be done for all such assignments.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] string: Replace = with += in CFLAGS-tst-xbzero-opt.c
  2017-12-11 13:33 ` Andreas Schwab
@ 2017-12-11 13:35   ` H.J. Lu
  2017-12-11 13:39     ` Andreas Schwab
  0 siblings, 1 reply; 5+ messages in thread
From: H.J. Lu @ 2017-12-11 13:35 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: GNU C Library

On Mon, Dec 11, 2017 at 5:32 AM, Andreas Schwab <schwab@suse.de> wrote:
> On Dez 11 2017, "H.J. Lu" <hongjiu.lu@intel.com> wrote:
>
>> Replace = with += in CFLAGS-tst-xbzero-opt.c to allow sysdeps Makefile
>> to define CFLAGS-tst-xbzero-opt.c.
>>
>> Any comments?
>>
>> H.J.
>>       * string/Makefile (CFLAGS-tst-xbzero-opt.c): Replace = with +=.
>
> I think that should be done for all such assignments.
>

By "all", did you mean CFLAGS-xxx in */Makefile or CFLAGS-xxx in
string/Makefile?



-- 
H.J.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] string: Replace = with += in CFLAGS-tst-xbzero-opt.c
  2017-12-11 13:35   ` H.J. Lu
@ 2017-12-11 13:39     ` Andreas Schwab
  2017-12-11 16:42       ` H.J. Lu
  0 siblings, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2017-12-11 13:39 UTC (permalink / raw)
  To: H.J. Lu; +Cc: GNU C Library

On Dez 11 2017, "H.J. Lu" <hjl.tools@gmail.com> wrote:

> On Mon, Dec 11, 2017 at 5:32 AM, Andreas Schwab <schwab@suse.de> wrote:
>> On Dez 11 2017, "H.J. Lu" <hongjiu.lu@intel.com> wrote:
>>
>>> Replace = with += in CFLAGS-tst-xbzero-opt.c to allow sysdeps Makefile
>>> to define CFLAGS-tst-xbzero-opt.c.
>>>
>>> Any comments?
>>>
>>> H.J.
>>>       * string/Makefile (CFLAGS-tst-xbzero-opt.c): Replace = with +=.
>>
>> I think that should be done for all such assignments.
>>
>
> By "all", did you mean CFLAGS-xxx in */Makefile or CFLAGS-xxx in
> string/Makefile?

Everywhere, if you like to work on that.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] string: Replace = with += in CFLAGS-tst-xbzero-opt.c
  2017-12-11 13:39     ` Andreas Schwab
@ 2017-12-11 16:42       ` H.J. Lu
  0 siblings, 0 replies; 5+ messages in thread
From: H.J. Lu @ 2017-12-11 16:42 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: GNU C Library

[-- Attachment #1: Type: text/plain, Size: 816 bytes --]

On Mon, Dec 11, 2017 at 5:39 AM, Andreas Schwab <schwab@suse.de> wrote:
> On Dez 11 2017, "H.J. Lu" <hjl.tools@gmail.com> wrote:
>
>> On Mon, Dec 11, 2017 at 5:32 AM, Andreas Schwab <schwab@suse.de> wrote:
>>> On Dez 11 2017, "H.J. Lu" <hongjiu.lu@intel.com> wrote:
>>>
>>>> Replace = with += in CFLAGS-tst-xbzero-opt.c to allow sysdeps Makefile
>>>> to define CFLAGS-tst-xbzero-opt.c.
>>>>
>>>> Any comments?
>>>>
>>>> H.J.
>>>>       * string/Makefile (CFLAGS-tst-xbzero-opt.c): Replace = with +=.
>>>
>>> I think that should be done for all such assignments.
>>>
>>
>> By "all", did you mean CFLAGS-xxx in */Makefile or CFLAGS-xxx in
>> string/Makefile?
>
> Everywhere, if you like to work on that.

I am checking in this patch to cover string/Makefile.  I will submit a
separate patch for */Makefile.


-- 
H.J.

[-- Attachment #2: 0001-string-Replace-with-in-CFLAGS-xxx.c.patch --]
[-- Type: text/x-patch, Size: 2026 bytes --]

From 9f0006a8825b6f1baae948f08cdf01d1e5277e51 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Mon, 11 Dec 2017 04:18:24 -0800
Subject: [PATCH] string: Replace = with += in CFLAGS-xxx.c

Replace = with += in CFLAGS-xxx.c to allow Makefile under sysdeps to
define CFLAGS-xx.c.

	* string/Makefile (CFLAGS-inl-tester.c): Replace = with +=.
	(CFLAGS-noinl-tester.c): Likewise.
	(CFLAGS-tst-strlen.c): Likewise.
	(CFLAGS-stratcliff.c): Likewise.
	(CFLAGS-test-ffs.c): Likewise.
	(CFLAGS-tst-inlcall.c): Likewise.
	(CFLAGS-tst-xbzero-opt.c): Likewise.
	(CFLAGS-memcpy.c): Likewise.
	(CFLAGS-wordcopy.c): Likewise.
---
 string/Makefile | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/string/Makefile b/string/Makefile
index d7e90a38a5..74ba4f2f76 100644
--- a/string/Makefile
+++ b/string/Makefile
@@ -69,13 +69,13 @@ endif
 
 include ../Rules
 
-CFLAGS-inl-tester.c = -fno-builtin
-CFLAGS-noinl-tester.c = -fno-builtin
-CFLAGS-tst-strlen.c = -fno-builtin
-CFLAGS-stratcliff.c = -fno-builtin
-CFLAGS-test-ffs.c = -fno-builtin
-CFLAGS-tst-inlcall.c = -fno-builtin
-CFLAGS-tst-xbzero-opt.c = -O3
+CFLAGS-inl-tester.c += -fno-builtin
+CFLAGS-noinl-tester.c += -fno-builtin
+CFLAGS-tst-strlen.c += -fno-builtin
+CFLAGS-stratcliff.c += -fno-builtin
+CFLAGS-test-ffs.c += -fno-builtin
+CFLAGS-tst-inlcall.c += -fno-builtin
+CFLAGS-tst-xbzero-opt.c += -O3
 # BZ 21006: Resolve all functions but at least explicit_bzero at startup.
 # Otherwise the test fails on s390x as the memcpy in prepare_test_buffer is
 # done by loading r4 / r5 with the test_pattern and using store multiple
@@ -86,8 +86,8 @@ CFLAGS-tst-xbzero-opt.c = -O3
 LDFLAGS-tst-xbzero-opt = -z now
 
 # Called during TLS initialization.
-CFLAGS-memcpy.c = $(no-stack-protector)
-CFLAGS-wordcopy.c = $(no-stack-protector)
+CFLAGS-memcpy.c += $(no-stack-protector)
+CFLAGS-wordcopy.c += $(no-stack-protector)
 
 ifeq ($(run-built-tests),yes)
 $(objpfx)tst-svc-cmp.out: tst-svc.expect $(objpfx)tst-svc.out
-- 
2.14.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-12-11 16:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-11 13:18 [PATCH] string: Replace = with += in CFLAGS-tst-xbzero-opt.c H.J. Lu
2017-12-11 13:33 ` Andreas Schwab
2017-12-11 13:35   ` H.J. Lu
2017-12-11 13:39     ` Andreas Schwab
2017-12-11 16:42       ` H.J. Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).