From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by sourceware.org (Postfix) with ESMTPS id B4D853858D39 for ; Mon, 3 Apr 2023 19:02:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B4D853858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb2f.google.com with SMTP id i6so36071131ybu.8 for ; Mon, 03 Apr 2023 12:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680548569; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=erObc8aXeUQ4SchowS/WdE+uQHnisJkUn51WI4V6hUQ=; b=fVLhCMVdCMYv4jKFewd/hZyxx7Jbd76IB/RBHSVWMTRahdoW2L2TkqWfgihQw10Uk4 kx8rUz01bYXcEoLLkwq7c6O9ZWoZXqwMs/nhqQjQ94vXFwfjX/ix4jLA4n4YTa4knzFu w80cJYN2cKTLnSDP9vsPtEVsVgsL2ueRPCi1YthHxCTiGbGWfQoSHImI7SGtgrc2IKL/ y0kq5qC57BWI/Ffa11EYSAQNdxD8O8pjgWfX1iu7VG6v0qVF1aqR2D1SYC1jzKPsa6Yl pAxdh7qijjlf0kAukqC10k55G3oZ0aholZsy5qC1yZzZlDy14hjvuPkhmJQQV7Sp+gX3 SoZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680548569; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=erObc8aXeUQ4SchowS/WdE+uQHnisJkUn51WI4V6hUQ=; b=PzdftcxfmLmxIDZMk5eTdoYPZ2sGIosSbnGddKqLA/4m+Ssz/b8X6M6jIKcH2PCcm8 XkB2Ca43/R6WBymAlRZ+WbI4DjV9mV9WY7MdosqH8p+FkSSAZWkUl6JDBUcPO32lltd/ xnIUz6xyNp6sNizO058K2piIGYi7YRP2mojsCJPek3ayY//SoQ7tdmyo7l08aoVCNJqu VIogyWOCuZCj4fvxQGfh1HnGIynPJRDmWZHfTnbB6b63QFuFQ+e4XedL8tynL2WgUlKC 3/P5+e/O/R9z/AtbAad2cr2Om2k2ZjvgW6D1cl1ZOtoWb2hN1Hxb2+VXx6rVEBnBNhco XJ8g== X-Gm-Message-State: AAQBX9cMXX6njEDukbd4sr0qHCL7I/tUa2yBHQ36nKdxOT56C3KizJQv dmNRw3QHwQBG3bRiHLckGhA9ILd6RX8tlAkuJKU= X-Google-Smtp-Source: AKy350bMG4FMGxj3iSIZ3QKI4L5j35EN7QPkJfvxjnUaA1feQs+27vA8PtVVw0LElohz74owLGbBDDVCOXwMbXoK4r4= X-Received: by 2002:a25:d742:0:b0:b78:3a15:e6fe with SMTP id o63-20020a25d742000000b00b783a15e6femr153906ybg.2.1680548569005; Mon, 03 Apr 2023 12:02:49 -0700 (PDT) MIME-Version: 1.0 References: <20230319151017.531737-1-bugaevc@gmail.com> <20230319151017.531737-14-bugaevc@gmail.com> <20230402230934.djvtyoh5dayv23c2@begin> In-Reply-To: From: "H.J. Lu" Date: Mon, 3 Apr 2023 12:02:12 -0700 Message-ID: Subject: Re: [RFC PATCH glibc 13/34] x86-64: Disable prefer_map_32bit_exec tunable on non-Linux To: Sergey Bugaev Cc: Samuel Thibault , libc-alpha@sourceware.org, bug-hurd@gnu.org Content-Type: multipart/mixed; boundary="0000000000007bfb7005f87334c2" X-Spam-Status: No, score=-3022.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000007bfb7005f87334c2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Apr 3, 2023 at 3:10=E2=80=AFAM Sergey Bugaev wr= ote: > > On Mon, Apr 3, 2023 at 2:09=E2=80=AFAM Samuel Thibault wrote: > > Sergey Bugaev, le dim. 19 mars 2023 18:09:56 +0300, a ecrit: > > > While we could/should implement MAP_32BIT for the Hurd port by settin= g > > > all the high bits of mask in a vm_map () call, neither MAP_32BIT nor > > > glibc.cpu.prefer_map_32bit_exec exist on the Hurd as of now. Compile > > > this code out to fix build failures. > > > > Rather use defined(MAP_32BIT)? That way it will nicely work for BSD > > ports as well, and when hurd eventually supports MAP_32BIT. > > Not really. What breaks compilation here is not missing MAP_32BIT, but > rather the undefined set_prefer_map_32bit_exec tunable. It is defined > declaratively in sysdeps/unix/sysv/linux/x86_64/64/dl-tunables.list > (see commit 317f1c0a8a71a862b1e600ff5386b08e02cf4b95); so as-is, it > really is x86_64 Linux specific. > > Is there some way to check if a specific tunable is defined, like #if > HAVE_TUNABLE (prefer_map_32bit_exec)? AFAICS the generated > dl-tunable-list.h defines the C enum members, but not any checkable > preprocessor macros. > > Alternatively: maybe this part of cpu-features.c should be moved into > sysdeps/unix/sysv/linux/x86_64/64/cpu-features.c and #include_next the > common cpu-features.c? > Or something like this. --=20 H.J. --0000000000007bfb7005f87334c2 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-x86-64-Make-glibc.cpu.prefer_map_32bit_exec-Linux-sp.patch" Content-Disposition: attachment; filename="0001-x86-64-Make-glibc.cpu.prefer_map_32bit_exec-Linux-sp.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lg1773x70 RnJvbSAyNDA5MGEyMTlkOGJmOTAyZGI1MzBiZmQ5YmQ3M2U4MzdmMTNjNDM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IE1vbiwgMyBBcHIgMjAyMyAxMTo1NDozMCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIHg4Ni02NDog TWFrZSBnbGliYy5jcHUucHJlZmVyX21hcF8zMmJpdF9leGVjIExpbnV4IHNwZWNpZmljCgpBZGQg PG1hcC0zMmJpdC1leGVjLmg+IHRvIG1ha2UgZ2xpYmMuY3B1LnByZWZlcl9tYXBfMzJiaXRfZXhl YyBMaW51eApzcGVjaWZpYy4KLS0tCiAuLi4vc3lzdi9saW51eC94ODZfNjQvNjQvbWFwLTMyYml0 LWV4ZWMuaCAgICAgfCAyOSArKysrKysrKysrKysrKysrKysrCiBzeXNkZXBzL3g4Ni9jcHUtZmVh dHVyZXMuYyAgICAgICAgICAgICAgICAgICAgfCAxNiArKy0tLS0tLS0tCiBzeXNkZXBzL3g4Ni9t YXAtMzJiaXQtZXhlYy5oICAgICAgICAgICAgICAgICAgfCAxOSArKysrKysrKysrKysKIDMgZmls ZXMgY2hhbmdlZCwgNTAgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9k ZSAxMDA2NDQgc3lzZGVwcy91bml4L3N5c3YvbGludXgveDg2XzY0LzY0L21hcC0zMmJpdC1leGVj LmgKIGNyZWF0ZSBtb2RlIDEwMDY0NCBzeXNkZXBzL3g4Ni9tYXAtMzJiaXQtZXhlYy5oCgpkaWZm IC0tZ2l0IGEvc3lzZGVwcy91bml4L3N5c3YvbGludXgveDg2XzY0LzY0L21hcC0zMmJpdC1leGVj LmggYi9zeXNkZXBzL3VuaXgvc3lzdi9saW51eC94ODZfNjQvNjQvbWFwLTMyYml0LWV4ZWMuaApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwLi43NDc2Mzg1M2UxCi0tLSAvZGV2 L251bGwKKysrIGIvc3lzZGVwcy91bml4L3N5c3YvbGludXgveDg2XzY0LzY0L21hcC0zMmJpdC1l eGVjLmgKQEAgLTAsMCArMSwyOSBAQAorLyogSGFuZGxlIGdsaWJjLmNwdS5wcmVmZXJfbWFwXzMy Yml0X2V4ZWMuICBMaW51eC94ODYtNjQgdmVyc2lvbi4KKyAgIFRoaXMgZmlsZSBpcyBwYXJ0IG9m IHRoZSBHTlUgQyBMaWJyYXJ5LgorICAgQ29weXJpZ2h0IChDKSAyMDIzIEZyZWUgU29mdHdhcmUg Rm91bmRhdGlvbiwgSW5jLgorCisgICBUaGUgR05VIEMgTGlicmFyeSBpcyBmcmVlIHNvZnR3YXJl OyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKKyAgIG1vZGlmeSBpdCB1bmRlciB0aGUg dGVybXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyAgIExpY2Vuc2UgYXMgcHVi bGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgorICAgdmVyc2lv biAyLjEgb2YgdGhlIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNp b24uCisKKyAgIFRoZSBHTlUgQyBMaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRo YXQgaXQgd2lsbCBiZSB1c2VmdWwsCisgICBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhv dXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorICAgTUVSQ0hBTlRBQklMSVRZIG9yIEZJ VE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUKKyAgIExlc3NlciBH ZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisKKyAgIFlvdSBzaG91bGQg aGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyAg IExpY2Vuc2UgYWxvbmcgd2l0aCB0aGUgR05VIEMgTGlicmFyeTsgaWYgbm90LCBzZWUKKyAgIDxo dHRwczovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uICAqLworCitzdGF0aWMgdm9pZAorVFVOQUJM RV9DQUxMQkFDSyAoc2V0X3ByZWZlcl9tYXBfMzJiaXRfZXhlYykgKHR1bmFibGVfdmFsX3QgKnZh bHApCit7CisgIGlmICh2YWxwLT5udW12YWwpCisgICAgR0xSTyhkbF94ODZfY3B1X2ZlYXR1cmVz KS5wcmVmZXJyZWRbaW5kZXhfYXJjaF9QcmVmZXJfTUFQXzMyQklUX0VYRUNdCisgICAgICB8PSBi aXRfYXJjaF9QcmVmZXJfTUFQXzMyQklUX0VYRUM7Cit9CisKKyNkZWZpbmUgVFVOQUJMRV9HRVRf cHJlZmVyX21hcF8zMmJpdF9leGVjKCkgXAorICBUVU5BQkxFX0dFVCAocHJlZmVyX21hcF8zMmJp dF9leGVjLCB0dW5hYmxlX3ZhbF90ICosIFwKKwkgICAgICAgVFVOQUJMRV9DQUxMQkFDSyAoc2V0 X3ByZWZlcl9tYXBfMzJiaXRfZXhlYykpOwpkaWZmIC0tZ2l0IGEvc3lzZGVwcy94ODYvY3B1LWZl YXR1cmVzLmMgYi9zeXNkZXBzL3g4Ni9jcHUtZmVhdHVyZXMuYwppbmRleCA5NzhlYjI5ZjcyLi43 NWEwMTFkYWI3IDEwMDY0NAotLS0gYS9zeXNkZXBzL3g4Ni9jcHUtZmVhdHVyZXMuYworKysgYi9z eXNkZXBzL3g4Ni9jcHUtZmVhdHVyZXMuYwpAQCAtMjIsMjAgKzIyLDExIEBACiAjaW5jbHVkZSA8 Y2FjaGVpbmZvLmg+CiAjaW5jbHVkZSA8ZGwtY2FjaGVpbmZvLmg+CiAjaW5jbHVkZSA8ZGwtbWlu c2lnc3RhY2tzaXplLmg+CisjaW5jbHVkZSA8bWFwLTMyYml0LWV4ZWMuaD4KIAogZXh0ZXJuIHZv aWQgVFVOQUJMRV9DQUxMQkFDSyAoc2V0X2h3Y2FwcykgKHR1bmFibGVfdmFsX3QgKikKICAgYXR0 cmlidXRlX2hpZGRlbjsKIAotI2lmZGVmIF9fTFA2NF9fCi1zdGF0aWMgdm9pZAotVFVOQUJMRV9D QUxMQkFDSyAoc2V0X3ByZWZlcl9tYXBfMzJiaXRfZXhlYykgKHR1bmFibGVfdmFsX3QgKnZhbHAp Ci17Ci0gIGlmICh2YWxwLT5udW12YWwpCi0gICAgR0xSTyhkbF94ODZfY3B1X2ZlYXR1cmVzKS5w cmVmZXJyZWRbaW5kZXhfYXJjaF9QcmVmZXJfTUFQXzMyQklUX0VYRUNdCi0gICAgICB8PSBiaXRf YXJjaF9QcmVmZXJfTUFQXzMyQklUX0VYRUM7Ci19Ci0jZW5kaWYKLQogI2lmIENFVF9FTkFCTEVE CiBleHRlcm4gdm9pZCBUVU5BQkxFX0NBTExCQUNLIChzZXRfeDg2X2lidCkgKHR1bmFibGVfdmFs X3QgKikKICAgYXR0cmlidXRlX2hpZGRlbjsKQEAgLTcxMCwxMCArNzAxLDcgQEAgbm9fY3B1aWQ6 CiAKICAgVFVOQUJMRV9HRVQgKGh3Y2FwcywgdHVuYWJsZV92YWxfdCAqLCBUVU5BQkxFX0NBTExC QUNLIChzZXRfaHdjYXBzKSk7CiAKLSNpZmRlZiBfX0xQNjRfXwotICBUVU5BQkxFX0dFVCAocHJl ZmVyX21hcF8zMmJpdF9leGVjLCB0dW5hYmxlX3ZhbF90ICosCi0JICAgICAgIFRVTkFCTEVfQ0FM TEJBQ0sgKHNldF9wcmVmZXJfbWFwXzMyYml0X2V4ZWMpKTsKLSNlbmRpZgorICBUVU5BQkxFX0dF VF9wcmVmZXJfbWFwXzMyYml0X2V4ZWMgKCk7CiAKICAgYm9vbCBkaXNhYmxlX3hzYXZlX2ZlYXR1 cmVzID0gZmFsc2U7CiAKZGlmZiAtLWdpdCBhL3N5c2RlcHMveDg2L21hcC0zMmJpdC1leGVjLmgg Yi9zeXNkZXBzL3g4Ni9tYXAtMzJiaXQtZXhlYy5oCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAuLjk3NzEzMzhkZjMKLS0tIC9kZXYvbnVsbAorKysgYi9zeXNkZXBzL3g4Ni9t YXAtMzJiaXQtZXhlYy5oCkBAIC0wLDAgKzEsMTkgQEAKKy8qIEhhbmRsZSBnbGliYy5jcHUucHJl ZmVyX21hcF8zMmJpdF9leGVjLiAgR2VuZXJpYyB4ODYgdmVyc2lvbi4KKyAgIFRoaXMgZmlsZSBp cyBwYXJ0IG9mIHRoZSBHTlUgQyBMaWJyYXJ5LgorICAgQ29weXJpZ2h0IChDKSAyMDIzIEZyZWUg U29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgorCisgICBUaGUgR05VIEMgTGlicmFyeSBpcyBmcmVl IHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKKyAgIG1vZGlmeSBpdCB1 bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyAgIExpY2Vu c2UgYXMgcHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgor ICAgdmVyc2lvbiAyLjEgb2YgdGhlIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55IGxh dGVyIHZlcnNpb24uCisKKyAgIFRoZSBHTlUgQyBMaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRo ZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisgICBidXQgV0lUSE9VVCBBTlkgV0FSUkFO VFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorICAgTUVSQ0hBTlRBQklM SVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUKKyAg IExlc3NlciBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisKKyAgIFlv dSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQ dWJsaWMKKyAgIExpY2Vuc2UgYWxvbmcgd2l0aCB0aGUgR05VIEMgTGlicmFyeTsgaWYgbm90LCBz ZWUKKyAgIDxodHRwczovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uICAqLworCisjZGVmaW5lIFRV TkFCTEVfR0VUX3ByZWZlcl9tYXBfMzJiaXRfZXhlYygpCi0tIAoyLjM5LjIKCg== --0000000000007bfb7005f87334c2--