From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com
 [IPv6:2607:f8b0:4864:20::435])
 by sourceware.org (Postfix) with ESMTPS id 14BD3385842F
 for <libc-alpha@sourceware.org>; Sat, 12 Feb 2022 15:51:45 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14BD3385842F
Received: by mail-pf1-x435.google.com with SMTP id g1so1711568pfv.1
 for <libc-alpha@sourceware.org>; Sat, 12 Feb 2022 07:51:45 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to;
 bh=+vFSMynZAEaS4wykgCtTfEIhGAqC+rP5KyCmdsgBANI=;
 b=lw3/bByNCkp/ZfBtZ7sds9taYDeNhodlBI9QqbuNRe/bF/PYBGmPE1mNIDqs5AAPrS
 1ksygIVQBVFwG96f3AE7vFI842TYVrEaRbjLlg4JFsEdF4J7DJmM0kDtQuNEyTLkHEHg
 HGINhxmYoAZLOeS3M5uTVolK8xtVLokqDGFhHVwRGduGxc3qm0qgG2BMv4zcvCQ9nEhO
 kvvifqCJM9wUm5LkS/fNmENddRalTucx33d1vHDlUWCDuomG8sAY7h8x5jM3QaAGjrkk
 6qCR8r0fncIy9YKkNNhNb/8AIpOYuyWQD+Nv0PYk7ibAyuV3mNuyHd5l6rH/I4lsVjcF
 N2XA==
X-Gm-Message-State: AOAM5316ErVKH4uxcXFNtrvi8jHwOLGnpcCVYiYn2bIXhF+IjmsoHLzN
 UxN9KW2MxEcoBlkbgezwcmI7EZptwhEu3VYqlSt+Wfe2H/s=
X-Google-Smtp-Source: ABdhPJzeSAVAchKh0oqgqzJwKVLhZJS4Pcf7wTDWitC+VkjAACJQ97u09oyxKK6xeFRQMLmsH/HTML9JBd0OrVT2cck=
X-Received: by 2002:aa7:888b:: with SMTP id z11mr6587964pfe.76.1644681104034; 
 Sat, 12 Feb 2022 07:51:44 -0800 (PST)
MIME-Version: 1.0
References: <20220126202824.1810825-1-hjl.tools@gmail.com>
In-Reply-To: <20220126202824.1810825-1-hjl.tools@gmail.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Sat, 12 Feb 2022 07:51:08 -0800
Message-ID: <CAMe9rOrE2JpXB=t1creRTdH4_egP_BZ_TheRRe=r3kW9wM7zCg@mail.gmail.com>
Subject: Re: [PATCH] x86: Use CHECK_FEATURE_PRESENT on PCONFIG
To: GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3026.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Feb 2022 15:51:46 -0000

On Wed, Jan 26, 2022 at 12:28 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> PCONFIG is a privileged instruction.  Use CHECK_FEATURE_PRESENT, instead
> of CHECK_FEATURE_ACTIVE, on PCONFIG in tst-cpu-features-supports.c.
> ---
>  sysdeps/x86/tst-cpu-features-supports.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86/tst-cpu-features-supports.c b/sysdeps/x86/tst-cpu-features-supports.c
> index 46b2c7bf83..997b641449 100644
> --- a/sysdeps/x86/tst-cpu-features-supports.c
> +++ b/sysdeps/x86/tst-cpu-features-supports.c
> @@ -143,7 +143,7 @@ do_test (int argc, char **argv)
>    fails += CHECK_FEATURE_ACTIVE (movdiri, MOVDIRI);
>    fails += CHECK_FEATURE_ACTIVE (movdir64b, MOVDIR64B);
>    fails += CHECK_FEATURE_ACTIVE (osxsave, OSXSAVE);
> -  fails += CHECK_FEATURE_ACTIVE (pconfig, PCONFIG);
> +  fails += CHECK_FEATURE_PRESENT (pconfig, PCONFIG);
>    fails += CHECK_FEATURE_ACTIVE (pku, PKU);
>  #endif
>    fails += CHECK_FEATURE_ACTIVE (popcnt, POPCNT);
> --
> 2.34.1
>

I will check in this next Monday to fix the test on Intel Alder Lake.

-- 
H.J.