From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) by sourceware.org (Postfix) with ESMTPS id 0F9283858D32 for ; Wed, 5 Apr 2023 18:39:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F9283858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-54c061acbc9so14012367b3.11 for ; Wed, 05 Apr 2023 11:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680719943; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/Dt215YaJekfnvoIIAQzY3ha2bvX7Y4QJ5bna8vWaeE=; b=bWMSvE0vlRI9x6rhsOGCb4zIEi/4YKN/0y7JSwuO1QnY3UWIPvt4G2tTpvjtv6fDNJ cA7RnMqgPDoHpeglevxmACNd014jbV64SkhgQ72cAHmcrcoHDqEq44wbZXVu8W3+EKX/ rAncI6ExwvguygQWOdufRXdaZCVa4k0Owa9yao47YVbikfsCiZnbwVhYI8XLUhrrcI9M lsxI18eJCzZYrxpG+wz9kn2QN2d7FkP68hfkDSoV1pb/mBMH+Sv/jSWae0lvWChiNJBi /LY+r5VpxUlu2p2dz0jLtSTmMAiWxWCGhoAsfPma0vFHIndphNBYon8at23hrSpDIbL+ dtuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680719943; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Dt215YaJekfnvoIIAQzY3ha2bvX7Y4QJ5bna8vWaeE=; b=G+PyIHrd4ORTSxnQLnIUjvZ47C6VWusf7u4Bpjdz+2I01wkiIWXssusA+oyVP62xfQ 9fT5eTg2hpP735JqK2STvbLOx7yEBKy2X+zWUR22mSyidLYNPBDQ0BlUv6TTtMD9j8Mp R89FPTdhSjjPaUBpYB3l3hYWxpQCeb88RTmIghKUxLaKifRycYFc68Vfl5i7tGN3BXcz Ij59TWB5JiuT64cPvt3oy0YTj2eeBeneu8ZAen7EM/CgwWAZ1hhxQY6CA6uyqGsXrQ+s vETE8P3dtxkpCMBjhI7BmDGTmp09MBSMt0mF/FKVcyBbAz/mXQWTo671iz11oCEeEuPu xL2w== X-Gm-Message-State: AAQBX9d5DSNRBvSsV+hNdhZ150NIyxB6cNSJ/u4KoIq9XlajGN+ef7+0 oWJv0/GJLYb9VGE5ZfDdMq1OXybhlIwtqP1/ZV4= X-Google-Smtp-Source: AKy350ZTTPP2AtHnJBwP8ueIJylLhP5tSFIF4xnM+k7PnJuYLX5g/6dn9cXV+LFZ8fh6Z3aJw2+xEsO3wy3hCyfkIus= X-Received: by 2002:a81:4013:0:b0:545:62c0:621d with SMTP id l19-20020a814013000000b0054562c0621dmr4032621ywn.2.1680719943198; Wed, 05 Apr 2023 11:39:03 -0700 (PDT) MIME-Version: 1.0 References: <20230405162144.984598-1-hjl.tools@gmail.com> <20230405162144.984598-4-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Wed, 5 Apr 2023 11:38:27 -0700 Message-ID: Subject: Re: [PATCH 03/19] : Add LA57 support To: Noah Goldstein Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3021.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Apr 5, 2023 at 11:20=E2=80=AFAM Noah Goldstein wrote: > > On Wed, Apr 5, 2023 at 11:22=E2=80=AFAM H.J. Lu via Libc-alpha > wrote: > > > > Add 57-bit linear addresses and five-level paging (LA57) support to > > . > > --- > > manual/platform.texi | 3 +++ > > sysdeps/x86/bits/platform/x86.h | 2 +- > > sysdeps/x86/tst-get-cpu-features.c | 1 + > > 3 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/manual/platform.texi b/manual/platform.texi > > index c1cef570d2..9251b63e47 100644 > > --- a/manual/platform.texi > > +++ b/manual/platform.texi > > @@ -394,6 +394,9 @@ the indirect branch predictor barrier (IBPB). > > @item > > @code{L1D_FLUSH} -- IA32_FLUSH_CMD MSR. > > > > +@item > > +@code{LA57} -- 57-bit linear addresses and five-level paging. > > + > > @item > > @code{LAHF64_SAHF64} -- LAHF/SAHF available in 64-bit mode. > > > > diff --git a/sysdeps/x86/bits/platform/x86.h b/sysdeps/x86/bits/platfor= m/x86.h > > index 1ed24d7024..c9189fa248 100644 > > --- a/sysdeps/x86/bits/platform/x86.h > > +++ b/sysdeps/x86/bits/platform/x86.h > > @@ -182,7 +182,7 @@ enum > > x86_cpu_INDEX_7_ECX_13 =3D x86_cpu_index_7_ecx + 13, > > x86_cpu_AVX512_VPOPCNTDQ =3D x86_cpu_index_7_ecx + 14, > > x86_cpu_INDEX_7_ECX_15 =3D x86_cpu_index_7_ecx + 15, > > - x86_cpu_INDEX_7_ECX_16 =3D x86_cpu_index_7_ecx + 16, > > + x86_cpu_LA57 =3D x86_cpu_index_7_ecx + 16, > > /* Note: Bits 17-21: The value of MAWAU used by the BNDLDX and BNDSTX > > instructions in 64-bit mode. */ > > x86_cpu_RDPID =3D x86_cpu_index_7_ecx + 22, > > diff --git a/sysdeps/x86/tst-get-cpu-features.c b/sysdeps/x86/tst-get-c= pu-features.c > > index 1954698df8..5f5cd3e448 100644 > > --- a/sysdeps/x86/tst-get-cpu-features.c > > +++ b/sysdeps/x86/tst-get-cpu-features.c > > @@ -144,6 +144,7 @@ do_test (void) > > CHECK_CPU_FEATURE_PRESENT (AVX512_VNNI); > > CHECK_CPU_FEATURE_PRESENT (AVX512_BITALG); > > CHECK_CPU_FEATURE_PRESENT (AVX512_VPOPCNTDQ); > > + CHECK_CPU_FEATURE_PRESENT (LA57); > > CHECK_CPU_FEATURE_PRESENT (RDPID); > > CHECK_CPU_FEATURE_PRESENT (KL); > > CHECK_CPU_FEATURE_PRESENT (CLDEMOTE); > > -- > > 2.39.2 > > > Rename: > `#define bit_cpu_INDEX_7_ECX_16` > in cpu-features.h? cpu-features.h is used internally in glibc. Changes in cpu-features.h are needed only if we need to use CPU_FEATURE_SET_ACTIVE to mark a feature active. --=20 H.J.