From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id D86833857C52 for ; Fri, 22 Oct 2021 00:41:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D86833857C52 Received: by mail-pg1-x52d.google.com with SMTP id m21so1771067pgu.13 for ; Thu, 21 Oct 2021 17:41:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NTZRPrC+X8jW/Rm6/m83c6A/xpZ7cfMYosACKZWw7i0=; b=j66Vp0+UPK80LGjNTWMjFsonvn3H1tTuKjMQClpZehKooHof/hYrfnzYjf1tJIYXGd FBOF9sK4KpUAC6uLpFI0lH2Q6vU0UqV9BMUqR6sWxDkRceXVBngJ3nPJZi+ihZBd31JY 6L0nhXmaTCqQMjd7Ri0XvBJtr9sWQ3l9DeKXHEDcBgzFsarCtWhZJCrXXsRFYRWz5rzp YZ3LhZj9PRUNV9q0dDEk1uPits44+wAG71+JmksdNQezuV7HyA8Pkx1mK2Ky0h1l3J5P l+M3vWR4gbpygQHzWEyiX4mSsUMmfHstQ3LcT6zR53wBl+avcrgxi7zzQaF7tH1IF1mV +mwg== X-Gm-Message-State: AOAM530tR7R3RUGLlhjdjTIj0DS8IThb4LsAhLTlb3KShU47ZHLq5ga2 NsZpcnzC//KE859YAihstKCsA8cI/3Vo/XYQZ/o= X-Google-Smtp-Source: ABdhPJyhpjmgBRQGdx4Mx92N9vLf4VTM+1GMOn/tuQ6lWQvL+hs/nX3l0zFL4+1L7fDQ4wNfsKJLnvQWw7MqpUmDX9w= X-Received: by 2002:a63:6b82:: with SMTP id g124mr6979921pgc.20.1634863269954; Thu, 21 Oct 2021 17:41:09 -0700 (PDT) MIME-Version: 1.0 References: <20210927203827.2852935-1-goldstein.w.n@gmail.com> <20211021223850.415607-1-goldstein.w.n@gmail.com> <20211021223850.415607-2-goldstein.w.n@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Thu, 21 Oct 2021 17:40:33 -0700 Message-ID: Subject: Re: [PATCH v8 2/3] String: Add hidden defs for __memcmpeq() to enable internal usage To: Joseph Myers Cc: Noah Goldstein , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3022.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2021 00:41:12 -0000 On Thu, Oct 21, 2021 at 5:19 PM Joseph Myers wrote: > > On Thu, 21 Oct 2021, Noah Goldstein via Libc-alpha wrote: > > > > > The compiler knows other semantics of memcmp (it might sometimes expand a > > > > memcmp with a small fixed size inline, for example). So changing to a > > > > direct call to __memcmpeq by hand isn't even always an optimization; > > Will compilers not implement the same optimization for __memcmpeq? > > Why should they? It's intended as an ABI, not an API - that is, an > alternative assembler name the compiler name generate calls to, not a > function for which it should find calls in its input. > Compiler builtin optimization doesn't work well for glibc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67220 -- H.J.